[S] Change in flashrom[main]: libflashrom: Add API to enumerate supported programmers
Attention is currently required from: Dmitry Zhadinets. Anastasia Klimchuk has posted comments on this change by Dmitry Zhadinets. ( https://review.coreboot.org/c/flashrom/+/86921?usp=email ) The change is no longer submittable: All-Comments-Resolved is unsatisfied now. Change subject: libflashrom: Add API to enumerate supported programmers ...................................................................... Patch Set 11: Code-Review+2 (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/86921/comment/76622099_9ad8c570?usp... : PS10, Line 7: libflashrom: Added API to enumerate supported programmers
Done But you haven't changed the commit title :) It still says enumerate. For me it seems that enumerate is either about enums, or about nums (numbers) but none of these is here. Api returns the list of names.
When you update only commit title and nothing else, gerrit keeps all votes (approvals) for the patch. -- To view, visit https://review.coreboot.org/c/flashrom/+/86921?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ib5275b742b849183b1fe701900040fee369a1d78 Gerrit-Change-Number: 86921 Gerrit-PatchSet: 11 Gerrit-Owner: Dmitry Zhadinets <dzhadinets@gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine@chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Attention: Dmitry Zhadinets <dzhadinets@gmail.com> Gerrit-Comment-Date: Mon, 07 Apr 2025 10:19:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Dmitry Zhadinets <dzhadinets@gmail.com> Comment-In-Reply-To: Anastasia Klimchuk <aklm@chromium.org>
participants (1)
-
Anastasia Klimchuk (Code Review)