Attention is currently required from: Anastasia Klimchuk, Nikolai Artemiev, Stefan Reinauer. DZ has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/81835?usp=email ) Change subject: flashchips: Add support for MXIC MX25L1636E ...................................................................... Patch Set 3: (3 comments) File flashchips.c: https://review.coreboot.org/c/flashrom/+/81835/comment/3a5a08d4_3b33c196 : PS1, Line 9283: OTP: 64B total

I know it was like this before, but datasheets for both chips say 4k-bit secured OTP, so seems like […] Done

https://review.coreboot.org/c/flashrom/+/81835/comment/c464616f_e4b1ca3f : PS1, Line 9284: FEATURE_CFGR

None of datasheets have configuration register? Done

https://review.coreboot.org/c/flashrom/+/81835/comment/13364474_cb424798 : PS1, Line 9313: .tb = {CONFIG, 3, OTP}

Same as above, none of datasheets have configuration register Done

-- To view, visit https://review.coreboot.org/c/flashrom/+/81835?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I415e2d6c89d3d59ba44e22753001c6f69421c39d Gerrit-Change-Number: 81835 Gerrit-PatchSet: 3 Gerrit-Owner: DZ <danielzhang@mxic.com.cn> Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev@google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer@coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer@coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm@chromium.org> Gerrit-Attention: Nikolai Artemiev <nartemiev@google.com> Gerrit-Comment-Date: Mon, 29 Apr 2024 02:48:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm@chromium.org> Gerrit-MessageType: comment