Nikolai Artemiev has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/46140 ) Change subject: s25f.c: import from cros flashrom ...................................................................... Patch Set 11: (3 comments) https://review.coreboot.org/c/flashrom/+/46140/2//COMMIT_MSG Commit Message: https://review.coreboot.org/c/flashrom/+/46140/2//COMMIT_MSG@9 PS2, Line 9: Imported
"Adapted" […] Done
https://review.coreboot.org/c/flashrom/+/46140/5/Makefile File Makefile: https://review.coreboot.org/c/flashrom/+/46140/5/Makefile@641 PS5, Line 641: s25f.o
add this to the meson build system as well Done
https://review.coreboot.org/c/flashrom/+/46140/2/chipdrivers.h File chipdrivers.h: https://review.coreboot.org/c/flashrom/+/46140/2/chipdrivers.h@24 PS2, Line 24: #include "writeprotect.h" /* for modifier_bits */
I hear you however I think it's worth separating out into another commit. […] Done
-- To view, visit https://review.coreboot.org/c/flashrom/+/46140 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I2d23f9c36ce8b2959807fbeee7f60e02444e3763 Gerrit-Change-Number: 46140 Gerrit-PatchSet: 11 Gerrit-Owner: Nikolai Artemiev <nartemiev@google.com> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-CC: Sam McNally <sammc@google.com> Gerrit-Comment-Date: Mon, 23 Nov 2020 03:01:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Edward O'Callaghan <quasisec@chromium.org> Comment-In-Reply-To: Nikolai Artemiev <nartemiev@google.com> Gerrit-MessageType: comment