Attention is currently required from: Nico Huber, Daniel Campello, Anastasia Klimchuk, Peter Marheine. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/33542 ) Change subject: layout: Introduce layout_next() ...................................................................... Patch Set 4: Code-Review+2 (2 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/33542/comment/8e68d3df_38c33b06 PS3, Line 7: layout: Introduce layout_next() : : Also, a `layout.c` internal version _layout_next()
I added both, the API one uses pointers to const struct romentries […] The `_` prefix definitely requires extra cognitive load for the causal reader if one is not use to the `_` prefix to mean internal convention. Given that so many functions have such similar names in the file I think the `mutable_layout_next()` alternative you suggested Nico is a better choice to go with.
File layout.c: https://review.coreboot.org/c/flashrom/+/33542/comment/4da6d379_d9294a3a PS3, Line 44: static struct romentry *_layout_next(
Their signatures differ, see comment thread on the commit message. Nico is correct, one is const while the other isn't. I think the rename to `mutable_layout_next()` will fix up the confusion.
-- To view, visit https://review.coreboot.org/c/flashrom/+/33542 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I284958471c61344d29d92c95d88475065a9ca9aa Gerrit-Change-Number: 33542 Gerrit-PatchSet: 4 Gerrit-Owner: Nico Huber <nico.h@gmx.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz> Gerrit-Reviewer: Daniel Campello <campello@chromium.org> Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine@chromium.org> Gerrit-Reviewer: Thomas Heijligen <src@posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Paul Menzel <paulepanter@mailbox.org> Gerrit-Attention: Nico Huber <nico.h@gmx.de> Gerrit-Attention: Daniel Campello <campello@chromium.org> Gerrit-Attention: Anastasia Klimchuk <aklm@chromium.org> Gerrit-Attention: Peter Marheine <pmarheine@chromium.org> Gerrit-Comment-Date: Sun, 16 May 2021 03:43:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Nico Huber <nico.h@gmx.de> Comment-In-Reply-To: Anastasia Klimchuk <aklm@chromium.org> Comment-In-Reply-To: Peter Marheine <pmarheine@chromium.org> Gerrit-MessageType: comment