Attention is currently required from: David Hendricks, Paul Menzel, Thomas Heijligen, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/31016 ) Change subject: hwaccess: Add endianness converting deserialization functions ...................................................................... Patch Set 8: (1 comment) Patchset: PS8: What I mentioned to Thomas offline once: We could also add an offset parameter. e.g. uint32_t read_le32(const void *src, size_t offset); This would have the benefit that the reader would always see that the offset is in bytes. For instance, consider these two calls: uint32_t *buf, val; ... val = read_le32(buf + 3); val = read_le32(buf, 12); They are supposed to do the same. But in the first case we need to have pointer-arithmetic in mind to see it. The second case would always be the same, no matter the type of `buf`. -- To view, visit https://review.coreboot.org/c/flashrom/+/31016 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Idde177acf8bc5f94cd046b6539dc31532c98e452 Gerrit-Change-Number: 31016 Gerrit-PatchSet: 8 Gerrit-Owner: Nico Huber <nico.h@gmx.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org> Gerrit-Reviewer: Nico Huber <nico.h@gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter@mailbox.org> Gerrit-Reviewer: Thomas Heijligen <src@posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Attention: David Hendricks <david.hendricks@gmail.com> Gerrit-Attention: Paul Menzel <paulepanter@mailbox.org> Gerrit-Attention: Thomas Heijligen <src@posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec@chromium.org> Gerrit-Attention: Angel Pons <th3fanbus@gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm@chromium.org> Gerrit-Comment-Date: Fri, 03 Sep 2021 11:54:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment