Attention is currently required from: Nico Huber, David Hendricks, Edward O'Callaghan. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/31016 ) Change subject: hwaccess: add endianness converting deserialization functions ...................................................................... Patch Set 20: (2 comments) File platform.h: https://review.coreboot.org/c/flashrom/+/31016/comment/22bac632_9b5101f7 PS19, Line 111: const base, const size_t offset
The latter 2 `const` are superfluous in a forward declaration. […] Done
File platform/memaccess.c: https://review.coreboot.org/c/flashrom/+/31016/comment/1017909a_8c5c1c58 PS19, Line 26: base + offset
That would mean every caller who has a pointer (they usually have) […] Done
-- To view, visit https://review.coreboot.org/c/flashrom/+/31016 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Idde177acf8bc5f94cd046b6539dc31532c98e452 Gerrit-Change-Number: 31016 Gerrit-PatchSet: 20 Gerrit-Owner: Nico Huber <nico.h@gmx.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org> Gerrit-Reviewer: Nico Huber <nico.h@gmx.de> Gerrit-Reviewer: Thomas Heijligen <src@posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Paul Menzel <paulepanter@mailbox.org> Gerrit-Attention: Nico Huber <nico.h@gmx.de> Gerrit-Attention: David Hendricks <david.hendricks@gmail.com> Gerrit-Attention: Edward O'Callaghan <quasisec@chromium.org> Gerrit-Comment-Date: Tue, 12 Apr 2022 12:45:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h@gmx.de> Comment-In-Reply-To: Thomas Heijligen <src@posteo.de> Gerrit-MessageType: comment