Attention is currently required from: Nico Huber, Edward O'Callaghan, Daniel Campello, Angel Pons, Anastasia Klimchuk, Nikolai Artemiev. David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/30979 ) Change subject: [RFC] cli_classic: Add `--mode (read|write|verify|erase)` parameter ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: I came up with another option that I think addresses many of the concerns raised here: https://flashrom.org/Per_region_file_arguments#Alternative_.233 Advantages: - No positional or optional argument after -r/-w/-v. This simplifies them and makes them consistent with -E, so this approach *actually* reduces combinatorics. - -r/-w/-v is specified exactly once. - No added modes. - Arguments are handled similarly to standard Unix commands (ls, rm, cat, etc) - Backwards-compatible with flashrom syntax prior to CB:23021 LMK what you think. -- To view, visit https://review.coreboot.org/c/flashrom/+/30979 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Idfba11ec9991aac423b07f68f7dc45e7bebbb06b Gerrit-Change-Number: 30979 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h@gmx.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz> Gerrit-Reviewer: Carl-Daniel Hailfinger <hailfinger@gmail.com> Gerrit-Reviewer: Daniel Campello <campello@chromium.org> Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org> Gerrit-Reviewer: Nico Huber <nico.h@gmx.de> Gerrit-Reviewer: Nikolai Artemiev <nartemiev@google.com> Gerrit-Reviewer: Paul Menzel <paulepanter@mailbox.org> Gerrit-Reviewer: Stefan T <stefan.tauner@gmx.at> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Attention: Nico Huber <nico.h@gmx.de> Gerrit-Attention: Edward O'Callaghan <quasisec@chromium.org> Gerrit-Attention: Daniel Campello <campello@chromium.org> Gerrit-Attention: Angel Pons <th3fanbus@gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm@chromium.org> Gerrit-Attention: Nikolai Artemiev <nartemiev@google.com> Gerrit-Comment-Date: Tue, 11 May 2021 16:21:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment