Brian Nemec has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/41596 ) Change subject: raiden_debug_spi.c: Renaming Protocol V1 specific fields ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/c/flashrom/+/41596/1/raiden_debug_spi.c File raiden_debug_spi.c: https://review.coreboot.org/c/flashrom/+/41596/1/raiden_debug_spi.c@372 PS1, Line 372: .features = SPI_MASTER_4BA,
Why do tabs become spaces here? So they are consistently aligned. Every other project I work with switches between 4 or 8 space tabs making tabs terrible for alignment since one of the 2 options will always break. So I try to adopt the tabs for indentation, spaces for alignment convention.
-- To view, visit https://review.coreboot.org/c/flashrom/+/41596 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I70b43af50d872d850dae287d99bcd768107a1cad Gerrit-Change-Number: 41596 Gerrit-PatchSet: 1 Gerrit-Owner: Brian Nemec <bnemec@google.com> Gerrit-Reviewer: Brian Nemec <bnemec@chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Angel Pons <th3fanbus@gmail.com> Gerrit-Comment-Date: Thu, 11 Jun 2020 17:12:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com> Gerrit-MessageType: comment