Attention is currently required from: David Hendricks, Edward O'Callaghan, Angel Pons. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/31012 ) Change subject: cli_classic: Report the gathered layout entries at level dbg ...................................................................... Patch Set 4: (3 comments) File layout.c: https://review.coreboot.org/c/flashrom/+/31012/comment/046e0185_3cd78f5c PS3, Line 436: l->num_entries
Done, thoughts? I probably only put the number there because it was part of the struct. The important part was to have some feedback about possible arguments to `-i`.
Doesn't hurt to print it anyway, though ;) File layout.c: https://review.coreboot.org/c/flashrom/+/31012/comment/e27b495b_e31cc780 PS4, Line 436: for (struct romentry *entry = l->head; entry; entry = entry->next) { Please use `layout_next()`. https://review.coreboot.org/c/flashrom/+/31012/comment/4a9a29ee_835d73f4 PS4, Line 441: msg_gdbg("Total %u entries\n", i); It feels like we might want a period at the end. I know it's not a complete sentence anyway. -- To view, visit https://review.coreboot.org/c/flashrom/+/31012 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I7678ba5138f0d722ee44747fe123f192abdd0ffd Gerrit-Change-Number: 31012 Gerrit-PatchSet: 4 Gerrit-Owner: Nico Huber <nico.h@gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org> Gerrit-Reviewer: Thomas Heijligen <src@posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Paul Menzel <paulepanter@mailbox.org> Gerrit-Attention: David Hendricks <david.hendricks@gmail.com> Gerrit-Attention: Edward O'Callaghan <quasisec@chromium.org> Gerrit-Attention: Angel Pons <th3fanbus@gmail.com> Gerrit-Comment-Date: Fri, 04 Nov 2022 16:11:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Edward O'Callaghan <quasisec@chromium.org> Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com> Gerrit-MessageType: comment