- flashrom-gerrit - mail.coreboot.org

[M] Change in flashrom[main]: flashchips: Add Boya BY25D20/40
by Abdelkader Boudih (Code Review) July 18, 2026

July 18, 2026

Attention is currently required from: Nikolai Artemiev, Rafael Franco, Stefan Reinauer. Abdelkader Boudih has posted comments on this change by Rafael Franco. ( https://review.coreboot.org/c/flashrom/+/94040?usp=email ) Change subject: flashchips: Add Boya BY25D20/40 ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/94040?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ibf2075de76dfe6172cab82984fa15a2b86d816c3 Gerrit-Change-Number: 94040 Gerrit-PatchSet: 3 Gerrit-Owner: Rafael Franco <git(a)rafaelfranco.es> Gerrit-Reviewer: Abdelkader Boudih <coreboot(a)seuros.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Rafael Franco <git(a)rafaelfranco.es> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Sat, 18 Jul 2026 13:31:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in flashrom[main]: flashchips.c: Add support for BY25D40A
by Anastasia Klimchuk (Code Review) July 18, 2026

July 18, 2026

Anastasia Klimchuk has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/76765?usp=email ) Change subject: flashchips.c: Add support for BY25D40A ...................................................................... Abandoned There was no response, so this got forgotten :\ But the support for the model is added in CB:94040 -- To view, visit https://review.coreboot.org/c/flashrom/+/76765?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I74a884549b24b1792e27c67ec65a1b185afc84e8 Gerrit-Change-Number: 76765 Gerrit-PatchSet: 1 Gerrit-Owner: Giammarco Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org>

1 0

[S] Change in flashrom[main]: flashchips: Add support for Boya BY25D40
by Anastasia Klimchuk (Code Review) July 18, 2026

July 18, 2026

Anastasia Klimchuk has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/81605?usp=email ) Change subject: flashchips: Add support for Boya BY25D40 ...................................................................... Abandoned There was no response, so this got forgotten :\ But the support for the model is added in CB:94040 -- To view, visit https://review.coreboot.org/c/flashrom/+/81605?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I9e07a48dce3988e9d75cf02fca1f4a048c2e0cad Gerrit-Change-Number: 81605 Gerrit-PatchSet: 1 Gerrit-Owner: Dmitry Mikushin <dmitry(a)kernelgen.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[M] Change in flashrom[main]: flashchips: Add Boya BY25D20/40
by Anastasia Klimchuk (Code Review) July 18, 2026

July 18, 2026

Attention is currently required from: Nikolai Artemiev, Rafael Franco, Stefan Reinauer. Anastasia Klimchuk has posted comments on this change by Rafael Franco. ( https://review.coreboot.org/c/flashrom/+/94040?usp=email ) Change subject: flashchips: Add Boya BY25D20/40 ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/94040?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ibf2075de76dfe6172cab82984fa15a2b86d816c3 Gerrit-Change-Number: 94040 Gerrit-PatchSet: 3 Gerrit-Owner: Rafael Franco <git(a)rafaelfranco.es> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Rafael Franco <git(a)rafaelfranco.es> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Sat, 18 Jul 2026 13:06:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in flashrom[main]: flashchips: Add Boya BY25D20/40
by Rafael Franco (Code Review) July 18, 2026

July 18, 2026

Attention is currently required from: Anastasia Klimchuk, Nikolai Artemiev, Stefan Reinauer. Rafael Franco has posted comments on this change by Rafael Franco. ( https://review.coreboot.org/c/flashrom/+/94040?usp=email ) Change subject: flashchips: Add Boya BY25D20/40 ...................................................................... Patch Set 3: (2 comments) Patchset: PS1: > Hello Rafael, thank you for your patch. […] Hi Anastasia. Thank you for taking the time to review my patch :) File include/flashchips.h: https://review.coreboot.org/c/flashrom/+/94040/comment/c6d9a0ff_3f73a536?us… : PS1, Line 206: #define BOYA_BOHONG_B_25D20 0x4012 > Would you move the 0x4012 to be first, and then 0x4013? and after those new ones 0x4014, and then al […] Done! I don't know why I didn't do that to begin with, I even remember thinking about it... -- To view, visit https://review.coreboot.org/c/flashrom/+/94040?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ibf2075de76dfe6172cab82984fa15a2b86d816c3 Gerrit-Change-Number: 94040 Gerrit-PatchSet: 3 Gerrit-Owner: Rafael Franco <git(a)rafaelfranco.es> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Sat, 18 Jul 2026 11:34:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[M] Change in flashrom[main]: flashchips: Add Boya BY25D20/40
by Rafael Franco (Code Review) July 18, 2026

July 18, 2026

Attention is currently required from: Nikolai Artemiev, Rafael Franco, Stefan Reinauer. Hello Anastasia Klimchuk, Nikolai Artemiev, Stefan Reinauer, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/94040?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: flashchips: Add Boya BY25D20/40 ...................................................................... flashchips: Add Boya BY25D20/40 Only tested reading the BY25D40, using an FT232H. Datasheet: https://www.lcsc.com/datasheet/C384591.pdf Change-Id: Ibf2075de76dfe6172cab82984fa15a2b86d816c3 Signed-off-by: Rafael Franco <git(a)rafaelfranco.es> --- M flashchips/boya_bohong.c M include/flashchips.h 2 files changed, 79 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/40/94040/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/94040?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ibf2075de76dfe6172cab82984fa15a2b86d816c3 Gerrit-Change-Number: 94040 Gerrit-PatchSet: 3 Gerrit-Owner: Rafael Franco <git(a)rafaelfranco.es> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Rafael Franco <git(a)rafaelfranco.es> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com>

1 0

[M] Change in flashrom[main]: flashchips: Add Boya BY25D20/40
by Rafael Franco (Code Review) July 18, 2026

July 18, 2026

Attention is currently required from: Nikolai Artemiev, Rafael Franco, Stefan Reinauer. Hello Anastasia Klimchuk, Nikolai Artemiev, Stefan Reinauer, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/94040?usp=email to look at the new patch set (#2). Change subject: flashchips: Add Boya BY25D20/40 ...................................................................... flashchips: Add Boya BY25D20/40 Only tested reading the BY25D40, using an FT232H. Datasheet: https://www.lcsc.com/datasheet/C384591.pdf Change-Id: Ibf2075de76dfe6172cab82984fa15a2b86d816c3 Signed-off-by: Rafael Franco <git(a)rafaelfranco.es> --- M flashchips/boya_bohong.c M include/flashchips.h 2 files changed, 79 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/40/94040/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/94040?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ibf2075de76dfe6172cab82984fa15a2b86d816c3 Gerrit-Change-Number: 94040 Gerrit-PatchSet: 2 Gerrit-Owner: Rafael Franco <git(a)rafaelfranco.es> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Rafael Franco <git(a)rafaelfranco.es> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com>

1 0

[M] Change in flashrom[main]: par_mmio: Add shared MMIO accessors for parallel PCI drivers
by Anastasia Klimchuk (Code Review) July 18, 2026

July 18, 2026

Attention is currently required from: Abdelkader Boudih, Peter Marheine. Anastasia Klimchuk has posted comments on this change by Abdelkader Boudih. ( https://review.coreboot.org/c/flashrom/+/93786?usp=email ) Change subject: par_mmio: Add shared MMIO accessors for parallel PCI drivers ...................................................................... Patch Set 4: Code-Review+2 (1 comment) File programmers/par_mmio.c: https://review.coreboot.org/c/flashrom/+/93786/comment/5f967115_ab4e0e2f?us… : PS1, Line 14: flash->mst->par.data > Yep, that is correct. […] Done -- To view, visit https://review.coreboot.org/c/flashrom/+/93786?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I660cc2e82450da605ab4242389bcf6c3f94da6cc Gerrit-Change-Number: 93786 Gerrit-PatchSet: 4 Gerrit-Owner: Abdelkader Boudih <coreboot(a)seuros.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Abdelkader Boudih <coreboot(a)seuros.com> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Sat, 18 Jul 2026 10:42:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Abdelkader Boudih <coreboot(a)seuros.com> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[M] Change in flashrom[main]: par_mmio: Add shared MMIO accessors for parallel PCI drivers
by Abdelkader Boudih (Code Review) July 18, 2026

July 18, 2026

Attention is currently required from: Anastasia Klimchuk, Peter Marheine. Abdelkader Boudih has posted comments on this change by Abdelkader Boudih. ( https://review.coreboot.org/c/flashrom/+/93786?usp=email ) Change subject: par_mmio: Add shared MMIO accessors for parallel PCI drivers ...................................................................... Patch Set 4: (1 comment) File programmers/par_mmio.c: https://review.coreboot.org/c/flashrom/+/93786/comment/df4c8900_b6871353?us… : PS1, Line 14: flash->mst->par.data > I know it's void* but what is actually there is pointer to the programmer's data struct, and each ha […] Yep, that is correct. Added a comment on each struct plus one above the accessors in par_mmio.c -- To view, visit https://review.coreboot.org/c/flashrom/+/93786?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I660cc2e82450da605ab4242389bcf6c3f94da6cc Gerrit-Change-Number: 93786 Gerrit-PatchSet: 4 Gerrit-Owner: Abdelkader Boudih <coreboot(a)seuros.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Sat, 18 Jul 2026 10:32:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Abdelkader Boudih <coreboot(a)seuros.com> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[M] Change in flashrom[main]: par_mmio: Add shared MMIO accessors for parallel PCI drivers
by Abdelkader Boudih (Code Review) July 18, 2026

July 18, 2026

Attention is currently required from: Abdelkader Boudih, Peter Marheine. Hello Anastasia Klimchuk, Peter Marheine, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/93786?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: par_mmio: Add shared MMIO accessors for parallel PCI drivers ...................................................................... par_mmio: Add shared MMIO accessors for parallel PCI drivers Added a shared mixin to collapse these legacy programmers into compact code. Change-Id: I660cc2e82450da605ab4242389bcf6c3f94da6cc Signed-off-by: Abdelkader Boudih <coreboot(a)seuros.com> --- A include/par_mmio.h M meson.build M programmers/gfxnvidia.c M programmers/it8212.c M programmers/nicintel.c A programmers/par_mmio.c 6 files changed, 80 insertions(+), 61 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/86/93786/4 -- To view, visit https://review.coreboot.org/c/flashrom/+/93786?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I660cc2e82450da605ab4242389bcf6c3f94da6cc Gerrit-Change-Number: 93786 Gerrit-PatchSet: 4 Gerrit-Owner: Abdelkader Boudih <coreboot(a)seuros.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Abdelkader Boudih <coreboot(a)seuros.com> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org>

1 0