September 2026 - flashrom-gerrit

[S] Change in flashrom[main]: dmi: Recognise SMBIOS 3 chassis types
by Abdelkader Boudih (Code Review) Sept. 30, 2026

Sept. 30, 2026

Abdelkader Boudih has posted comments on this change by Abdelkader Boudih. ( https://review.coreboot.org/c/flashrom/+/95826?usp=email ) Change subject: dmi: Recognise SMBIOS 3 chassis types ...................................................................... Patch Set 1: (1 comment) File dmi.c: https://review.coreboot.org/c/flashrom/+/95826/comment/c1d4c116_fc33d398?us… : PS1, Line 81: {0x23, 0, "Mini PC"} > An unknown chassis type falls through to is_laptop. […] There is a newer version https://www.dmtf.org/sites/default/files/standards/documents/DSP0134_3.10.0… Note to self. -- To view, visit https://review.coreboot.org/c/flashrom/+/95826?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I36c3c154d988eaa10de577bcdfa93ee5f619fa7d Gerrit-Change-Number: 95826 Gerrit-PatchSet: 1 Gerrit-Owner: Abdelkader Boudih <coreboot(a)seuros.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 30 Sep 2026 14:10:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Abdelkader Boudih <coreboot(a)seuros.com> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[S] Change in flashrom[main]: dmi: Recognise SMBIOS 3 chassis types
by Anastasia Klimchuk (Code Review) Sept. 30, 2026

Sept. 30, 2026

Attention is currently required from: Abdelkader Boudih. Anastasia Klimchuk has posted comments on this change by Abdelkader Boudih. ( https://review.coreboot.org/c/flashrom/+/95826?usp=email ) Change subject: dmi: Recognise SMBIOS 3 chassis types ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/95826?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I36c3c154d988eaa10de577bcdfa93ee5f619fa7d Gerrit-Change-Number: 95826 Gerrit-PatchSet: 1 Gerrit-Owner: Abdelkader Boudih <coreboot(a)seuros.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Abdelkader Boudih <coreboot(a)seuros.com> Gerrit-Comment-Date: Wed, 30 Sep 2026 11:22:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[L] Change in flashrom[main]: github: Build and package Linux, macOS and Windows binaries
by Abdelkader Boudih (Code Review) Sept. 30, 2026

Sept. 30, 2026

Attention is currently required from: Dreg, Stefan Reinauer. Abdelkader Boudih has posted comments on this change by Stefan Reinauer. ( https://review.coreboot.org/c/flashrom/+/95836?usp=email ) Change subject: github: Build and package Linux, macOS and Windows binaries ...................................................................... Patch Set 1: (2 comments) Patchset: PS1: Before we package the macos binary, we need to see the signing. Any binary non signed will refuse to run on MacOS. File .github/BUILDING.md: https://review.coreboot.org/c/flashrom/+/95836/comment/9b5587aa_65fecf9e?us… : PS1, Line 1: # GitHub binary builds > I just wanted to check, is this an instruction for humans to read, or is this for the automated work […] We can remove this file. -- To view, visit https://review.coreboot.org/c/flashrom/+/95836?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I31a91e3ffcedde53d4f7f130a1d1dabbd634615c Gerrit-Change-Number: 95836 Gerrit-PatchSet: 1 Gerrit-Owner: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Abdelkader Boudih <coreboot(a)seuros.com> Gerrit-Reviewer: Dreg <regueragarciadavid(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Dreg <regueragarciadavid(a)gmail.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Comment-Date: Wed, 30 Sep 2026 07:34:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[S] Change in flashrom[main]: dmi: Recognise SMBIOS 3 chassis types
by Abdelkader Boudih (Code Review) Sept. 30, 2026

Sept. 30, 2026

Attention is currently required from: Anastasia Klimchuk. Abdelkader Boudih has posted comments on this change by Abdelkader Boudih. ( https://review.coreboot.org/c/flashrom/+/95826?usp=email ) Change subject: dmi: Recognise SMBIOS 3 chassis types ...................................................................... Patch Set 1: (2 comments) File dmi.c: https://review.coreboot.org/c/flashrom/+/95826/comment/2727be36_57f6b8fe?us… : PS1, Line 53: * (SMBIOS) Reference Specification 3.7.0 section 7.4.1 "Chassis Types" at : * https://www.dmtf.org/sites/default/files/standards/documents/DSP0134_3.7.0.… > 05h is Pizza Box, 10h is Lunch Box! what is that :D […] Those are chassis format, the Pizza box is the computer that was flat/thin and we use to put a CRT screen on top. The Lunch box is older, and had a foldable keyboard. We wont add it because that is not used anymore. -- Sent from my Pizza Box -- https://review.coreboot.org/c/flashrom/+/95826/comment/45e4a0c2_04b3033d?us… : PS1, Line 81: {0x23, 0, "Mini PC"} > I was wondering what does it mean "Mini PC got the laptop treatment" (from commit message), but here […] An unknown chassis type falls through to is_laptop. internal.c then disables the internal buses the same way it does for a detected laptop, and the user has to pass laptop=this_is_not_a_laptop. Since we have copied all the spec from Reference Specification 3.7.0, we can simplify this in a followup to remove the laptop fallback. Only chassis that return Unknown/Other will get other path. PS: Once i finish reading 3.7.0 , i will see 3.8.0 then 3.9.0 and update accordingly. I did not want to do an edge jump and risking to drop support for existing hardware. PS: Lunch Box still exist in 3.9.0 :) -- To view, visit https://review.coreboot.org/c/flashrom/+/95826?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I36c3c154d988eaa10de577bcdfa93ee5f619fa7d Gerrit-Change-Number: 95826 Gerrit-PatchSet: 1 Gerrit-Owner: Abdelkader Boudih <coreboot(a)seuros.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Wed, 30 Sep 2026 07:30:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[L] Change in flashrom[main]: github: Build and package Linux, macOS and Windows binaries
by Anastasia Klimchuk (Code Review) Sept. 29, 2026

Sept. 29, 2026

Attention is currently required from: Abdelkader Boudih, Dreg, Stefan Reinauer. Anastasia Klimchuk has posted comments on this change by Stefan Reinauer. ( https://review.coreboot.org/c/flashrom/+/95836?usp=email ) Change subject: github: Build and package Linux, macOS and Windows binaries ...................................................................... Patch Set 1: (2 comments) Patchset: PS1: Stefan, would you agree to add yourself as a maintainer for all of this amazing stuff that you wrote? As a file path, I think you can use the whole .github directory plus the new script? The entry can go into UTILS section. Thank you so much! File .github/BUILDING.md: https://review.coreboot.org/c/flashrom/+/95836/comment/59acae3e_ffd02bc0?us… : PS1, Line 1: # GitHub binary builds I just wanted to check, is this an instruction for humans to read, or is this for the automated workflow? -- To view, visit https://review.coreboot.org/c/flashrom/+/95836?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I31a91e3ffcedde53d4f7f130a1d1dabbd634615c Gerrit-Change-Number: 95836 Gerrit-PatchSet: 1 Gerrit-Owner: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Abdelkader Boudih <coreboot(a)seuros.com> Gerrit-Reviewer: Dreg <regueragarciadavid(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Abdelkader Boudih <coreboot(a)seuros.com> Gerrit-Attention: Dreg <regueragarciadavid(a)gmail.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Comment-Date: Wed, 30 Sep 2026 06:58:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in flashrom[main]: dmi: Recognise SMBIOS 3 chassis types
by Anastasia Klimchuk (Code Review) Sept. 29, 2026

Sept. 29, 2026

Attention is currently required from: Abdelkader Boudih. Anastasia Klimchuk has posted comments on this change by Abdelkader Boudih. ( https://review.coreboot.org/c/flashrom/+/95826?usp=email ) Change subject: dmi: Recognise SMBIOS 3 chassis types ...................................................................... Patch Set 1: (2 comments) File dmi.c: https://review.coreboot.org/c/flashrom/+/95826/comment/cf835b13_4447be7f?us… : PS1, Line 53: * (SMBIOS) Reference Specification 3.7.0 section 7.4.1 "Chassis Types" at : * https://www.dmtf.org/sites/default/files/standards/documents/DSP0134_3.7.0.… 05h is Pizza Box, 10h is Lunch Box! what is that :D (not a comment to this patch :)) https://review.coreboot.org/c/flashrom/+/95826/comment/6b16e811_76709180?us… : PS1, Line 81: {0x23, 0, "Mini PC"} I was wondering what does it mean "Mini PC got the laptop treatment" (from commit message), but here is_laptop == 0 ? -- To view, visit https://review.coreboot.org/c/flashrom/+/95826?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I36c3c154d988eaa10de577bcdfa93ee5f619fa7d Gerrit-Change-Number: 95826 Gerrit-PatchSet: 1 Gerrit-Owner: Abdelkader Boudih <coreboot(a)seuros.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Abdelkader Boudih <coreboot(a)seuros.com> Gerrit-Comment-Date: Wed, 30 Sep 2026 06:32:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in flashrom[main]: dmi: Locate the SMBIOS entry point via the loader on FreeBSD
by Anastasia Klimchuk (Code Review) Sept. 29, 2026

Sept. 29, 2026

Attention is currently required from: Abdelkader Boudih. Anastasia Klimchuk has posted comments on this change by Abdelkader Boudih. ( https://review.coreboot.org/c/flashrom/+/95825?usp=email ) Change subject: dmi: Locate the SMBIOS entry point via the loader on FreeBSD ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/95825?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I3a3f6e4d25a493dc15530014483b9a9b670ccfca Gerrit-Change-Number: 95825 Gerrit-PatchSet: 1 Gerrit-Owner: Abdelkader Boudih <coreboot(a)seuros.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Abdelkader Boudih <coreboot(a)seuros.com> Gerrit-Comment-Date: Wed, 30 Sep 2026 06:31:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in flashrom[main]: dmi: Decode SMBIOS 2.1 and 3.0 entry points
by Anastasia Klimchuk (Code Review) Sept. 29, 2026

Sept. 29, 2026

Attention is currently required from: Abdelkader Boudih. Anastasia Klimchuk has posted comments on this change by Abdelkader Boudih. ( https://review.coreboot.org/c/flashrom/+/95824?usp=email ) Change subject: dmi: Decode SMBIOS 2.1 and 3.0 entry points ...................................................................... Patch Set 1: Code-Review+2 (1 comment) File dmi.c: https://review.coreboot.org/c/flashrom/+/95824/comment/7701e2ec_f77c33b5?us… : PS1, Line 7: */ would you like to add your line here? in this commit, or in the last in the chain if you want -- To view, visit https://review.coreboot.org/c/flashrom/+/95824?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I2fb24e9a2bacad0eb3be6fdc25f4dadfca77f231 Gerrit-Change-Number: 95824 Gerrit-PatchSet: 1 Gerrit-Owner: Abdelkader Boudih <coreboot(a)seuros.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Abdelkader Boudih <coreboot(a)seuros.com> Gerrit-Comment-Date: Wed, 30 Sep 2026 06:31:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[S] Change in flashrom[main]: serial: Turn off inherited flow control on Windows
by Anastasia Klimchuk (Code Review) Sept. 29, 2026

Sept. 29, 2026

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/95748?usp=email ) ( 2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: serial: Turn off inherited flow control on Windows ...................................................................... serial: Turn off inherited flow control on Windows Windows opens a port with the settings from the last time it was opened, and serialport_config() only sets the baud rate and 8N1, so flashrom inherits the flow control left by the previous program. PuTTY, for example, enables XON/XOFF by default, and buspirate_spi can then hang. Turn off hardware and software flow control, as the termios code already does, and also abort on error and the options that drop or replace received bytes. Tested on Windows 11 with a Bus Pirate v3: after plink left XON/XOFF, RTS/CTS or DSR/DTR on, buspirate_spi hung without this change and read correctly with it. Change-Id: I170241698c4cb78ba84247f12f1ff7c32c743e3f Signed-off-by: David Reguera Garcia <regueragarciadavid(a)gmail.com> Reviewed-on: https://review.coreboot.org/c/flashrom/+/95748 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Abdelkader Boudih <coreboot(a)seuros.com> --- M serial.c 1 file changed, 14 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Abdelkader Boudih: Looks good to me, approved diff --git a/serial.c b/serial.c index 5e05b9e..797a8a2 100644 --- a/serial.c +++ b/serial.c @@ -166,6 +166,20 @@ dcb.ByteSize = 8; dcb.Parity = NOPARITY; dcb.StopBits = ONESTOPBIT; + dcb.fBinary = true; + dcb.fParity = false; + dcb.fOutxCtsFlow = false; + dcb.fOutxDsrFlow = false; + dcb.fDsrSensitivity = false; + dcb.fOutX = false; + dcb.fInX = false; + dcb.fErrorChar = false; + dcb.fNull = false; + dcb.fAbortOnError = false; + if (dcb.fDtrControl == DTR_CONTROL_HANDSHAKE) + dcb.fDtrControl = DTR_CONTROL_ENABLE; + if (dcb.fRtsControl == RTS_CONTROL_HANDSHAKE) + dcb.fRtsControl = RTS_CONTROL_ENABLE; if (!SetCommState(fd, &dcb)) { msg_perr_strerror("Could not change serial port configuration: "); return 1; -- To view, visit https://review.coreboot.org/c/flashrom/+/95748?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I170241698c4cb78ba84247f12f1ff7c32c743e3f Gerrit-Change-Number: 95748 Gerrit-PatchSet: 4 Gerrit-Owner: Dreg <regueragarciadavid(a)gmail.com> Gerrit-Reviewer: Abdelkader Boudih <coreboot(a)seuros.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Antonio Vázquez Blanco <antoniovazquezblanco(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[S] Change in flashrom[main]: linux_mtd: Treat unsupported lock ioctls as no WP support
by Anastasia Klimchuk (Code Review) Sept. 29, 2026

Sept. 29, 2026

Attention is currently required from: Abdelkader Boudih. Anastasia Klimchuk has posted comments on this change by Abdelkader Boudih. ( https://review.coreboot.org/c/flashrom/+/95827?usp=email ) Change subject: linux_mtd: Treat unsupported lock ioctls as no WP support ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/95827?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I7b9012cc69c93a8ffcc0f7f4ff0681df3b4374f7 Gerrit-Change-Number: 95827 Gerrit-PatchSet: 2 Gerrit-Owner: Abdelkader Boudih <coreboot(a)seuros.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Abdelkader Boudih <coreboot(a)seuros.com> Gerrit-Comment-Date: Tue, 29 Sep 2026 22:29:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0