August 2026 - flashrom-gerrit - mail.coreboot.org

[M] Change in flashrom[main]: serprog: Handle failures in parallel bus callbacks
by Stefan Reinauer (Code Review) Aug. 30, 2026

Aug. 30, 2026

Attention is currently required from: Anastasia Klimchuk. Stefan Reinauer has posted comments on this change by Stefan Reinauer. ( https://review.coreboot.org/c/flashrom/+/88809?usp=email ) Change subject: serprog: Handle failures in parallel bus callbacks ...................................................................... Patch Set 4: Addressed in patch set 4: the parallel-master writeb and readn callbacks return void, so they cannot propagate an error to their callers. They now log failures and return from the callback immediately instead of continuing on a broken stream. readb likewise has no out-of-band error result; it now uses 0xff only as a deterministic fallback and no longer claims it is a defined error code. Additional previously ignored helper failures are checked as well. The change is extracted from the old stack and rebased onto current main. -- To view, visit https://review.coreboot.org/c/flashrom/+/88809?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I7184521cbcf7db711452f20a2f1c802f72020e11 Gerrit-Change-Number: 88809 Gerrit-PatchSet: 4 Gerrit-Owner: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Mon, 31 Aug 2026 06:26:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[M] Change in flashrom[main]: serprog: Handle failures in parallel bus callbacks
by Stefan Reinauer (Code Review) Aug. 30, 2026

Aug. 30, 2026

Attention is currently required from: Anastasia Klimchuk, Stefan Reinauer. Hello Anastasia Klimchuk, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/88809?usp=email to look at the new patch set (#4). Change subject: serprog: Handle failures in parallel bus callbacks ...................................................................... serprog: Handle failures in parallel bus callbacks Check the return values of buffered writes, stream flushes, and read operations. Stop void callbacks after a failure so later commands do not continue on a broken stream. The parallel master interface cannot propagate errors from writeb or readn, and readb has no out-of-band error value. Log those failures and use 0xff only as a deterministic byte-read fallback, not as a defined error code. Signed-off-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Change-Id: I7184521cbcf7db711452f20a2f1c802f72020e11 --- M programmers/serprog.c 1 file changed, 50 insertions(+), 20 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/09/88809/4 -- To view, visit https://review.coreboot.org/c/flashrom/+/88809?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I7184521cbcf7db711452f20a2f1c802f72020e11 Gerrit-Change-Number: 88809 Gerrit-PatchSet: 4 Gerrit-Owner: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>

1 0

[M] Change in flashrom[main]: serprog: Handle failures in parallel bus callbacks
by Stefan Reinauer (Code Review) Aug. 30, 2026

Aug. 30, 2026

Attention is currently required from: Anastasia Klimchuk, Stefan Reinauer. Hello Anastasia Klimchuk, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/88809?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: serprog: Handle failures in parallel bus callbacks ...................................................................... serprog: Handle failures in parallel bus callbacks Check the return values of buffered writes, stream flushes, and read operations. Stop void callbacks after a failure so later commands do not continue on a broken stream. The parallel master interface cannot propagate errors from writeb or readn, and readb has no out-of-band error value. Log those failures and use 0xff only as a deterministic byte-read fallback, not as a defined error code. Signed-off-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Change-Id: I7184521cbcf7db711452f20a2f1c802f72020e11 --- M programmers/serprog.c 1 file changed, 50 insertions(+), 20 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/09/88809/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/88809?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I7184521cbcf7db711452f20a2f1c802f72020e11 Gerrit-Change-Number: 88809 Gerrit-PatchSet: 3 Gerrit-Owner: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>

1 0

[L] Change in flashrom[main]: rayer_spi: Drop the parallel-port bit-banging programmer
by Abdelkader Boudih (Code Review) Aug. 30, 2026

Aug. 30, 2026

Attention is currently required from: Abdelkader Boudih, Anastasia Klimchuk, Peter Marheine, Stefan Reinauer. Hello Anastasia Klimchuk, Peter Marheine, Stefan Reinauer, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/93706?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: rayer_spi: Drop the parallel-port bit-banging programmer ...................................................................... rayer_spi: Drop the parallel-port bit-banging programmer Remove the rayer_spi driver, which bit-bangs SPI over a PC parallel port (RayeR cable, ByteBlasterMV, STK200/300, Wiggler, Xilinx DLC 5, SPI Tiny Tools). Parallel ports are absent from modern hardware, and the driver depends on raw x86 I/O port access, limiting it to legacy x86 hosts. The hardware it targets only works on legacy machines, and those already ship a legacy flashrom alongside their toolchain, so dropping the driver from current flashrom strands no one: users still on parallel-port hosts keep using the version that came with that platform. Change-Id: I70ae9d05273ce4cf94d98ecabe7b9dadb84ef82e Signed-off-by: Abdelkader Boudih <coreboot(a)seuros.com> --- M doc/classic_cli_manpage.rst M doc/release_notes/devel.rst M include/programmer.h M meson.build M meson_options.txt M programmer_table.c D programmers/rayer_spi.c M test_build.sh 8 files changed, 10 insertions(+), 384 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/06/93706/4 -- To view, visit https://review.coreboot.org/c/flashrom/+/93706?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I70ae9d05273ce4cf94d98ecabe7b9dadb84ef82e Gerrit-Change-Number: 93706 Gerrit-PatchSet: 4 Gerrit-Owner: Abdelkader Boudih <coreboot(a)seuros.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Attention: Abdelkader Boudih <coreboot(a)seuros.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>

1 0

[M] Change in flashrom[main]: atapromise: Drop the Promise PDC2026x ATA/RAID programmer
by Abdelkader Boudih (Code Review) Aug. 30, 2026

Aug. 30, 2026

Attention is currently required from: Anastasia Klimchuk, Peter Marheine. Hello Anastasia Klimchuk, Peter Marheine, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/94447?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: atapromise: Drop the Promise PDC2026x ATA/RAID programmer ...................................................................... atapromise: Drop the Promise PDC2026x ATA/RAID programmer Removed the atapromise driver for Promise PDC2026x ATA/RAID PCI cards. It reflashed the card option ROM through raw x86 port I/O, hardware absent from current systems; the machines that still carry such a card already ship a legacy flashrom. Change-Id: Ifde71234620b56a9964bfb797f56e6b9c2b92705 Signed-off-by: Abdelkader Boudih <coreboot(a)seuros.com> --- M doc/classic_cli_manpage.rst M doc/release_notes/devel.rst M include/programmer.h M meson.build M meson_options.txt D programmers/atapromise.c M test_build.sh 7 files changed, 11 insertions(+), 197 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/47/94447/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/94447?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ifde71234620b56a9964bfb797f56e6b9c2b92705 Gerrit-Change-Number: 94447 Gerrit-PatchSet: 2 Gerrit-Owner: Abdelkader Boudih <coreboot(a)seuros.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[M] Change in flashrom[main]: gfxnvidia: Drop the NVIDIA graphics-card flash programmer
by Abdelkader Boudih (Code Review) Aug. 30, 2026

Aug. 30, 2026

Attention is currently required from: Anastasia Klimchuk, Peter Marheine. Hello Anastasia Klimchuk, Peter Marheine, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/94449?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: gfxnvidia: Drop the NVIDIA graphics-card flash programmer ...................................................................... gfxnvidia: Drop the NVIDIA graphics-card flash programmer Removed the gfxnvidia driver for old NVIDIA graphics cards. It reflashed the card's memory-mapped parallel flash, hardware absent from current systems; machines old enough to host such a card already ship a legacy flashrom. Change-Id: I47a622657e76b558954e7e2b40a6622c261a8f4e Signed-off-by: Abdelkader Boudih <coreboot(a)seuros.com> --- M doc/classic_cli_manpage.rst M doc/release_notes/devel.rst M include/programmer.h M meson.build M meson_options.txt D programmers/gfxnvidia.c M test_build.sh 7 files changed, 11 insertions(+), 147 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/49/94449/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/94449?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I47a622657e76b558954e7e2b40a6622c261a8f4e Gerrit-Change-Number: 94449 Gerrit-PatchSet: 2 Gerrit-Owner: Abdelkader Boudih <coreboot(a)seuros.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[M] Change in flashrom[main]: satasii: Drop the Silicon Image SATA/IDE flash programmer
by Abdelkader Boudih (Code Review) Aug. 30, 2026

Aug. 30, 2026

Attention is currently required from: Anastasia Klimchuk, Peter Marheine. Hello Anastasia Klimchuk, Peter Marheine, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/94450?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: satasii: Drop the Silicon Image SATA/IDE flash programmer ...................................................................... satasii: Drop the Silicon Image SATA/IDE flash programmer Removed the satasii driver for Silicon Image SATA/IDE PCI controllers. It reflashed the card's memory-mapped parallel flash, hardware absent from current systems; legacy hosts already ship a flashrom that supports it. Change-Id: Id78573709db3483f6d935d3f9f0f0d2034b03ea5 Signed-off-by: Abdelkader Boudih <coreboot(a)seuros.com> --- M doc/classic_cli_manpage.rst M doc/release_notes/devel.rst M include/programmer.h M meson.build M meson_options.txt D programmers/satasii.c M test_build.sh 7 files changed, 11 insertions(+), 164 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/50/94450/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/94450?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Id78573709db3483f6d935d3f9f0f0d2034b03ea5 Gerrit-Change-Number: 94450 Gerrit-PatchSet: 2 Gerrit-Owner: Abdelkader Boudih <coreboot(a)seuros.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[M] Change in flashrom[main]: nicnatsemi: Drop the National Semiconductor NIC programmer
by Abdelkader Boudih (Code Review) Aug. 30, 2026

Aug. 30, 2026

Attention is currently required from: Anastasia Klimchuk, Peter Marheine. Hello Anastasia Klimchuk, Peter Marheine, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/94452?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: nicnatsemi: Drop the National Semiconductor NIC programmer ...................................................................... nicnatsemi: Drop the National Semiconductor NIC programmer Removed the nicnatsemi driver for National Semiconductor DP838* PCI network cards. It reflashed the card's socketed parallel boot ROM through raw x86 port I/O, hardware absent from current systems; legacy hosts already ship a legacy flashrom. Change-Id: I22d1c4924f443a78fa0b7ba0702f0128fda33703 Signed-off-by: Abdelkader Boudih <coreboot(a)seuros.com> --- M doc/classic_cli_manpage.rst M doc/release_notes/devel.rst M include/programmer.h M meson.build M meson_options.txt D programmers/nicnatsemi.c M test_build.sh 7 files changed, 11 insertions(+), 133 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/52/94452/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/94452?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I22d1c4924f443a78fa0b7ba0702f0128fda33703 Gerrit-Change-Number: 94452 Gerrit-PatchSet: 2 Gerrit-Owner: Abdelkader Boudih <coreboot(a)seuros.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[M] Change in flashrom[main]: drkaiser: Drop the Dr. Kaiser PC-Waechter flash programmer
by Abdelkader Boudih (Code Review) Aug. 30, 2026

Aug. 30, 2026

Attention is currently required from: Anastasia Klimchuk, Peter Marheine. Hello Anastasia Klimchuk, Peter Marheine, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/94453?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: drkaiser: Drop the Dr. Kaiser PC-Waechter flash programmer ...................................................................... drkaiser: Drop the Dr. Kaiser PC-Waechter flash programmer Removed the drkaiser driver for Dr. Kaiser PC-Waechter PCI cards. It reflashed the card's memory-mapped parallel flash, hardware absent from current systems; legacy hosts already ship a flashrom that supports it. Change-Id: I74d9c1ef9e39a77b9e1a8f6247e25fa70bf9f2f0 Signed-off-by: Abdelkader Boudih <coreboot(a)seuros.com> --- M doc/classic_cli_manpage.rst M doc/release_notes/devel.rst M include/programmer.h M meson.build M meson_options.txt D programmers/drkaiser.c M test_build.sh 7 files changed, 11 insertions(+), 126 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/53/94453/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/94453?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I74d9c1ef9e39a77b9e1a8f6247e25fa70bf9f2f0 Gerrit-Change-Number: 94453 Gerrit-PatchSet: 2 Gerrit-Owner: Abdelkader Boudih <coreboot(a)seuros.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[M] Change in flashrom[main]: satamv: Drop the Marvell SATA flash programmer
by Abdelkader Boudih (Code Review) Aug. 30, 2026

Aug. 30, 2026

Attention is currently required from: Anastasia Klimchuk, Peter Marheine. Hello Anastasia Klimchuk, Peter Marheine, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/94454?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: satamv: Drop the Marvell SATA flash programmer ...................................................................... satamv: Drop the Marvell SATA flash programmer Removed the satamv driver for Marvell SATA PCI controllers. It reflashed the card's parallel flash through raw x86 port I/O, hardware absent from current systems; legacy hosts already ship a flashrom that supports it. Change-Id: I552bc50a16cd287dadd89fe2dac222f9125c7421 Signed-off-by: Abdelkader Boudih <coreboot(a)seuros.com> --- M doc/classic_cli_manpage.rst M doc/release_notes/devel.rst M include/programmer.h M meson.build M meson_options.txt D programmers/satamv.c M test_build.sh 7 files changed, 10 insertions(+), 221 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/54/94454/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/94454?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I552bc50a16cd287dadd89fe2dac222f9125c7421 Gerrit-Change-Number: 94454 Gerrit-PatchSet: 2 Gerrit-Owner: Abdelkader Boudih <coreboot(a)seuros.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>

1 0