June 2026 - flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: print.c: Fix alignment in print_supported_boards_helper()
by David Hendricks (Code Review) July 2, 2026

July 2, 2026

David Hendricks has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/37407 ) Change subject: print.c: Fix alignment in print_supported_boards_helper() ...................................................................... print.c: Fix alignment in print_supported_boards_helper() Commit 61e16e5 eliminated some duplicate logic for printing test status, but in doing so introduced a regression where some entries in `flashrom -L` output became unaligned. Up until then, it was assumed that the status field will always be 8-wide, including space for padding. This patch fixes alignment when using test_state_to_text() by making the padding consistent with other fields where a for-loop is used to pad the field up to a maximum width. Change-Id: Ie0a0b45c6466d14447aca443c2697e2048c6ef14 Signed-off-by: David Hendricks <david.hendricks(a)gmail.com> --- M flash.h M print.c 2 files changed, 29 insertions(+), 14 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/07/37407/1 diff --git a/flash.h b/flash.h index 1a9bd9f..e7b1c89 100644 --- a/flash.h +++ b/flash.h @@ -145,10 +145,11 @@ enum test_state { OK = 0, - NT = 1, /* Not tested */ - BAD, /* Known to not work */ - DEP, /* Support depends on configuration (e.g. Intel flash descriptor) */ - NA, /* Not applicable (e.g. write support on ROM chips) */ + NT = 1, /* Not tested */ + BAD, /* Known to not work */ + DEP, /* Support depends on configuration (e.g. Intel flash descriptor) */ + NA, /* Not applicable (e.g. write support on ROM chips) */ + TEST_STATE_END, /* Not a test state, just an indicator of how many are defined. */ }; #define TEST_UNTESTED (struct tested){ .probe = NT, .read = NT, .erase = NT, .write = NT } diff --git a/print.c b/print.c index 6a7ff5d..e5be6b6 100644 --- a/print.c +++ b/print.c @@ -35,6 +35,20 @@ } } +static size_t max_test_state_len(void) +{ + int i; + size_t max_len; + + for (i = max_len = 0; i < TEST_STATE_END; i++) { + size_t len = strlen(test_state_to_text(i)); + if (len > max_len) + max_len = len; + } + + return max_len; +} + static int print_supported_chips(void) { const char *delim = "/"; @@ -388,8 +402,12 @@ for (i = strlen("Board"); i < maxboardlen; i++) msg_ginfo(" "); - msg_ginfo("Status Required value for\n"); - for (i = 0; i < maxvendorlen + maxboardlen + strlen("Status "); i++) + msg_ginfo("Status"); + for (i = strlen("Status"); i < max_test_state_len(); i++) + msg_ginfo(" "); + + msg_ginfo("Required value for\n"); + for (i = 0; i < maxvendorlen + maxboardlen + max_test_state_len(); i++) msg_ginfo(" "); msg_ginfo("-p internal:mainboard=\n"); @@ -401,14 +419,10 @@ for (i = 0; i < maxboardlen - strlen(b->name); i++) msg_ginfo(" "); - switch (b->working) { - case OK: msg_ginfo("OK "); break; - case NT: msg_ginfo("NT "); break; - case DEP: msg_ginfo("DEP "); break; - case NA: msg_ginfo("N/A "); break; - case BAD: - default: msg_ginfo("BAD "); break; - } + const char *test_state = test_state_to_text(b->working); + msg_ginfo("%s", test_state); + for (i = 0; i < max_test_state_len() - strlen(test_state); i++) + msg_ginfo(" "); for (e = board_matches; e->vendor_name != NULL; e++) { if (strcmp(e->vendor_name, b->vendor) -- To view, visit https://review.coreboot.org/c/flashrom/+/37407 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ie0a0b45c6466d14447aca443c2697e2048c6ef14 Gerrit-Change-Number: 37407 Gerrit-PatchSet: 1 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-MessageType: newchange

5 8

[M] Change in flashrom[main]: flashchips: Add Fudan FM25W128
by Sean Rhodes (Code Review) July 1, 2026

July 1, 2026

Sean Rhodes has uploaded a new patch set (#2). ( https://review.coreboot.org/c/flashrom/+/93823?usp=email ) Change subject: flashchips: Add Fudan FM25W128 ...................................................................... flashchips: Add Fudan FM25W128 The Fudan FM25W128 reports JEDEC ID A1h 2818h and is used on StarLite ADL boards in the lab. Without a concrete chip entry flashrom falls back to an opaque/SFDP chip, which means write-protect status is not available. Add the datasheet geometry and a dedicated write-protect range decoder. The FM25W128 BP table starts at BP=011 for 1/16 protection, so it does not match the generic SPI25 decoder. Tested: - meson compile -C build - meson test -C build 'cmocka test flashrom' --print-errorlogs - StarLite ADL .41 and .115: patched flashrom identifies FM25W128 and reports write-protect status disabled/none Change-Id: If0007ab7eae1d5e1e2cf0245a146e2d493935733 Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> --- M flashchips/fudan.c M include/chipdrivers.h M include/flash.h M include/flashchips.h M tests/chip_wp.c M tests/tests.c M tests/tests.h M writeprotect.c M writeprotect_ranges.c 9 files changed, 163 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/23/93823/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/93823?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: If0007ab7eae1d5e1e2cf0245a146e2d493935733 Gerrit-Change-Number: 93823 Gerrit-PatchSet: 2 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems>

1 0

[L] Change in flashrom[main]: rayer_spi: Drop the parallel-port bit-banging programmer
by Abdelkader Boudih (Code Review) June 30, 2026

June 30, 2026

Attention is currently required from: Peter Marheine. Abdelkader Boudih has posted comments on this change by Abdelkader Boudih. ( https://review.coreboot.org/c/flashrom/+/93706?usp=email ) Change subject: rayer_spi: Drop the parallel-port bit-banging programmer ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > I think the patch is all good, but I would like to post on the flashrom mailing list about it. […] Please go ahead, you have got a better way to explain the intent. please keep the scope open though, so we can evict other programmers too if they end up in the same situation. My workflow is fairly simple: * Pick a programmer from the list. * Research it. * Check whether it’s still used, and by whom. * If it is dead weight, or only serves an extremely niche audience (like DeveloperBox), I propose removing it. Before I started contributing to flashrom, and before the test suite improvements, I had a few local patches (for example, the SHA-256 support CB:91489) that I never submitted. At the time I looked at the long list of obscure programmers and thought, "What’s the point of adding a global feature if I will have to spend months convincing every programmer maintainer to add it?" I turned out to be wrong about how flashrom development actually works, but first impressions matter. I wouldnt be surprised if future possible contributors did have the same assumption especially when they search for a programmer in the list and find zero results showing that anyone is still using it. -- To view, visit https://review.coreboot.org/c/flashrom/+/93706?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I70ae9d05273ce4cf94d98ecabe7b9dadb84ef82e Gerrit-Change-Number: 93706 Gerrit-PatchSet: 2 Gerrit-Owner: Abdelkader Boudih <coreboot(a)seuros.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Tue, 30 Jun 2026 08:55:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[L] Change in flashrom[main]: rayer_spi: Drop the parallel-port bit-banging programmer
by Anastasia Klimchuk (Code Review) June 30, 2026

June 30, 2026

Attention is currently required from: Abdelkader Boudih, Peter Marheine. Anastasia Klimchuk has posted comments on this change by Abdelkader Boudih. ( https://review.coreboot.org/c/flashrom/+/93706?usp=email ) Change subject: rayer_spi: Drop the parallel-port bit-banging programmer ...................................................................... Patch Set 2: Code-Review+2 (1 comment) Patchset: PS2: I think the patch is all good, but I would like to post on the flashrom mailing list about it. Something goes away after all. I remember about developerbox, it can be one post about both, if you would like to chain second commit on top of this one? The post can explain the reasons why programmers are dropped, and also give links to both patches. All this will hang out for a little bit, and after that both patches can be submitted (not before the post, but after). This way involves some waiting, but we inform everyone and have a peace of mind. Would you like to write the post, or would you prefer me to write? I always ask the person who did the work, to write the post (so everyone knows who is the hero). Unless they don't want then I can do it. -- To view, visit https://review.coreboot.org/c/flashrom/+/93706?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I70ae9d05273ce4cf94d98ecabe7b9dadb84ef82e Gerrit-Change-Number: 93706 Gerrit-PatchSet: 2 Gerrit-Owner: Abdelkader Boudih <coreboot(a)seuros.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Abdelkader Boudih <coreboot(a)seuros.com> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Tue, 30 Jun 2026 07:15:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[S] Change in flashrom[main]: Add support for ST M95320 EEPROM memories
by Anastasia Klimchuk (Code Review) June 30, 2026

June 30, 2026

Attention is currently required from: Antonio Vázquez Blanco, Nikolai Artemiev, Stefan Reinauer. Anastasia Klimchuk has posted comments on this change by Antonio Vázquez Blanco. ( https://review.coreboot.org/c/flashrom/+/93666?usp=email ) Change subject: Add support for ST M95320 EEPROM memories ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: One last thing to do would be to add the info in `doc/release_notes/devel.rst` You are adding support for a new chip, but also a new feature flag for 2-byte address, it's all worth mentioning. It is important to explain the new model has no means to probing and only can be detected by `--force`. Otherwise, when you probing everything (I just tried), the message is "Probing for ST M95320, 4 kB: failed! flashrom has no probe function for this flash chip." (can be confusing) So if you could add a section in the doc it would be great! explain the feature in your own words. There is another patch to be submitted soon which updates the same doc CB:91839 , so if you want you can wait a bit, like 2 days, and then rebase and update the doc. thank you! I am glad to know that FEATURE_NO_ERASE still works :) -- To view, visit https://review.coreboot.org/c/flashrom/+/93666?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I0d3a479c3c381e4a826e740e02bece748ea1a0f1 Gerrit-Change-Number: 93666 Gerrit-PatchSet: 2 Gerrit-Owner: Antonio Vázquez Blanco <antoniovazquezblanco(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Antonio Vázquez Blanco <antoniovazquezblanco(a)gmail.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Tue, 30 Jun 2026 06:30:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in flashrom[main]: platform/i2c: Add CONFIG_I2C_HELPER to gate i2c helper code
by Anastasia Klimchuk (Code Review) June 30, 2026

June 30, 2026

Attention is currently required from: Abdelkader Boudih, Peter Marheine. Anastasia Klimchuk has posted comments on this change by Abdelkader Boudih. ( https://review.coreboot.org/c/flashrom/+/93783?usp=email ) Change subject: platform/i2c: Add CONFIG_I2C_HELPER to gate i2c helper code ...................................................................... Patch Set 1: (1 comment) File platform/meson.build: https://review.coreboot.org/c/flashrom/+/93783/comment/5c79b839_5eec81f5?us… : PS1, Line 13: compile_args : [ '-DCONFIG_I2C_HELPER=1' ], It might be the same end result (or not), but I see above and below this file is using `add_project_arguments`. And in root meson.build as well. Lets use `add_project_arguments` here too? -- To view, visit https://review.coreboot.org/c/flashrom/+/93783?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ie4dc0c8465224f4b0fed7d0d026e056a4835c782 Gerrit-Change-Number: 93783 Gerrit-PatchSet: 1 Gerrit-Owner: Abdelkader Boudih <coreboot(a)seuros.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Abdelkader Boudih <coreboot(a)seuros.com> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Tue, 30 Jun 2026 02:46:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in flashrom[main]: Add support for ST M95320 EEPROM memories
by Antonio Vázquez Blanco (Code Review) June 29, 2026

June 29, 2026

Attention is currently required from: Anastasia Klimchuk, Nikolai Artemiev, Stefan Reinauer. Antonio Vázquez Blanco has posted comments on this change by Antonio Vázquez Blanco. ( https://review.coreboot.org/c/flashrom/+/93666?usp=email ) Change subject: Add support for ST M95320 EEPROM memories ...................................................................... Patch Set 1: (2 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/93666/comment/b4eca9e8_6521c8d9?us… : PS1, Line 8: > Would it be possible to add a link to datasheet in commit message? Done! File flashchips/st.c: https://review.coreboot.org/c/flashrom/+/93666/comment/59d873af_132ee1bc?us… : PS1, Line 553: .model_id = ST_M95320, > I would rather inline the zero-ID here, so that it is very clear that there is none. […] Done! :) -- To view, visit https://review.coreboot.org/c/flashrom/+/93666?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I0d3a479c3c381e4a826e740e02bece748ea1a0f1 Gerrit-Change-Number: 93666 Gerrit-PatchSet: 1 Gerrit-Owner: Antonio Vázquez Blanco <antoniovazquezblanco(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Mon, 29 Jun 2026 21:36:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[S] Change in flashrom[main]: Add support for ST M95320 EEPROM memories
by Antonio Vázquez Blanco (Code Review) June 29, 2026

June 29, 2026

Attention is currently required from: Antonio Vázquez Blanco, Nikolai Artemiev, Stefan Reinauer. Hello Anastasia Klimchuk, Nikolai Artemiev, Stefan Reinauer, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/93666?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: Add support for ST M95320 EEPROM memories ...................................................................... Add support for ST M95320 EEPROM memories https://www.st.com/resource/en/datasheet/m95320-w.pdf Change-Id: I0d3a479c3c381e4a826e740e02bece748ea1a0f1 Signed-off-by: Antonio Vázquez Blanco <antoniovazquezblanco(a)gmail.com> --- M flashchips/st.c M include/flash.h M spi25.c 3 files changed, 44 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/66/93666/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/93666?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I0d3a479c3c381e4a826e740e02bece748ea1a0f1 Gerrit-Change-Number: 93666 Gerrit-PatchSet: 2 Gerrit-Owner: Antonio Vázquez Blanco <antoniovazquezblanco(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Antonio Vázquez Blanco <antoniovazquezblanco(a)gmail.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com>

1 0

[M] Change in flashrom[main]: print: Factor out wrapped multiline name token printing
by Anastasia Klimchuk (Code Review) June 29, 2026

June 29, 2026

Attention is currently required from: Abdelkader Boudih, Nicholas. Anastasia Klimchuk has posted comments on this change by Abdelkader Boudih. ( https://review.coreboot.org/c/flashrom/+/93600?usp=email ) Change subject: print: Factor out wrapped multiline name token printing ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/93600?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ie8ef9e75fb77e10df8d3bd7d0be5139f31729581 Gerrit-Change-Number: 93600 Gerrit-PatchSet: 1 Gerrit-Owner: Abdelkader Boudih <coreboot(a)seuros.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nicholas <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Abdelkader Boudih <coreboot(a)seuros.com> Gerrit-Attention: Nicholas <nic.c3.14(a)gmail.com> Gerrit-Comment-Date: Mon, 29 Jun 2026 12:36:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in flashrom[main]: par_mmio: Add shared MMIO accessors for parallel PCI drivers
by Abdelkader Boudih (Code Review) June 29, 2026

June 29, 2026

Attention is currently required from: Anastasia Klimchuk, Peter Marheine. Abdelkader Boudih has posted comments on this change by Abdelkader Boudih. ( https://review.coreboot.org/c/flashrom/+/93786?usp=email ) Change subject: par_mmio: Add shared MMIO accessors for parallel PCI drivers ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: This refactoring is purely mechanical, the accessor logic is byte-identical, verified with -Dprogrammer=all plus the unit tests. it target last-century hardware. I kept the shared mixin thin and self-contained so these drivers stay easy to remove later, if the par_master path ever becomes a maintenance blocker or just ages out. And we will have to rip it out before 2030 anyway. -- To view, visit https://review.coreboot.org/c/flashrom/+/93786?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I660cc2e82450da605ab4242389bcf6c3f94da6cc Gerrit-Change-Number: 93786 Gerrit-PatchSet: 1 Gerrit-Owner: Abdelkader Boudih <coreboot(a)seuros.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Mon, 29 Jun 2026 12:33:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0