July 2019 - flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: Fix -Wunused-parameter issues
by Jacob Garber (Code Review) July 30, 2019

July 30, 2019

Jacob Garber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/30410 ) Change subject: Fix -Wunused-parameter issues ...................................................................... Patch Set 5: Code-Review+1 I'll let this sit for a little longer in case someone else wants to chime in, then +2. -- To view, visit https://review.coreboot.org/c/flashrom/+/30410 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: If831398c91e9f49bd5216a03ed4caaa2a7ab02bd Gerrit-Change-Number: 30410 Gerrit-PatchSet: 5 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Jacob Garber <jgarber1(a)ualberta.ca> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Tue, 30 Jul 2019 18:09:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Fix -Wunused-parameter issues
by Nico Huber (Code Review) July 30, 2019

July 30, 2019

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/30410 ) Change subject: Fix -Wunused-parameter issues ...................................................................... Patch Set 5: > > Are there any of these parameters that could be deleted, or were they all needed? > > I removed unused parameters from static functions. Didn't check the APIs, though. Much of the noise seems to be due to the usage of global variables, btw. Can't say how often I wrote `(void)flash;`, where `flash` is a reference to the context that was unused and something global instead. Sooner or later, those should be cleaned up anyway. If we take libflashrom serious. -- To view, visit https://review.coreboot.org/c/flashrom/+/30410 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: If831398c91e9f49bd5216a03ed4caaa2a7ab02bd Gerrit-Change-Number: 30410 Gerrit-PatchSet: 5 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Jacob Garber <jgarber1(a)ualberta.ca> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Tue, 30 Jul 2019 17:32:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Fix -Wunused-parameter issues
by Nico Huber (Code Review) July 30, 2019

July 30, 2019

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/30410 ) Change subject: Fix -Wunused-parameter issues ...................................................................... Patch Set 5: > Are there any of these parameters that could be deleted, or were they all needed? I removed unused parameters from static functions. Didn't check the APIs, though. -- To view, visit https://review.coreboot.org/c/flashrom/+/30410 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: If831398c91e9f49bd5216a03ed4caaa2a7ab02bd Gerrit-Change-Number: 30410 Gerrit-PatchSet: 5 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Jacob Garber <jgarber1(a)ualberta.ca> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Tue, 30 Jul 2019 17:25:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Fix -Wunused-parameter issues
by Jacob Garber (Code Review) July 30, 2019

July 30, 2019

Jacob Garber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/30410 ) Change subject: Fix -Wunused-parameter issues ...................................................................... Patch Set 5: Are there any of these parameters that could be deleted, or were they all needed? -- To view, visit https://review.coreboot.org/c/flashrom/+/30410 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: If831398c91e9f49bd5216a03ed4caaa2a7ab02bd Gerrit-Change-Number: 30410 Gerrit-PatchSet: 5 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Jacob Garber <jgarber1(a)ualberta.ca> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Tue, 30 Jul 2019 17:17:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Fix -Wsign-compare trouble
by Jacob Garber (Code Review) July 30, 2019

July 30, 2019

Jacob Garber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/30409 ) Change subject: Fix -Wsign-compare trouble ...................................................................... Patch Set 5: Code-Review+2 (5 comments) https://review.coreboot.org/c/flashrom/+/30409/5/cbtable.c File cbtable.c: https://review.coreboot.org/c/flashrom/+/30409/5/cbtable.c@43 PS5, Line 43: image + size - 0x10 > Yes, it does. So what is the problem? […] Yes, sorry, there is no problem, I was just double-checking that that was how it was parsed (since the other way can cause problems). https://review.coreboot.org/c/flashrom/+/30409/5/cbtable.c@51 PS5, Line 51: image + size - 0x80 > Ditto Done https://review.coreboot.org/c/flashrom/+/30409/5/cbtable.c@69 PS5, Line 69: image + size - mb_part_offset > Ditto Done https://review.coreboot.org/c/flashrom/+/30409/5/cbtable.c@70 PS5, Line 70: image + size - mb_vendor_offset > Ditto Done https://review.coreboot.org/c/flashrom/+/30409/5/fmap.c File fmap.c: https://review.coreboot.org/c/flashrom/+/30409/5/fmap.c@99 PS5, Line 99: (len - sizeof(struct fmap)) > Sure, but not part of this patch (the problem is in the subtraction not the […] Gah! C is crazy. We only use off_t since this function needs to return negative error values (mumble mumble grumble), so we could just use size_t for `offset`, add an if check before the loop, and then do a cast to off_t at the very end when we return. Either that, or leave it as-is for now and change it in a follow-up. (Also, now that I think about it the signed version of size_t is ssize_t, not off_t, so perhaps a follow-up is better.) -- To view, visit https://review.coreboot.org/c/flashrom/+/30409 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I08895543ffb7a48058bcf91ef6500ca113f2d305 Gerrit-Change-Number: 30409 Gerrit-PatchSet: 5 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Jacob Garber <jgarber1(a)ualberta.ca> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Tue, 30 Jul 2019 17:16:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Jacob Garber <jgarber1(a)ualberta.ca> Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Fix -Wsign-compare trouble
by Nico Huber (Code Review) July 30, 2019

July 30, 2019

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/30409 ) Change subject: Fix -Wsign-compare trouble ...................................................................... Patch Set 5: (2 comments) https://review.coreboot.org/c/flashrom/+/30409/5/cbtable.c File cbtable.c: https://review.coreboot.org/c/flashrom/+/30409/5/cbtable.c@43 PS5, Line 43: image + size - 0x10 > I think this parses as (image + size) - 0x10, right? Yes, it does. So what is the problem? image + (size - 0x10) might produce an integer overflow (so it would matter that we changed the type to unsigned). But (image + size) - 0x10 does not (unless `size` isn't the real size of `image`, or `size < 0x10`, but these potential issues existed before). So it seems regression free to me. https://review.coreboot.org/c/flashrom/+/30409/5/fmap.c File fmap.c: https://review.coreboot.org/c/flashrom/+/30409/5/fmap.c@99 PS5, Line 99: (len - sizeof(struct fmap)) > If len < sizeof(struct fmap), we could just do an early return -2, so there's no problem of overflow […] Sure, but not part of this patch (the problem is in the subtraction not the comparison). I tried to reason further about how to make the subtraction safe without an explicit `if` (i.e. by ensuring that we'd have a negative number on the right side). C rules can be very scary here: Even with offset <= (off_t)len - sizeof(struct fmap) We'd risk to compare unsigned numbers, AFAICT: First, the - would be evaluated, if both types (signed `off_t` and unsigned `size_t` of the sizeof()) have the same rank, `len` would be converted back to `size_t`, overflow and we'd compare `0 <=` to a large number. With the assumption that the rank of `off_t` is greater-equal to the rank of `size_t`, this would work: offset <= (off_t)((off_t)len - sizeof(struct fmap)) The inner cast to handle `off_t` having the higher rank and the outer for the case that they have equal ranks. Obviously, an explicit `if` would be better ;) Oh and in case of equal ranks and overflow, the cast to `off_t` is implemen- tation defined ^^ fun. -- To view, visit https://review.coreboot.org/c/flashrom/+/30409 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I08895543ffb7a48058bcf91ef6500ca113f2d305 Gerrit-Change-Number: 30409 Gerrit-PatchSet: 5 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Jacob Garber <jgarber1(a)ualberta.ca> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Tue, 30 Jul 2019 11:42:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Jacob Garber <jgarber1(a)ualberta.ca> Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Add support for National Instruments USB-845x devices
by Miklós Márton (Code Review) July 29, 2019

July 29, 2019

Miklós Márton has uploaded a new patch set (#21) to the change originally created by David Hendricks. ( https://review.coreboot.org/c/flashrom/+/25683 ) Change subject: Add support for National Instruments USB-845x devices ...................................................................... Add support for National Instruments USB-845x devices Change-Id: I9477b6f0193bfdf20bbe63421a7fb97b597ec549 Signed-off-by: Miklós Márton <martonmiklosqdev(a)gmail.com> --- M Makefile M flashrom.8.tmpl M flashrom.c A ni845x_spi.c M programmer.h 5 files changed, 646 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/83/25683/21 -- To view, visit https://review.coreboot.org/c/flashrom/+/25683 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I9477b6f0193bfdf20bbe63421a7fb97b597ec549 Gerrit-Change-Number: 25683 Gerrit-PatchSet: 21 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Márton Miklós <martonmiklosqdev(a)gmail.com> Gerrit-CC: Stefan T <stefan.tauner(a)gmx.at> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: Fix -Wsign-compare trouble
by Jacob Garber (Code Review) July 29, 2019

July 29, 2019

Jacob Garber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/30409 ) Change subject: Fix -Wsign-compare trouble ...................................................................... Patch Set 5: (5 comments) https://review.coreboot.org/c/flashrom/+/30409/5/cbtable.c File cbtable.c: https://review.coreboot.org/c/flashrom/+/30409/5/cbtable.c@43 PS5, Line 43: image + size - 0x10 I think this parses as (image + size) - 0x10, right? https://review.coreboot.org/c/flashrom/+/30409/5/cbtable.c@51 PS5, Line 51: image + size - 0x80 Ditto https://review.coreboot.org/c/flashrom/+/30409/5/cbtable.c@69 PS5, Line 69: image + size - mb_part_offset Ditto https://review.coreboot.org/c/flashrom/+/30409/5/cbtable.c@70 PS5, Line 70: image + size - mb_vendor_offset Ditto https://review.coreboot.org/c/flashrom/+/30409/5/fmap.c File fmap.c: https://review.coreboot.org/c/flashrom/+/30409/5/fmap.c@99 PS5, Line 99: (len - sizeof(struct fmap)) > Not sure anymore why I placed the parentheses. It looks like it would be […] If len < sizeof(struct fmap), we could just do an early return -2, so there's no problem of overflow then. -- To view, visit https://review.coreboot.org/c/flashrom/+/30409 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I08895543ffb7a48058bcf91ef6500ca113f2d305 Gerrit-Change-Number: 30409 Gerrit-PatchSet: 5 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Jacob Garber <jgarber1(a)ualberta.ca> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Mon, 29 Jul 2019 19:55:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Add support for National Instruments USB-845x devices
by Miklós Márton (Code Review) July 29, 2019

July 29, 2019

Miklós Márton has uploaded a new patch set (#20) to the change originally created by David Hendricks. ( https://review.coreboot.org/c/flashrom/+/25683 ) Change subject: Add support for National Instruments USB-845x devices ...................................................................... Add support for National Instruments USB-845x devices Change-Id: I9477b6f0193bfdf20bbe63421a7fb97b597ec549 Signed-off-by: Miklós Márton <martonmiklosqdev(a)gmail.com> --- M Makefile M flashrom.8.tmpl M flashrom.c A ni845x_spi.c M programmer.h 5 files changed, 649 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/83/25683/20 -- To view, visit https://review.coreboot.org/c/flashrom/+/25683 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I9477b6f0193bfdf20bbe63421a7fb97b597ec549 Gerrit-Change-Number: 25683 Gerrit-PatchSet: 20 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Márton Miklós <martonmiklosqdev(a)gmail.com> Gerrit-CC: Stefan T <stefan.tauner(a)gmx.at> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: Fix -Wsign-compare trouble
by Nico Huber (Code Review) July 27, 2019

July 27, 2019

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/30409 ) Change subject: Fix -Wsign-compare trouble ...................................................................... Patch Set 5: (1 comment) https://review.coreboot.org/c/flashrom/+/30409/5/fmap.c File fmap.c: https://review.coreboot.org/c/flashrom/+/30409/5/fmap.c@99 PS5, Line 99: (len - sizeof(struct fmap)) Not sure anymore why I placed the parentheses. It looks like it would be safer without? i.e. do the calculation as signed, so the overflow wouldn't be a problem? -- To view, visit https://review.coreboot.org/c/flashrom/+/30409 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I08895543ffb7a48058bcf91ef6500ca113f2d305 Gerrit-Change-Number: 30409 Gerrit-PatchSet: 5 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Jacob Garber <jgarber1(a)ualberta.ca> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Sat, 27 Jul 2019 23:25:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Fix -Wsign-compare trouble
by Nico Huber (Code Review) July 27, 2019

July 27, 2019

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/30409 ) Change subject: Fix -Wsign-compare trouble ...................................................................... Patch Set 5: (4 comments) https://review.coreboot.org/c/flashrom/+/30409/4/at45db.c File at45db.c: https://review.coreboot.org/c/flashrom/+/30409/4/at45db.c@466 PS4, Line 466: flash->mst->spi.max_data_write - 4 > Could this subtraction possibly underflow? Asking since there is the max_data_write > 0 check below. Thanks. Deferred the calculation. https://review.coreboot.org/c/flashrom/+/30409/4/dummyflasher.c File dummyflasher.c: https://review.coreboot.org/c/flashrom/+/30409/4/dummyflasher.c@234 PS4, Line 234: %i > Should be %u now Done https://review.coreboot.org/c/flashrom/+/30409/4/dummyflasher.c@270 PS4, Line 270: %i > Should be %u now Done https://review.coreboot.org/c/flashrom/+/30409/4/print.c File print.c: https://review.coreboot.org/c/flashrom/+/30409/4/print.c@331 PS4, Line 331: %d > Should be %u now Done -- To view, visit https://review.coreboot.org/c/flashrom/+/30409 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I08895543ffb7a48058bcf91ef6500ca113f2d305 Gerrit-Change-Number: 30409 Gerrit-PatchSet: 5 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Jacob Garber <jgarber1(a)ualberta.ca> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Sat, 27 Jul 2019 21:04:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Jacob Garber <jgarber1(a)ualberta.ca> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Fix -Wsign-compare trouble
by Nico Huber (Code Review) July 27, 2019

July 27, 2019

Hello Jacob Garber, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/30409 to look at the new patch set (#5). Change subject: Fix -Wsign-compare trouble ...................................................................... Fix -Wsign-compare trouble Mostly by changing to `unsigned` types where applicable, sometimes `signed` types, and casting as a last resort. Change-Id: I08895543ffb7a48058bcf91ef6500ca113f2d305 Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M 82802ab.c M at45db.c M bitbang_spi.c M board_enable.c M buspirate_spi.c M cbtable.c M cli_classic.c M dediprog.c M dmi.c M dummyflasher.c M en29lv640b.c M flash.h M flashrom.c M fmap.c M helpers.c M ich_descriptors.c M ichspi.c M it85spi.c M it87spi.c M jedec.c M layout.c M pickit2_spi.c M print.c M print_wiki.c M programmer.h M sb600spi.c M serial.c M serprog.c M sst28sf040.c M sst_fwhub.c M usbblaster_spi.c M wbsio_spi.c 32 files changed, 116 insertions(+), 107 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/09/30409/5 -- To view, visit https://review.coreboot.org/c/flashrom/+/30409 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I08895543ffb7a48058bcf91ef6500ca113f2d305 Gerrit-Change-Number: 30409 Gerrit-PatchSet: 5 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Jacob Garber <jgarber1(a)ualberta.ca> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: Fix -Wsign-compare trouble
by Jacob Garber (Code Review) July 25, 2019

July 25, 2019

Jacob Garber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/30409 ) Change subject: Fix -Wsign-compare trouble ...................................................................... Patch Set 4: Code-Review+1 (4 comments) https://review.coreboot.org/c/flashrom/+/30409/4/at45db.c File at45db.c: https://review.coreboot.org/c/flashrom/+/30409/4/at45db.c@466 PS4, Line 466: flash->mst->spi.max_data_write - 4 Could this subtraction possibly underflow? Asking since there is the max_data_write > 0 check below. https://review.coreboot.org/c/flashrom/+/30409/4/dummyflasher.c File dummyflasher.c: https://review.coreboot.org/c/flashrom/+/30409/4/dummyflasher.c@234 PS4, Line 234: %i Should be %u now https://review.coreboot.org/c/flashrom/+/30409/4/dummyflasher.c@270 PS4, Line 270: %i Should be %u now https://review.coreboot.org/c/flashrom/+/30409/4/print.c File print.c: https://review.coreboot.org/c/flashrom/+/30409/4/print.c@331 PS4, Line 331: %d Should be %u now -- To view, visit https://review.coreboot.org/c/flashrom/+/30409 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I08895543ffb7a48058bcf91ef6500ca113f2d305 Gerrit-Change-Number: 30409 Gerrit-PatchSet: 4 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Jacob Garber <jgarber1(a)ualberta.ca> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 25 Jul 2019 21:45:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Fix -Wunused-parameter issues
by Nico Huber (Code Review) July 24, 2019

July 24, 2019

Hello Jacob Garber, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/30410 to look at the new patch set (#5). Change subject: Fix -Wunused-parameter issues ...................................................................... Fix -Wunused-parameter issues Issue statements with the parameters casted to `void`. Alternatively we could use __attribute__ ((unused)). Change-Id: If831398c91e9f49bd5216a03ed4caaa2a7ab02bd Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M 82802ab.c M atahpt.c M atapromise.c M atavia.c M buspirate_spi.c M cbtable.c M ch341a_spi.c M chipset_enable.c M dediprog.c M developerbox_spi.c M digilent_spi.c M dmi.c M drkaiser.c M dummyflasher.c M ft2232_spi.c M gfxnvidia.c M hwaccess.c M ich_descriptors.c M internal.c M it8212.c M it85spi.c M it87spi.c M jedec.c M jlink_spi.c M libflashrom.c M linux_mtd.c M linux_spi.c M mstarddc_spi.c M nic3com.c M nicintel.c M nicintel_eeprom.c M nicintel_spi.c M nicnatsemi.c M nicrealtek.c M pcidev.c M pickit2_spi.c M pony_spi.c M programmer.c M rayer_spi.c M satamv.c M satasii.c M sb600spi.c M serial.c M serprog.c M spi25.c M sst28sf040.c M sst49lfxxxc.c M udelay.c M usbblaster_spi.c M usbdev.c M w39.c M wbsio_spi.c 52 files changed, 278 insertions(+), 32 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/10/30410/5 -- To view, visit https://review.coreboot.org/c/flashrom/+/30410 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: If831398c91e9f49bd5216a03ed4caaa2a7ab02bd Gerrit-Change-Number: 30410 Gerrit-PatchSet: 5 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Jacob Garber <jgarber1(a)ualberta.ca> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: Fix -Wsign-compare trouble
by Nico Huber (Code Review) July 24, 2019

July 24, 2019

Hello Jacob Garber, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/30409 to look at the new patch set (#4). Change subject: Fix -Wsign-compare trouble ...................................................................... Fix -Wsign-compare trouble Mostly by changing to `unsigned` types where applicable, sometimes `signed` types, and casting as a last resort. Change-Id: I08895543ffb7a48058bcf91ef6500ca113f2d305 Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M 82802ab.c M at45db.c M bitbang_spi.c M board_enable.c M buspirate_spi.c M cbtable.c M cli_classic.c M dediprog.c M dmi.c M dummyflasher.c M en29lv640b.c M flash.h M flashrom.c M fmap.c M helpers.c M ich_descriptors.c M ichspi.c M it85spi.c M it87spi.c M jedec.c M layout.c M pickit2_spi.c M print.c M print_wiki.c M programmer.h M sb600spi.c M serial.c M serprog.c M sst28sf040.c M sst_fwhub.c M usbblaster_spi.c M wbsio_spi.c 32 files changed, 111 insertions(+), 102 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/09/30409/4 -- To view, visit https://review.coreboot.org/c/flashrom/+/30409 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I08895543ffb7a48058bcf91ef6500ca113f2d305 Gerrit-Change-Number: 30409 Gerrit-PatchSet: 4 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Jacob Garber <jgarber1(a)ualberta.ca> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: Fix -Wunused-parameter issues
by Nico Huber (Code Review) July 24, 2019

July 24, 2019

Hello Jacob Garber, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/30410 to look at the new patch set (#4). Change subject: Fix -Wunused-parameter issues ...................................................................... Fix -Wunused-parameter issues Issue statements with the parameters casted to `void`. Alternatively we could use __attribute__ ((unused)). Change-Id: If831398c91e9f49bd5216a03ed4caaa2a7ab02bd Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M 82802ab.c M atahpt.c M atapromise.c M atavia.c M buspirate_spi.c M cbtable.c M ch341a_spi.c M chipset_enable.c M dediprog.c M developerbox_spi.c M digilent_spi.c M dmi.c M drkaiser.c M dummyflasher.c M ft2232_spi.c M gfxnvidia.c M hwaccess.c M ich_descriptors.c M internal.c M it8212.c M it85spi.c M it87spi.c M jedec.c M libflashrom.c M linux_mtd.c M linux_spi.c M mstarddc_spi.c M nic3com.c M nicintel.c M nicintel_eeprom.c M nicintel_spi.c M nicnatsemi.c M nicrealtek.c M pcidev.c M pickit2_spi.c M pony_spi.c M programmer.c M rayer_spi.c M satamv.c M satasii.c M sb600spi.c M serial.c M serprog.c M spi25.c M sst28sf040.c M sst49lfxxxc.c M udelay.c M usbblaster_spi.c M usbdev.c M w39.c M wbsio_spi.c 51 files changed, 274 insertions(+), 32 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/10/30410/4 -- To view, visit https://review.coreboot.org/c/flashrom/+/30410 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: If831398c91e9f49bd5216a03ed4caaa2a7ab02bd Gerrit-Change-Number: 30410 Gerrit-PatchSet: 4 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Jacob Garber <jgarber1(a)ualberta.ca> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: Fix -Wsign-compare trouble
by Nico Huber (Code Review) July 24, 2019

July 24, 2019

Hello Jacob Garber, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/30409 to look at the new patch set (#3). Change subject: Fix -Wsign-compare trouble ...................................................................... Fix -Wsign-compare trouble Mostly by changing to `unsigned` types where applicable, sometimes `signed` types, and casting as a last resort. Change-Id: I08895543ffb7a48058bcf91ef6500ca113f2d305 Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M 82802ab.c M at45db.c M bitbang_spi.c M board_enable.c M buspirate_spi.c M cbtable.c M cli_classic.c M dediprog.c M dmi.c M dummyflasher.c M en29lv640b.c M flash.h M flashrom.c M fmap.c M helpers.c M ich_descriptors.c M ichspi.c M it85spi.c M it87spi.c M jedec.c M layout.c M pickit2_spi.c M print.c M programmer.h M sb600spi.c M serial.c M serprog.c M sst28sf040.c M sst_fwhub.c M usbblaster_spi.c M wbsio_spi.c 31 files changed, 110 insertions(+), 101 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/09/30409/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/30409 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I08895543ffb7a48058bcf91ef6500ca113f2d305 Gerrit-Change-Number: 30409 Gerrit-PatchSet: 3 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Jacob Garber <jgarber1(a)ualberta.ca> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: Fix -Wunused-parameter issues
by Nico Huber (Code Review) July 24, 2019

July 24, 2019

Hello Jacob Garber, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/30410 to look at the new patch set (#3). Change subject: Fix -Wunused-parameter issues ...................................................................... Fix -Wunused-parameter issues Issue statements with the parameters casted to `void`. Alternatively we could use __attribute__ ((unused)). Change-Id: If831398c91e9f49bd5216a03ed4caaa2a7ab02bd Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M 82802ab.c M atavia.c M buspirate_spi.c M cbtable.c M ch341a_spi.c M chipset_enable.c M dediprog.c M developerbox_spi.c M digilent_spi.c M dmi.c M drkaiser.c M dummyflasher.c M ft2232_spi.c M gfxnvidia.c M hwaccess.c M internal.c M it8212.c M it85spi.c M it87spi.c M jedec.c M libflashrom.c M linux_mtd.c M linux_spi.c M nic3com.c M nicintel.c M nicintel_eeprom.c M nicintel_spi.c M nicrealtek.c M pcidev.c M pickit2_spi.c M pony_spi.c M programmer.c M rayer_spi.c M satamv.c M satasii.c M sb600spi.c M serial.c M serprog.c M spi25.c M sst28sf040.c M sst49lfxxxc.c M udelay.c M usbblaster_spi.c M usbdev.c M w39.c M wbsio_spi.c 46 files changed, 258 insertions(+), 32 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/10/30410/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/30410 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: If831398c91e9f49bd5216a03ed4caaa2a7ab02bd Gerrit-Change-Number: 30410 Gerrit-PatchSet: 3 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Jacob Garber <jgarber1(a)ualberta.ca> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: Makefile,meson.build: Enable/assume -Wextra
by Nico Huber (Code Review) July 24, 2019

July 24, 2019

Hello Jacob Garber, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/30411 to look at the new patch set (#3). Change subject: Makefile,meson.build: Enable/assume -Wextra ...................................................................... Makefile,meson.build: Enable/assume -Wextra Change-Id: Id2ece264c2d483e34019985dd3a7631c4889abe6 Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M Makefile M meson.build 2 files changed, 1 insertion(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/11/30411/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/30411 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Id2ece264c2d483e34019985dd3a7631c4889abe6 Gerrit-Change-Number: 30411 Gerrit-PatchSet: 3 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Jacob Garber <jgarber1(a)ualberta.ca> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: layout: Introduce flashrom_layout_add_region()
by Angel Pons (Code Review) July 24, 2019

July 24, 2019

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/33517 ) Change subject: layout: Introduce flashrom_layout_add_region() ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://review.coreboot.org/c/flashrom/+/33517 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I50d473d0d5d1fb38bd6f9ae3d7127e9ea66a94e1 Gerrit-Change-Number: 33517 Gerrit-PatchSet: 3 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 24 Jul 2019 16:55:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: layout: Add `max_entries` field
by Angel Pons (Code Review) July 24, 2019

July 24, 2019

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/33516 ) Change subject: layout: Add `max_entries` field ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/33516 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib5f431bc0a72a79a53fa1376c3417942b19dd3a0 Gerrit-Change-Number: 33516 Gerrit-PatchSet: 3 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 24 Jul 2019 16:53:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: flashchips: Add support for N25Q512..1E
by Jacob Creedon (Code Review) July 22, 2019

July 22, 2019

Jacob Creedon has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/34413 ) Change subject: flashchips: Add support for N25Q512..1E ...................................................................... flashchips: Add support for N25Q512..1E This adds support for the 1.8v variant of N25Q512. Signed-off-by: Jacob Creedon <jcreedon(a)google.com> Change-Id: I9e8d2c1fc0c09efea7812fa513b45d1a372d06d7 --- M flashchips.c 1 file changed, 40 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/13/34413/1 diff --git a/flashchips.c b/flashchips.c index 166af6a..cc22414 100644 --- a/flashchips.c +++ b/flashchips.c @@ -10585,6 +10585,46 @@ { .vendor = "Micron", + .name = "N25Q512..1E/MT25QU512", /* ..1E/U = 1.8V, uniform 64KB/4KB blocks/sectors */ + .bustype = BUS_SPI, + .manufacture_id = ST_ID, + .model_id = ST_N25Q512__1E, + .total_size = 65536, + .page_size = 256, + /* supports SFDP */ + /* OTP: 64B total; read 0x4B, write 0x42 */ + .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP | FEATURE_4BA_WREN, + .tested = TEST_OK_PREW, + .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, + .block_erasers = + { + { + .eraseblocks = { {4 * 1024, 16384} }, + .block_erase = spi_block_erase_21, + }, { + .eraseblocks = { {4 * 1024, 16384} }, + .block_erase = spi_block_erase_20, + }, { + .eraseblocks = { {64 * 1024, 1024} }, + .block_erase = spi_block_erase_dc, + }, { + .eraseblocks = { {64 * 1024, 1024} }, + .block_erase = spi_block_erase_d8, + }, { + .eraseblocks = { {65536 * 1024, 1} }, + .block_erase = spi_block_erase_c7, + } + }, + .printlock = spi_prettyprint_status_register_n25q, /* TODO: config, lock, flag regs */ + .unlock = spi_disable_blockprotect_n25q, /* TODO: per 64kB sector lock registers */ + .write = spi_chip_write_256, /* Multi I/O supported */ + .read = spi_chip_read, /* Fast read (0x0B) and multi I/O supported */ + .voltage = {2700, 3600}, + }, + + { + .vendor = "Micron", .name = "N25Q512..3E/MT25QL512", /* ..3E/L = 3V, uniform 64KB/4KB blocks/sectors */ .bustype = BUS_SPI, .manufacture_id = ST_ID, -- To view, visit https://review.coreboot.org/c/flashrom/+/34413 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I9e8d2c1fc0c09efea7812fa513b45d1a372d06d7 Gerrit-Change-Number: 34413 Gerrit-PatchSet: 1 Gerrit-Owner: Jacob Creedon <jcreedon(a)google.com> Gerrit-MessageType: newchange

2 11

Change in flashrom[master]: cli_classic: Fix Memory leak
by HAOUAS Elyes (Code Review) July 19, 2019

July 19, 2019

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/34405 ) Change subject: cli_classic: Fix Memory leak ...................................................................... cli_classic: Fix Memory leak Found-by scan-build: 7.0.1-8 Change-Id: I84e642b57b95953f376569e443ef8d8eda7bf98f Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M cli_classic.c 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/05/34405/1 diff --git a/cli_classic.c b/cli_classic.c index b79f953..19d65cc 100644 --- a/cli_classic.c +++ b/cli_classic.c @@ -383,6 +383,11 @@ fprintf(stderr, "Log file not supported in standalone mode. Aborting.\n"); cli_classic_abort_usage(); #else /* STANDALONE */ + if (logfile[0] != '\0') { + fprintf(stderr, "Warning: log file not free of older string. Running free() rightnow.\n"); + free(logfile); + } + logfile = strdup(optarg); if (logfile[0] == '\0') { fprintf(stderr, "No log filename specified.\n"); -- To view, visit https://review.coreboot.org/c/flashrom/+/34405 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I84e642b57b95953f376569e443ef8d8eda7bf98f Gerrit-Change-Number: 34405 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

2 5

Change in flashrom[master]: spi25: Remove dead increment
by HAOUAS Elyes (Code Review) July 19, 2019

July 19, 2019

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/34404 ) Change subject: spi25: Remove dead increment ...................................................................... spi25: Remove dead increment Value stored in 'pos' is never read. Found-by scan-build: 7.0.1-8 Change-Id: I9a70593f182d7558e71e831fc2b834ac58a25b2a Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M spi25.c 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/04/34404/1 diff --git a/spi25.c b/spi25.c index 36f265a..2a1d492 100644 --- a/spi25.c +++ b/spi25.c @@ -782,7 +782,6 @@ if (pos < start + len) { if (spi_chip_write_1(flash, buf + pos - start, pos, pos % 2)) return SPI_GENERIC_ERROR; - pos += pos % 2; } return 0; -- To view, visit https://review.coreboot.org/c/flashrom/+/34404 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I9a70593f182d7558e71e831fc2b834ac58a25b2a Gerrit-Change-Number: 34404 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

2 4

Change in flashrom[master]: pickit2_spi: Remove dead assignment
by HAOUAS Elyes (Code Review) July 19, 2019

July 19, 2019

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/34403 ) Change subject: pickit2_spi: Remove dead assignment ...................................................................... pickit2_spi: Remove dead assignment We never read the first 'ret', so remove it. Also, print the version only when the command succeeded. Change-Id: I4aac5e1f3bd0604b079e1fdd9b7f09f1f4fc2d7f Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M pickit2_spi.c 1 file changed, 2 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/03/34403/1 diff --git a/pickit2_spi.c b/pickit2_spi.c index 6d9b28f..4e9ca1d 100644 --- a/pickit2_spi.c +++ b/pickit2_spi.c @@ -93,17 +93,16 @@ { int ret; uint8_t command[CMD_LENGTH] = {CMD_GET_VERSION, CMD_END_OF_BUFFER}; - int transferred; - ret = libusb_interrupt_transfer(pickit2_handle, ENDPOINT_OUT, command, CMD_LENGTH, &transferred, DFLT_TIMEOUT); + ret = libusb_interrupt_transfer(pickit2_handle, ENDPOINT_IN, command, CMD_LENGTH, &transferred, DFLT_TIMEOUT); - msg_pdbg("PICkit2 Firmware Version: %d.%d\n", (int)command[0], (int)command[1]); if (ret != 0) { msg_perr("Command Get Firmware Version failed!\n"); return 1; } + msg_pdbg("PICkit2 Firmware Version: %d.%d\n", (int)command[0], (int)command[1]); return 0; } -- To view, visit https://review.coreboot.org/c/flashrom/+/34403 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I4aac5e1f3bd0604b079e1fdd9b7f09f1f4fc2d7f Gerrit-Change-Number: 34403 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

2 9