July 2019 - flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: Fix -Wsign-compare trouble
by Nico Huber (Code Review) July 27, 2019

July 27, 2019

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/30409 ) Change subject: Fix -Wsign-compare trouble ...................................................................... Patch Set 5: (1 comment) https://review.coreboot.org/c/flashrom/+/30409/5/fmap.c File fmap.c: https://review.coreboot.org/c/flashrom/+/30409/5/fmap.c@99 PS5, Line 99: (len - sizeof(struct fmap)) Not sure anymore why I placed the parentheses. It looks like it would be safer without? i.e. do the calculation as signed, so the overflow wouldn't be a problem? -- To view, visit https://review.coreboot.org/c/flashrom/+/30409 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I08895543ffb7a48058bcf91ef6500ca113f2d305 Gerrit-Change-Number: 30409 Gerrit-PatchSet: 5 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Jacob Garber <jgarber1(a)ualberta.ca> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Sat, 27 Jul 2019 23:25:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Fix -Wsign-compare trouble
by Nico Huber (Code Review) July 27, 2019

July 27, 2019

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/30409 ) Change subject: Fix -Wsign-compare trouble ...................................................................... Patch Set 5: (4 comments) https://review.coreboot.org/c/flashrom/+/30409/4/at45db.c File at45db.c: https://review.coreboot.org/c/flashrom/+/30409/4/at45db.c@466 PS4, Line 466: flash->mst->spi.max_data_write - 4 > Could this subtraction possibly underflow? Asking since there is the max_data_write > 0 check below. Thanks. Deferred the calculation. https://review.coreboot.org/c/flashrom/+/30409/4/dummyflasher.c File dummyflasher.c: https://review.coreboot.org/c/flashrom/+/30409/4/dummyflasher.c@234 PS4, Line 234: %i > Should be %u now Done https://review.coreboot.org/c/flashrom/+/30409/4/dummyflasher.c@270 PS4, Line 270: %i > Should be %u now Done https://review.coreboot.org/c/flashrom/+/30409/4/print.c File print.c: https://review.coreboot.org/c/flashrom/+/30409/4/print.c@331 PS4, Line 331: %d > Should be %u now Done -- To view, visit https://review.coreboot.org/c/flashrom/+/30409 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I08895543ffb7a48058bcf91ef6500ca113f2d305 Gerrit-Change-Number: 30409 Gerrit-PatchSet: 5 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Jacob Garber <jgarber1(a)ualberta.ca> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Sat, 27 Jul 2019 21:04:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Jacob Garber <jgarber1(a)ualberta.ca> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Fix -Wsign-compare trouble
by Nico Huber (Code Review) July 27, 2019

July 27, 2019

Hello Jacob Garber, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/30409 to look at the new patch set (#5). Change subject: Fix -Wsign-compare trouble ...................................................................... Fix -Wsign-compare trouble Mostly by changing to `unsigned` types where applicable, sometimes `signed` types, and casting as a last resort. Change-Id: I08895543ffb7a48058bcf91ef6500ca113f2d305 Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M 82802ab.c M at45db.c M bitbang_spi.c M board_enable.c M buspirate_spi.c M cbtable.c M cli_classic.c M dediprog.c M dmi.c M dummyflasher.c M en29lv640b.c M flash.h M flashrom.c M fmap.c M helpers.c M ich_descriptors.c M ichspi.c M it85spi.c M it87spi.c M jedec.c M layout.c M pickit2_spi.c M print.c M print_wiki.c M programmer.h M sb600spi.c M serial.c M serprog.c M sst28sf040.c M sst_fwhub.c M usbblaster_spi.c M wbsio_spi.c 32 files changed, 116 insertions(+), 107 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/09/30409/5 -- To view, visit https://review.coreboot.org/c/flashrom/+/30409 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I08895543ffb7a48058bcf91ef6500ca113f2d305 Gerrit-Change-Number: 30409 Gerrit-PatchSet: 5 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Jacob Garber <jgarber1(a)ualberta.ca> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: Fix -Wsign-compare trouble
by Jacob Garber (Code Review) July 25, 2019

July 25, 2019

Jacob Garber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/30409 ) Change subject: Fix -Wsign-compare trouble ...................................................................... Patch Set 4: Code-Review+1 (4 comments) https://review.coreboot.org/c/flashrom/+/30409/4/at45db.c File at45db.c: https://review.coreboot.org/c/flashrom/+/30409/4/at45db.c@466 PS4, Line 466: flash->mst->spi.max_data_write - 4 Could this subtraction possibly underflow? Asking since there is the max_data_write > 0 check below. https://review.coreboot.org/c/flashrom/+/30409/4/dummyflasher.c File dummyflasher.c: https://review.coreboot.org/c/flashrom/+/30409/4/dummyflasher.c@234 PS4, Line 234: %i Should be %u now https://review.coreboot.org/c/flashrom/+/30409/4/dummyflasher.c@270 PS4, Line 270: %i Should be %u now https://review.coreboot.org/c/flashrom/+/30409/4/print.c File print.c: https://review.coreboot.org/c/flashrom/+/30409/4/print.c@331 PS4, Line 331: %d Should be %u now -- To view, visit https://review.coreboot.org/c/flashrom/+/30409 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I08895543ffb7a48058bcf91ef6500ca113f2d305 Gerrit-Change-Number: 30409 Gerrit-PatchSet: 4 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Jacob Garber <jgarber1(a)ualberta.ca> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 25 Jul 2019 21:45:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Fix -Wunused-parameter issues
by Nico Huber (Code Review) July 24, 2019

July 24, 2019

Hello Jacob Garber, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/30410 to look at the new patch set (#5). Change subject: Fix -Wunused-parameter issues ...................................................................... Fix -Wunused-parameter issues Issue statements with the parameters casted to `void`. Alternatively we could use __attribute__ ((unused)). Change-Id: If831398c91e9f49bd5216a03ed4caaa2a7ab02bd Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M 82802ab.c M atahpt.c M atapromise.c M atavia.c M buspirate_spi.c M cbtable.c M ch341a_spi.c M chipset_enable.c M dediprog.c M developerbox_spi.c M digilent_spi.c M dmi.c M drkaiser.c M dummyflasher.c M ft2232_spi.c M gfxnvidia.c M hwaccess.c M ich_descriptors.c M internal.c M it8212.c M it85spi.c M it87spi.c M jedec.c M jlink_spi.c M libflashrom.c M linux_mtd.c M linux_spi.c M mstarddc_spi.c M nic3com.c M nicintel.c M nicintel_eeprom.c M nicintel_spi.c M nicnatsemi.c M nicrealtek.c M pcidev.c M pickit2_spi.c M pony_spi.c M programmer.c M rayer_spi.c M satamv.c M satasii.c M sb600spi.c M serial.c M serprog.c M spi25.c M sst28sf040.c M sst49lfxxxc.c M udelay.c M usbblaster_spi.c M usbdev.c M w39.c M wbsio_spi.c 52 files changed, 278 insertions(+), 32 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/10/30410/5 -- To view, visit https://review.coreboot.org/c/flashrom/+/30410 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: If831398c91e9f49bd5216a03ed4caaa2a7ab02bd Gerrit-Change-Number: 30410 Gerrit-PatchSet: 5 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Jacob Garber <jgarber1(a)ualberta.ca> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: Fix -Wsign-compare trouble
by Nico Huber (Code Review) July 24, 2019

July 24, 2019

Hello Jacob Garber, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/30409 to look at the new patch set (#4). Change subject: Fix -Wsign-compare trouble ...................................................................... Fix -Wsign-compare trouble Mostly by changing to `unsigned` types where applicable, sometimes `signed` types, and casting as a last resort. Change-Id: I08895543ffb7a48058bcf91ef6500ca113f2d305 Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M 82802ab.c M at45db.c M bitbang_spi.c M board_enable.c M buspirate_spi.c M cbtable.c M cli_classic.c M dediprog.c M dmi.c M dummyflasher.c M en29lv640b.c M flash.h M flashrom.c M fmap.c M helpers.c M ich_descriptors.c M ichspi.c M it85spi.c M it87spi.c M jedec.c M layout.c M pickit2_spi.c M print.c M print_wiki.c M programmer.h M sb600spi.c M serial.c M serprog.c M sst28sf040.c M sst_fwhub.c M usbblaster_spi.c M wbsio_spi.c 32 files changed, 111 insertions(+), 102 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/09/30409/4 -- To view, visit https://review.coreboot.org/c/flashrom/+/30409 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I08895543ffb7a48058bcf91ef6500ca113f2d305 Gerrit-Change-Number: 30409 Gerrit-PatchSet: 4 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Jacob Garber <jgarber1(a)ualberta.ca> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: Fix -Wunused-parameter issues
by Nico Huber (Code Review) July 24, 2019

July 24, 2019

Hello Jacob Garber, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/30410 to look at the new patch set (#4). Change subject: Fix -Wunused-parameter issues ...................................................................... Fix -Wunused-parameter issues Issue statements with the parameters casted to `void`. Alternatively we could use __attribute__ ((unused)). Change-Id: If831398c91e9f49bd5216a03ed4caaa2a7ab02bd Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M 82802ab.c M atahpt.c M atapromise.c M atavia.c M buspirate_spi.c M cbtable.c M ch341a_spi.c M chipset_enable.c M dediprog.c M developerbox_spi.c M digilent_spi.c M dmi.c M drkaiser.c M dummyflasher.c M ft2232_spi.c M gfxnvidia.c M hwaccess.c M ich_descriptors.c M internal.c M it8212.c M it85spi.c M it87spi.c M jedec.c M libflashrom.c M linux_mtd.c M linux_spi.c M mstarddc_spi.c M nic3com.c M nicintel.c M nicintel_eeprom.c M nicintel_spi.c M nicnatsemi.c M nicrealtek.c M pcidev.c M pickit2_spi.c M pony_spi.c M programmer.c M rayer_spi.c M satamv.c M satasii.c M sb600spi.c M serial.c M serprog.c M spi25.c M sst28sf040.c M sst49lfxxxc.c M udelay.c M usbblaster_spi.c M usbdev.c M w39.c M wbsio_spi.c 51 files changed, 274 insertions(+), 32 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/10/30410/4 -- To view, visit https://review.coreboot.org/c/flashrom/+/30410 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: If831398c91e9f49bd5216a03ed4caaa2a7ab02bd Gerrit-Change-Number: 30410 Gerrit-PatchSet: 4 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Jacob Garber <jgarber1(a)ualberta.ca> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: Fix -Wsign-compare trouble
by Nico Huber (Code Review) July 24, 2019

July 24, 2019

Hello Jacob Garber, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/30409 to look at the new patch set (#3). Change subject: Fix -Wsign-compare trouble ...................................................................... Fix -Wsign-compare trouble Mostly by changing to `unsigned` types where applicable, sometimes `signed` types, and casting as a last resort. Change-Id: I08895543ffb7a48058bcf91ef6500ca113f2d305 Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M 82802ab.c M at45db.c M bitbang_spi.c M board_enable.c M buspirate_spi.c M cbtable.c M cli_classic.c M dediprog.c M dmi.c M dummyflasher.c M en29lv640b.c M flash.h M flashrom.c M fmap.c M helpers.c M ich_descriptors.c M ichspi.c M it85spi.c M it87spi.c M jedec.c M layout.c M pickit2_spi.c M print.c M programmer.h M sb600spi.c M serial.c M serprog.c M sst28sf040.c M sst_fwhub.c M usbblaster_spi.c M wbsio_spi.c 31 files changed, 110 insertions(+), 101 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/09/30409/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/30409 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I08895543ffb7a48058bcf91ef6500ca113f2d305 Gerrit-Change-Number: 30409 Gerrit-PatchSet: 3 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Jacob Garber <jgarber1(a)ualberta.ca> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: Fix -Wunused-parameter issues
by Nico Huber (Code Review) July 24, 2019

July 24, 2019

Hello Jacob Garber, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/30410 to look at the new patch set (#3). Change subject: Fix -Wunused-parameter issues ...................................................................... Fix -Wunused-parameter issues Issue statements with the parameters casted to `void`. Alternatively we could use __attribute__ ((unused)). Change-Id: If831398c91e9f49bd5216a03ed4caaa2a7ab02bd Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M 82802ab.c M atavia.c M buspirate_spi.c M cbtable.c M ch341a_spi.c M chipset_enable.c M dediprog.c M developerbox_spi.c M digilent_spi.c M dmi.c M drkaiser.c M dummyflasher.c M ft2232_spi.c M gfxnvidia.c M hwaccess.c M internal.c M it8212.c M it85spi.c M it87spi.c M jedec.c M libflashrom.c M linux_mtd.c M linux_spi.c M nic3com.c M nicintel.c M nicintel_eeprom.c M nicintel_spi.c M nicrealtek.c M pcidev.c M pickit2_spi.c M pony_spi.c M programmer.c M rayer_spi.c M satamv.c M satasii.c M sb600spi.c M serial.c M serprog.c M spi25.c M sst28sf040.c M sst49lfxxxc.c M udelay.c M usbblaster_spi.c M usbdev.c M w39.c M wbsio_spi.c 46 files changed, 258 insertions(+), 32 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/10/30410/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/30410 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: If831398c91e9f49bd5216a03ed4caaa2a7ab02bd Gerrit-Change-Number: 30410 Gerrit-PatchSet: 3 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Jacob Garber <jgarber1(a)ualberta.ca> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: Makefile,meson.build: Enable/assume -Wextra
by Nico Huber (Code Review) July 24, 2019

July 24, 2019

Hello Jacob Garber, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/30411 to look at the new patch set (#3). Change subject: Makefile,meson.build: Enable/assume -Wextra ...................................................................... Makefile,meson.build: Enable/assume -Wextra Change-Id: Id2ece264c2d483e34019985dd3a7631c4889abe6 Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M Makefile M meson.build 2 files changed, 1 insertion(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/11/30411/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/30411 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Id2ece264c2d483e34019985dd3a7631c4889abe6 Gerrit-Change-Number: 30411 Gerrit-PatchSet: 3 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Jacob Garber <jgarber1(a)ualberta.ca> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0