June 2019 - flashrom-gerrit - mail.coreboot.org

Change in ...flashrom[master]: Rework internal bus handling and laptop bail-out
by Nico Huber (Code Review) June 3, 2019

June 3, 2019

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/28716 ) Change subject: Rework internal bus handling and laptop bail-out ...................................................................... Patch Set 5: (2 comments) Rebased again (properly, I hope) and added a commit message. https://review.coreboot.org/#/c/28716/1/chipset_enable.c File chipset_enable.c: https://review.coreboot.org/#/c/28716/1/chipset_enable.c@773 PS1, Line 773: > Yes? Done by rebase? https://review.coreboot.org/#/c/28716/1/internal.c File internal.c: https://review.coreboot.org/#/c/28716/1/internal.c@283 PS1, Line 283: proped > proped? Maybe probed? Done -- To view, visit https://review.coreboot.org/c/flashrom/+/28716 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I1dbda8cf0c10d7786106f14f0d18c3dcce35f0a3 Gerrit-Change-Number: 28716 Gerrit-PatchSet: 5 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 03 Jun 2019 22:26:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

Change in ...flashrom[master]: chipset_enable: Mark Intel QS77 as DEP
by Evgeny Zinoviev (Code Review) June 3, 2019

June 3, 2019

Evgeny Zinoviev has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/33164 Change subject: chipset_enable: Mark Intel QS77 as DEP ...................................................................... chipset_enable: Mark Intel QS77 as DEP Tested reading and writing with `-p internal` on MacBook Air 5,1 with Intel QS77. Change-Id: I508b6379507c2881c976d6baf7348b1161449cfe Signed-off-by: Evgeny Zinoviev <me(a)ch1p.io> --- M chipset_enable.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/64/33164/1 diff --git a/chipset_enable.c b/chipset_enable.c index 6280876..19fd658 100644 --- a/chipset_enable.c +++ b/chipset_enable.c @@ -1746,7 +1746,7 @@ {0x8086, 0x1e4a, DEP, "Intel", "H77", enable_flash_pch7}, {0x8086, 0x1e53, NT, "Intel", "C216", enable_flash_pch7}, {0x8086, 0x1e55, DEP, "Intel", "QM77", enable_flash_pch7}, - {0x8086, 0x1e56, NT, "Intel", "QS77", enable_flash_pch7}, + {0x8086, 0x1e56, DEP, "Intel", "QS77", enable_flash_pch7}, {0x8086, 0x1e57, DEP, "Intel", "HM77", enable_flash_pch7}, {0x8086, 0x1e58, NT, "Intel", "UM77", enable_flash_pch7}, {0x8086, 0x1e59, NT, "Intel", "HM76", enable_flash_pch7}, -- To view, visit https://review.coreboot.org/c/flashrom/+/33164 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I508b6379507c2881c976d6baf7348b1161449cfe Gerrit-Change-Number: 33164 Gerrit-PatchSet: 1 Gerrit-Owner: Evgeny Zinoviev <me(a)ch1p.com> Gerrit-MessageType: newchange

2 4

Change in ...flashrom[1.1.x]: usbdev: Only match requested USB devices
by Nico Huber (Code Review) June 3, 2019

June 3, 2019

Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/c/flashrom/+/32892 ) Change subject: usbdev: Only match requested USB devices ...................................................................... usbdev: Only match requested USB devices Don't use a device that has the same vendor ID, but a different than requested product ID. Fixes broken dediprog detection with TOMU in use. Change-Id: I08c1c363ce2d6603e46efecc61d3910e02314fca Signed-off-by: Patrick Rudolph <patrick.rudolph(a)9elements.com> Reviewed-on: https://review.coreboot.org/c/flashrom/+/32892 Reviewed-by: Nico Huber <nico.h(a)gmx.de> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M usbdev.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved diff --git a/usbdev.c b/usbdev.c index d793b65..764ac04 100644 --- a/usbdev.c +++ b/usbdev.c @@ -54,7 +54,7 @@ continue; } - if ((desc.idVendor != vid) && (desc.idProduct != pid)) + if ((desc.idVendor != vid) || (desc.idProduct != pid)) continue; msg_pdbg("Found USB device %04"PRIx16":%04"PRIx16" at address %d-%d.\n", -- To view, visit https://review.coreboot.org/c/flashrom/+/32892 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: 1.1.x Gerrit-Change-Id: I08c1c363ce2d6603e46efecc61d3910e02314fca Gerrit-Change-Number: 32892 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-MessageType: merged

1 0

Change in ...flashrom[master]: dummyflasher: Add emulation for Winbond W25Q128FV
by Nico Huber (Code Review) June 3, 2019

June 3, 2019

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/31011 Change subject: dummyflasher: Add emulation for Winbond W25Q128FV ...................................................................... dummyflasher: Add emulation for Winbond W25Q128FV Just needed a 16MiB chip. Change-Id: Ic01d45c1f709808404ad53bb31f8b998c6977a9d Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M dummyflasher.c 1 file changed, 31 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/11/31011/1 diff --git a/dummyflasher.c b/dummyflasher.c index 2929686..22b28c4 100644 --- a/dummyflasher.c +++ b/dummyflasher.c @@ -43,6 +43,7 @@ EMULATE_SST_SST25VF040_REMS, EMULATE_SST_SST25VF032B, EMULATE_MACRONIX_MX25L6436, + EMULATE_WINBOND_W25Q128FV, }; static enum emu_chip emu_chip = EMULATE_NONE; static char *emu_persistent_image = NULL; @@ -331,6 +332,18 @@ msg_pdbg("Emulating Macronix MX25L6436 SPI flash chip (RDID, " "SFDP)\n"); } + if (!strcmp(tmp, "W25Q128FV")) { + emu_chip = EMULATE_WINBOND_W25Q128FV; + emu_chip_size = 16 * 1024 * 1024; + emu_max_byteprogram_size = 256; + emu_max_aai_size = 0; + emu_jedec_se_size = 4 * 1024; + emu_jedec_be_52_size = 32 * 1024; + emu_jedec_be_d8_size = 64 * 1024; + emu_jedec_ce_60_size = emu_chip_size; + emu_jedec_ce_c7_size = emu_chip_size; + msg_pdbg("Emulating Winbond W25Q128FV SPI flash chip (RDID)\n"); + } #endif if (emu_chip == EMULATE_NONE) { msg_perr("Invalid chip specified for emulation: %s\n", tmp); @@ -474,6 +487,7 @@ const unsigned char sst25vf040_rems_response[2] = {0xbf, 0x44}; const unsigned char sst25vf032b_rems_response[2] = {0xbf, 0x4a}; const unsigned char mx25l6436_rems_response[2] = {0xc2, 0x16}; + const unsigned char w25q128fv_rems_response[2] = {0xef, 0x17}; if (writecnt == 0) { msg_perr("No command sent to the chip!\n"); @@ -532,6 +546,10 @@ if (readcnt > 0) memset(readarr, 0x16, readcnt); break; + case EMULATE_WINBOND_W25Q128FV: + if (readcnt > 0) + memset(readarr, 0x17, readcnt); + break; default: /* ignore */ break; } @@ -555,6 +573,10 @@ for (i = 0; i < readcnt; i++) readarr[i] = mx25l6436_rems_response[(offs + i) % 2]; break; + case EMULATE_WINBOND_W25Q128FV: + for (i = 0; i < readcnt; i++) + readarr[i] = w25q128fv_rems_response[(offs + i) % 2]; + break; default: /* ignore */ break; } @@ -577,6 +599,14 @@ if (readcnt > 2) readarr[2] = 0x17; break; + case EMULATE_WINBOND_W25Q128FV: + if (readcnt > 0) + readarr[0] = 0xef; + if (readcnt > 1) + readarr[1] = 0x40; + if (readcnt > 2) + readarr[2] = 0x18; + break; default: /* ignore */ break; } @@ -806,6 +836,7 @@ case EMULATE_SST_SST25VF040_REMS: case EMULATE_SST_SST25VF032B: case EMULATE_MACRONIX_MX25L6436: + case EMULATE_WINBOND_W25Q128FV: if (emulate_spi_chip_response(writecnt, readcnt, writearr, readarr)) { msg_pdbg("Invalid command sent to flash chip!\n"); -- To view, visit https://review.coreboot.org/c/flashrom/+/31011 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ic01d45c1f709808404ad53bb31f8b998c6977a9d Gerrit-Change-Number: 31011 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: newchange

3 4