April 2018 - flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: linux_mtd: Suppress message if NOR device not found
by build bot (Jenkins) (Code Review) April 16, 2018

April 16, 2018

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22503 ) Change subject: linux_mtd: Suppress message if NOR device not found ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom_gerrit/1044/ : SUCCESS https://qa.coreboot.org/job/flashrom-customrules/1256/ : SUCCESS -- To view, visit https://review.coreboot.org/22503 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I76d50847e6c4a431d30ad39bcd3994059679172d Gerrit-Change-Number: 22503 Gerrit-PatchSet: 2 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Shawn Nematbakhsh <shawnn(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 16 Apr 2018 05:46:07 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: Initial MTD support
by build bot (Jenkins) (Code Review) April 16, 2018

April 16, 2018

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22501 ) Change subject: Initial MTD support ...................................................................... Patch Set 2: Verified-1 Build Failed https://qa.coreboot.org/job/flashrom_gerrit/1043/ : FAILURE https://qa.coreboot.org/job/flashrom-customrules/1257/ : SUCCESS -- To view, visit https://review.coreboot.org/22501 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib3b8963874722ea80299e9298101409408d6c253 Gerrit-Change-Number: 22501 Gerrit-PatchSet: 2 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Shawn Nematbakhsh <shawnn(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 16 Apr 2018 05:46:01 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: linux_mtd: Fix compilation errors
by build bot (Jenkins) (Code Review) April 16, 2018

April 16, 2018

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22502 ) Change subject: linux_mtd: Fix compilation errors ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom_gerrit/1042/ : SUCCESS https://qa.coreboot.org/job/flashrom-customrules/1255/ : SUCCESS -- To view, visit https://review.coreboot.org/22502 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I216fab281f7a20a5819de3adf610b770a0b3d37c Gerrit-Change-Number: 22502 Gerrit-PatchSet: 2 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 16 Apr 2018 05:45:53 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: file: read in entire file (up to 4K) instead of stat()'ing for size
by build bot (Jenkins) (Code Review) April 16, 2018

April 16, 2018

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22494 ) Change subject: file: read in entire file (up to 4K) instead of stat()'ing for size ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom_gerrit/1040/ : SUCCESS https://qa.coreboot.org/job/flashrom-customrules/1253/ : SUCCESS -- To view, visit https://review.coreboot.org/22494 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2d053b18ba624f4ce3ebc1956b9e7945b693b0bc Gerrit-Change-Number: 22494 Gerrit-PatchSet: 3 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Brian Norris <briannorris(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 16 Apr 2018 05:45:43 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: linux_mtd: Support for NO_ERASE type devices
by David Hendricks (Code Review) April 16, 2018

April 16, 2018

David Hendricks has posted comments on this change. ( https://review.coreboot.org/22511 ) Change subject: linux_mtd: Support for NO_ERASE type devices ...................................................................... Patch Set 2: (1 comment) https://review.coreboot.org/#/c/22511/2/linux_mtd.c File linux_mtd.c: https://review.coreboot.org/#/c/22511/2/linux_mtd.c@187 PS2, Line 187: mtd_total_size / mtd_erasesize; This part was omitted from the earlier import. Once it was added, reads/writes worked again. -- To view, visit https://review.coreboot.org/22511 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4c2fc769a8e0865edf8507f6bd796dc3344b4226 Gerrit-Change-Number: 22511 Gerrit-PatchSet: 2 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Brian Norris <briannorris(a)chromium.org> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 16 Apr 2018 05:45:40 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in flashrom[master]: file: add new helper functions to grok FDT nodes
by build bot (Jenkins) (Code Review) April 16, 2018

April 16, 2018

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22493 ) Change subject: file: add new helper functions to grok FDT nodes ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom_gerrit/1041/ : SUCCESS https://qa.coreboot.org/job/flashrom-customrules/1254/ : SUCCESS -- To view, visit https://review.coreboot.org/22493 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1f771bcca61de71daa54e358e058723d3fd37079 Gerrit-Change-Number: 22493 Gerrit-PatchSet: 3 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Brian Norris <briannorris(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 16 Apr 2018 05:45:39 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: file: Re-implement file parsing function
by build bot (Jenkins) (Code Review) April 16, 2018

April 16, 2018

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22492 ) Change subject: file: Re-implement file parsing function ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom_gerrit/1039/ : SUCCESS https://qa.coreboot.org/job/flashrom-customrules/1252/ : SUCCESS -- To view, visit https://review.coreboot.org/22492 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6e3811acf352d85c3f43192f87388833a997dd2c Gerrit-Change-Number: 22492 Gerrit-PatchSet: 3 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Brian Norris <briannorris(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 16 Apr 2018 05:45:24 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: avoid unnecessary syscalls in scanft()
by build bot (Jenkins) (Code Review) April 16, 2018

April 16, 2018

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22491 ) Change subject: avoid unnecessary syscalls in scanft() ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom_gerrit/1037/ : SUCCESS https://qa.coreboot.org/job/flashrom-customrules/1250/ : SUCCESS -- To view, visit https://review.coreboot.org/22491 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib067cfda1ba3edbc0b1bba604fa5eb57c64501f2 Gerrit-Change-Number: 22491 Gerrit-PatchSet: 3 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 16 Apr 2018 05:45:19 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: Add a file utility library
by build bot (Jenkins) (Code Review) April 16, 2018

April 16, 2018

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22490 ) Change subject: Add a file utility library ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom_gerrit/1038/ : SUCCESS https://qa.coreboot.org/job/flashrom-customrules/1251/ : SUCCESS -- To view, visit https://review.coreboot.org/22490 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6c86ad3a50748e6bdbaa6675b05e75ef714b3994 Gerrit-Change-Number: 22490 Gerrit-PatchSet: 3 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Louis Yung-Chieh Lo <yjlou(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 16 Apr 2018 05:45:10 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: Initial MTD support
by David Hendricks (Code Review) April 16, 2018

April 16, 2018

Hello Shawn Nematbakhsh, Paul Menzel, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/22501 to look at the new patch set (#2). Change subject: Initial MTD support ...................................................................... Initial MTD support (This patch was ported from chromiumos @cebee89a) This adds MTD support to flashrom so that we can read, erase, and write content on a NOR flash chip via MTD. BUG=chrome-os-partner:40208 BRANCH=none TEST=read, write, and erase works on Oak Signed-off-by: David Hendricks <dhendrix(a)chromium.org> Change-Id: Ib3b8963874722ea80299e9298101409408d6c253 Reviewed-on: https://chromium-review.googlesource.com/272983 Reviewed-by: Shawn N <shawnn(a)chromium.org> --- M Makefile M flashrom.c M internal.c A linux_mtd.c M programmer.h 5 files changed, 417 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/01/22501/2 -- To view, visit https://review.coreboot.org/22501 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ib3b8963874722ea80299e9298101409408d6c253 Gerrit-Change-Number: 22501 Gerrit-PatchSet: 2 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Shawn Nematbakhsh <shawnn(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0