April 2018 - flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: Fix whitespace errors
by build bot (Jenkins) (Code Review) April 19, 2018

April 19, 2018

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25380 ) Change subject: Fix whitespace errors ...................................................................... Patch Set 4: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/1268/ : SUCCESS https://qa.coreboot.org/job/flashrom_gerrit/1055/ : SUCCESS -- To view, visit https://review.coreboot.org/25380 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic2d3bb9d8581a0471a8568a130f893b34dddf113 Gerrit-Change-Number: 25380 Gerrit-PatchSet: 4 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 19 Apr 2018 10:16:16 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: Fix whitespace errors
by Elyes HAOUAS (Code Review) April 19, 2018

April 19, 2018

Hello Paul Menzel, build bot (Jenkins), Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/25380 to look at the new patch set (#4). Change subject: Fix whitespace errors ...................................................................... Fix whitespace errors Change-Id: Ic2d3bb9d8581a0471a8568a130f893b34dddf113 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M board_enable.c M buspirate_spi.c M coreboot_tables.h M dediprog.c M flashchips.c M ichspi.c M pcidev.c M serprog.c 8 files changed, 13 insertions(+), 13 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/80/25380/4 -- To view, visit https://review.coreboot.org/25380 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ic2d3bb9d8581a0471a8568a130f893b34dddf113 Gerrit-Change-Number: 25380 Gerrit-PatchSet: 4 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[master]: Remove address from GPLv2 headers
by David Hendricks (Code Review) April 18, 2018

April 18, 2018

David Hendricks has posted comments on this change. ( https://review.coreboot.org/25381 ) Change subject: Remove address from GPLv2 headers ...................................................................... Patch Set 5: Code-Review+1 (2 comments) minor nits, otherwise LGTM https://review.coreboot.org/#/c/25381/5/buspirate_spi.c File buspirate_spi.c: https://review.coreboot.org/#/c/25381/5/buspirate_spi.c@660 PS5, Line 660: } Looks like one of your whitespace fixes crept in? https://review.coreboot.org/#/c/25381/5/coreboot_tables.h File coreboot_tables.h: https://review.coreboot.org/#/c/25381/5/coreboot_tables.h@28 PS5, Line 28: * All of the information should be Position Independent Data. I just noticed that this long comment has a few trailing whitespaces which you may want to address in 25380. -- To view, visit https://review.coreboot.org/25381 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7bfc339673cbf5ee2d2ff7564c4db04ca088d0a4 Gerrit-Change-Number: 25381 Gerrit-PatchSet: 5 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Wed, 18 Apr 2018 23:23:52 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: linux_mtd: Initial import
by Paul Menzel (Code Review) April 18, 2018

April 18, 2018

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/25706 ) Change subject: linux_mtd: Initial import ...................................................................... Patch Set 2: (1 comment) https://review.coreboot.org/#/c/25706/2//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/25706/2//COMMIT_MSG@7 PS2, Line 7: linux_mtd: Initial import Do initial import -- To view, visit https://review.coreboot.org/25706 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3d6bb282863a5cf69909e28a1fc752b35f1b9599 Gerrit-Change-Number: 25706 Gerrit-PatchSet: 2 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Wed, 18 Apr 2018 07:10:50 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in flashrom[master]: linux_mtd: make read/write loop chunks consistent, and documented
by David Hendricks (Code Review) April 18, 2018

April 18, 2018

David Hendricks has abandoned this change. ( https://review.coreboot.org/22512 ) Change subject: linux_mtd: make read/write loop chunks consistent, and documented ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/22512 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: I551bb85269c854f6888c6bfad8031b14fcf10273 Gerrit-Change-Number: 22512 Gerrit-PatchSet: 2 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Brian Norris <briannorris(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[master]: mtd: print a hint for users when lock/unlock fails
by David Hendricks (Code Review) April 18, 2018

April 18, 2018

David Hendricks has abandoned this change. ( https://review.coreboot.org/22510 ) Change subject: mtd: print a hint for users when lock/unlock fails ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/22510 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: I4fe40c88da2faad9a9df40da9f9df216ed5119af Gerrit-Change-Number: 22510 Gerrit-PatchSet: 2 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Brian Norris <briannorris(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[master]: linux_mtd: Support for NO_ERASE type devices
by David Hendricks (Code Review) April 18, 2018

April 18, 2018

David Hendricks has abandoned this change. ( https://review.coreboot.org/22511 ) Change subject: linux_mtd: Support for NO_ERASE type devices ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/22511 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: I4c2fc769a8e0865edf8507f6bd796dc3344b4226 Gerrit-Change-Number: 22511 Gerrit-PatchSet: 2 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Brian Norris <briannorris(a)chromium.org> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[master]: linux_mtd: print correct wp-status info when whole flash is locked
by David Hendricks (Code Review) April 18, 2018

April 18, 2018

David Hendricks has abandoned this change. ( https://review.coreboot.org/22509 ) Change subject: linux_mtd: print correct wp-status info when whole flash is locked ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/22509 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: I0cb1cba321a831f02037fc228ee35aab36de4d4e Gerrit-Change-Number: 22509 Gerrit-PatchSet: 2 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Brian Norris <briannorris(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[master]: linux_mtd: do reads in eraseblock-sized chunks
by David Hendricks (Code Review) April 18, 2018

April 18, 2018

David Hendricks has abandoned this change. ( https://review.coreboot.org/22508 ) Change subject: linux_mtd: do reads in eraseblock-sized chunks ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/22508 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: I3a8e160795cd24ec1851c00394892536a2a9d0c7 Gerrit-Change-Number: 22508 Gerrit-PatchSet: 2 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Brian Norris <briannorris(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[master]: linux_mtd: display correct write-protect info
by David Hendricks (Code Review) April 18, 2018

April 18, 2018

David Hendricks has abandoned this change. ( https://review.coreboot.org/22507 ) Change subject: linux_mtd: display correct write-protect info ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/22507 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: Icc3727702d2813b875a7e3a7151b44a7853967bd Gerrit-Change-Number: 22507 Gerrit-PatchSet: 2 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0