March 2018 - flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: flashchips: Add Microchip SST26VF016B
by build bot (Jenkins) (Code Review) March 31, 2018

March 31, 2018

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25465 ) Change subject: flashchips: Add Microchip SST26VF016B ...................................................................... Patch Set 3: Verified-1 Build Failed https://qa.coreboot.org/job/flashrom_gerrit/1028/ : FAILURE https://qa.coreboot.org/job/flashrom-customrules/1240/ : SUCCESS -- To view, visit https://review.coreboot.org/25465 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia7659e3db3168254b7f34959eece0f8df3142ab9 Gerrit-Change-Number: 25465 Gerrit-PatchSet: 3 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 31 Mar 2018 11:13:05 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: flashchips: Add Microchip SST26VF016B
by Nico Huber (Code Review) March 31, 2018

March 31, 2018

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/25465 to look at the new patch set (#3). Change subject: flashchips: Add Microchip SST26VF016B ...................................................................... flashchips: Add Microchip SST26VF016B Change-Id: Ia7659e3db3168254b7f34959eece0f8df3142ab9 Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M flashchips.c M flashchips.h 2 files changed, 38 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/65/25465/3 -- To view, visit https://review.coreboot.org/25465 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ia7659e3db3168254b7f34959eece0f8df3142ab9 Gerrit-Change-Number: 25465 Gerrit-PatchSet: 3 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[master]: flashchips: Add Microchip SST26VF016B
by build bot (Jenkins) (Code Review) March 31, 2018

March 31, 2018

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25465 ) Change subject: flashchips: Add Microchip SST26VF016B ...................................................................... Patch Set 2: Verified-1 Build Failed https://qa.coreboot.org/job/flashrom_gerrit/1027/ : FAILURE https://qa.coreboot.org/job/flashrom-customrules/1239/ : SUCCESS -- To view, visit https://review.coreboot.org/25465 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia7659e3db3168254b7f34959eece0f8df3142ab9 Gerrit-Change-Number: 25465 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 31 Mar 2018 11:08:05 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: flashchips: Add Microchip SST26VF016B
by Nico Huber (Code Review) March 31, 2018

March 31, 2018

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/25465 to look at the new patch set (#2). Change subject: flashchips: Add Microchip SST26VF016B ...................................................................... flashchips: Add Microchip SST26VF016B Change-Id: Ia7659e3db3168254b7f34959eece0f8df3142ab9 Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M flashchips.c 1 file changed, 37 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/65/25465/2 -- To view, visit https://review.coreboot.org/25465 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ia7659e3db3168254b7f34959eece0f8df3142ab9 Gerrit-Change-Number: 25465 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[master]: flashchips: Add Microchip SST26VF016B
by build bot (Jenkins) (Code Review) March 31, 2018

March 31, 2018

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25465 ) Change subject: flashchips: Add Microchip SST26VF016B ...................................................................... Patch Set 1: Verified-1 Build Failed https://qa.coreboot.org/job/flashrom_gerrit/1026/ : FAILURE https://qa.coreboot.org/job/flashrom-customrules/1238/ : SUCCESS -- To view, visit https://review.coreboot.org/25465 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia7659e3db3168254b7f34959eece0f8df3142ab9 Gerrit-Change-Number: 25465 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 31 Mar 2018 11:03:05 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: flashchips: Add Microchip SST26VF016B
by Nico Huber (Code Review) March 31, 2018

March 31, 2018

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/25465 Change subject: flashchips: Add Microchip SST26VF016B ...................................................................... flashchips: Add Microchip SST26VF016B Change-Id: Ia7659e3db3168254b7f34959eece0f8df3142ab9 Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M flashchips.c 1 file changed, 38 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/65/25465/1 diff --git a/flashchips.c b/flashchips.c index 5a8e606..3dfe20c 100644 --- a/flashchips.c +++ b/flashchips.c @@ -13106,6 +13106,44 @@ { .vendor = "SST", + .name = "SST26VF016B", + .bustype = BUS_SPI, + .manufacture_id = SST_ID, + .model_id = SST_SST26VF016B, + .total_size = 2048, + .page_size = 256, + /* supports SFDP */ + /* OTP: 2KiB total */ + .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP, + .tested = TEST_UNTESTED, + .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, + .block_erasers = + { + { + .eraseblocks = { {4 * 1024, 512} }, + .block_erase = spi_block_erase_20, + }, { + .eraseblocks = { { 8 * 1024, 4}, + {32 * 1024, 1}, + {64 * 1024, 30}, + {32 * 1024, 1}, + { 8 * 1024, 4} }, + .block_erase = spi_block_erase_d8, + }, { + .eraseblocks = { {2 * 1024 * 1024, 1} }, + .block_erase = spi_block_erase_c7, + }, + }, + .printlock = spi_prettyprint_status_register_plain, + .unlock = spi_disable_blockprotect, + .write = spi_chip_write_256, + .read = spi_chip_read, + .voltage = {2300, 3600}, /* 2.3V - 3.6V: max. 80MHz, 2.7V - 3.6V: max. 104MHz */ + }, + + { + .vendor = "SST", .name = "SST28SF040A", .bustype = BUS_PARALLEL, .manufacture_id = SST_ID, -- To view, visit https://review.coreboot.org/25465 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ia7659e3db3168254b7f34959eece0f8df3142ab9 Gerrit-Change-Number: 25465 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>

1 0

Change in flashrom[master]: flashchips: Add Winbond 25Q40EW and rename 25Q40.W
by build bot (Jenkins) (Code Review) March 30, 2018

March 30, 2018

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25462 ) Change subject: flashchips: Add Winbond 25Q40EW and rename 25Q40.W ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/1237/ : SUCCESS -- To view, visit https://review.coreboot.org/25462 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib610b0d6f3a5561b2ac3505ef15bdee8b0edae25 Gerrit-Change-Number: 25462 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 30 Mar 2018 13:15:08 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: flashchips: Add Winbond 25Q40EW and rename 25Q40.W
by Nico Huber (Code Review) March 30, 2018

March 30, 2018

Hello David Hendricks, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/25462 to look at the new patch set (#2). Change subject: flashchips: Add Winbond 25Q40EW and rename 25Q40.W ...................................................................... flashchips: Add Winbond 25Q40EW and rename 25Q40.W Same story as for 25Q80BW/EW, 25Q40EW has a new ID and the only known chip with the old ID is the BW variant. Change-Id: Ib610b0d6f3a5561b2ac3505ef15bdee8b0edae25 Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M flashchips.c M flashchips.h 2 files changed, 44 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/62/25462/2 -- To view, visit https://review.coreboot.org/25462 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ib610b0d6f3a5561b2ac3505ef15bdee8b0edae25 Gerrit-Change-Number: 25462 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[master]: flashchips: Add Windbond 25Q40EW and rename 25Q40.W
by build bot (Jenkins) (Code Review) March 30, 2018

March 30, 2018

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25462 ) Change subject: flashchips: Add Windbond 25Q40EW and rename 25Q40.W ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/1236/ : SUCCESS https://qa.coreboot.org/job/flashrom_gerrit/1025/ : SUCCESS -- To view, visit https://review.coreboot.org/25462 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib610b0d6f3a5561b2ac3505ef15bdee8b0edae25 Gerrit-Change-Number: 25462 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 30 Mar 2018 11:53:41 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: flashchips: Add Windbond 25Q40EW and rename 25Q40.W
by Nico Huber (Code Review) March 30, 2018

March 30, 2018

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/25462 Change subject: flashchips: Add Windbond 25Q40EW and rename 25Q40.W ...................................................................... flashchips: Add Windbond 25Q40EW and rename 25Q40.W Same story as for 25Q80BW/EW, 25Q40EW has a new ID and the only known chip with the old ID is the BW variant. Change-Id: Ib610b0d6f3a5561b2ac3505ef15bdee8b0edae25 Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M flashchips.c M flashchips.h 2 files changed, 44 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/62/25462/1 diff --git a/flashchips.c b/flashchips.c index 70057d4..5a8e606 100644 --- a/flashchips.c +++ b/flashchips.c @@ -15027,10 +15027,10 @@ { .vendor = "Winbond", - .name = "W25Q40.W", + .name = "W25Q40BW", .bustype = BUS_SPI, .manufacture_id = WINBOND_NEX_ID, - .model_id = WINBOND_NEX_W25Q40_W, + .model_id = WINBOND_NEX_W25Q40BW, .total_size = 512, .page_size = 256, /* OTP: 256B total; read 0x48; write 0x42, erase 0x44, read ID 0x4B */ @@ -15102,6 +15102,46 @@ .read = spi_chip_read, .voltage = {1700, 1950}, /* Fast read (0x0B) and multi I/O supported */ }, + + { + .vendor = "Winbond", + .name = "W25Q40EW", + .bustype = BUS_SPI, + .manufacture_id = WINBOND_NEX_ID, + .model_id = WINBOND_NEX_W25Q40EW, + .total_size = 512, + .page_size = 256, + /* OTP: 3*256B total; read 0x48; write 0x42, erase 0x44, read ID 0x4B */ + .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP, + .tested = TEST_UNTESTED, + .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, + .block_erasers = + { + { + .eraseblocks = { {4 * 1024, 128} }, + .block_erase = spi_block_erase_20, + }, { + .eraseblocks = { {32 * 1024, 16} }, + .block_erase = spi_block_erase_52, + }, { + .eraseblocks = { {64 * 1024, 8} }, + .block_erase = spi_block_erase_d8, + }, { + .eraseblocks = { {512 * 1024, 1} }, + .block_erase = spi_block_erase_60, + }, { + .eraseblocks = { {512 * 1024, 1} }, + .block_erase = spi_block_erase_c7, + } + }, + .printlock = spi_prettyprint_status_register_plain, /* TODO: improve */ + .unlock = spi_disable_blockprotect, + .write = spi_chip_write_256, + .read = spi_chip_read, + .voltage = {1650, 1950}, /* Fast read (0x0B) and multi I/O supported */ + }, + { .vendor = "Winbond", .name = "W25Q80EW", diff --git a/flashchips.h b/flashchips.h index 68a67fa..1bd2c92 100644 --- a/flashchips.h +++ b/flashchips.h @@ -910,8 +910,9 @@ #define WINBOND_NEX_W25Q128_V 0x4018 /* W25Q128BV; W25Q128FV in SPI mode (default) */ #define WINBOND_NEX_W25Q256_V 0x4019 /* W25Q256FV */ #define WINBOND_NEX_W25Q20_W 0x5012 /* W25Q20BW */ -#define WINBOND_NEX_W25Q40_W 0x5013 /* W25Q40BW */ +#define WINBOND_NEX_W25Q40BW 0x5013 /* W25Q40BW */ #define WINBOND_NEX_W25Q80BW 0x5014 /* W25Q80BW */ +#define WINBOND_NEX_W25Q40EW 0x6013 /* W25Q40EW */ #define WINBOND_NEX_W25Q80EW 0x6014 /* W25Q80EW */ #define WINBOND_NEX_W25Q16_W 0x6015 /* W25Q16DW */ #define WINBOND_NEX_W25Q32_W 0x6016 /* W25Q32DW; W25Q32FV in QPI mode */ -- To view, visit https://review.coreboot.org/25462 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ib610b0d6f3a5561b2ac3505ef15bdee8b0edae25 Gerrit-Change-Number: 25462 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>

1 0