August 2017 - flashrom-gerrit - mail.coreboot.org

Change in flashrom[staging]: layout: Add a function to check if numeric range is included
by build bot (Jenkins) (Code Review) Aug. 6, 2017

Aug. 6, 2017

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20569 ) Change subject: layout: Add a function to check if numeric range is included ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom_gerrit/462/ : SUCCESS https://qa.coreboot.org/job/flashrom-customrules/499/ : SUCCESS -- To view, visit https://review.coreboot.org/20569 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: I096410ea957fe204affa67734e7589a6e4424a26 Gerrit-Change-Number: 20569 Gerrit-PatchSet: 3 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 05 Aug 2017 23:35:31 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[staging]: rpci: Use pci_dev struct pointer to avoid API breaks
by build bot (Jenkins) (Code Review) Aug. 5, 2017

Aug. 5, 2017

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20784 ) Change subject: rpci: Use pci_dev struct pointer to avoid API breaks ...................................................................... Patch Set 4: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom_gerrit/461/ : SUCCESS https://qa.coreboot.org/job/flashrom-customrules/498/ : SUCCESS -- To view, visit https://review.coreboot.org/20784 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: Icde2e587992ba964d4ff92c33aa659850ba06298 Gerrit-Change-Number: 20784 Gerrit-PatchSet: 4 Gerrit-Owner: Youness Alaoui <snifikino(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Youness Alaoui <snifikino(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 04 Aug 2017 22:54:04 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[staging]: rpci: Use pci_dev struct pointer to avoid API breaks
by Youness Alaoui (Code Review) Aug. 5, 2017

Aug. 5, 2017

Hello David Hendricks, Paul Menzel, build bot (Jenkins), Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/20784 to look at the new patch set (#4). Change subject: rpci: Use pci_dev struct pointer to avoid API breaks ...................................................................... rpci: Use pci_dev struct pointer to avoid API breaks The pci_dev structure is never meant to be used as is, but always as a pointer. By using the struct itself in undo_pci_write_data, we are risking data corruption, or buffer overflows if the structure size changes. This is especially apparent on my system where flashrom segfaults because I compile it with pciutils 3.3.0 and I run it on a system with pciutils 3.5.2. The struture size is different and causes a struct with the wrong size to be sent to the library, with invalid internal field values. This has been discovered and discussed in Change ID 18925 [1] [1] https://review.coreboot.org/#/c/18925/ Change-Id: Icde2e587992ba964d4ff92c33aa659850ba06298 Signed-off-by: Youness Alaoui <kakaroto(a)kakaroto.homelinux.net> --- M chipset_enable.c M pcidev.c M programmer.h 3 files changed, 25 insertions(+), 9 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/84/20784/4 -- To view, visit https://review.coreboot.org/20784 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: newpatchset Gerrit-Change-Id: Icde2e587992ba964d4ff92c33aa659850ba06298 Gerrit-Change-Number: 20784 Gerrit-PatchSet: 4 Gerrit-Owner: Youness Alaoui <snifikino(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Youness Alaoui <snifikino(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[staging]: 4BA: Print power-up addressing mode for N25Q SPI flash chips
by build bot (Jenkins) (Code Review) Aug. 1, 2017

Aug. 1, 2017

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20512 ) Change subject: 4BA: Print power-up addressing mode for N25Q SPI flash chips ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom_gerrit/460/ : SUCCESS https://qa.coreboot.org/job/flashrom-customrules/496/ : SUCCESS -- To view, visit https://review.coreboot.org/20512 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: I95f1a8182dd15ca024bbee2b6f7b0dad0d8dd8b3 Gerrit-Change-Number: 20512 Gerrit-PatchSet: 3 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Ed Swierk <eswierk(a)skyportsystems.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 01 Aug 2017 07:08:05 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[staging]: 4BA: Add Micron N25Q/MT25QL 32MB and 64MB 3V SPI flash
by build bot (Jenkins) (Code Review) Aug. 1, 2017

Aug. 1, 2017

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20511 ) Change subject: 4BA: Add Micron N25Q/MT25QL 32MB and 64MB 3V SPI flash ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom_gerrit/459/ : SUCCESS https://qa.coreboot.org/job/flashrom-customrules/497/ : SUCCESS -- To view, visit https://review.coreboot.org/20511 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: I3c130c5ecf4bcc7cf3b34257cb5fc3df523ce08b Gerrit-Change-Number: 20511 Gerrit-PatchSet: 3 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Ed Swierk <eswierk(a)skyportsystems.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 01 Aug 2017 07:07:57 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[staging]: 4BA: Allow disabling 4-byte address mode for SPI flash
by build bot (Jenkins) (Code Review) Aug. 1, 2017

Aug. 1, 2017

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20510 ) Change subject: 4BA: Allow disabling 4-byte address mode for SPI flash ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom_gerrit/458/ : SUCCESS https://qa.coreboot.org/job/flashrom-customrules/495/ : SUCCESS -- To view, visit https://review.coreboot.org/20510 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: I0b25309d731426940fc50956b744b681ab599e87 Gerrit-Change-Number: 20510 Gerrit-PatchSet: 3 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Ed Swierk <eswierk(a)skyportsystems.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 01 Aug 2017 07:07:49 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[staging]: 4BA: Support for new direct-4BA instructions + W25Q256.V update
by build bot (Jenkins) (Code Review) Aug. 1, 2017

Aug. 1, 2017

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20508 ) Change subject: 4BA: Support for new direct-4BA instructions + W25Q256.V update ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom_gerrit/455/ : SUCCESS https://qa.coreboot.org/job/flashrom-customrules/494/ : SUCCESS -- To view, visit https://review.coreboot.org/20508 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: Ib51bcc5de7826b30ad697fcbb9a5152bde2c2ac9 Gerrit-Change-Number: 20508 Gerrit-PatchSet: 3 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 01 Aug 2017 07:07:45 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[staging]: 4BA: Support for 4-bytes addressing via Extended Address Register
by build bot (Jenkins) (Code Review) Aug. 1, 2017

Aug. 1, 2017

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20507 ) Change subject: 4BA: Support for 4-bytes addressing via Extended Address Register ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom_gerrit/456/ : SUCCESS https://qa.coreboot.org/job/flashrom-customrules/492/ : SUCCESS -- To view, visit https://review.coreboot.org/20507 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: I09a8aa11de2ca14901f142c67c83c4fa0def4e27 Gerrit-Change-Number: 20507 Gerrit-PatchSet: 3 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 01 Aug 2017 07:07:44 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[staging]: 4BA: Winbond W25Q256.V chip (32MB) declaration, 4-bytes addr mode
by build bot (Jenkins) (Code Review) Aug. 1, 2017

Aug. 1, 2017

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20506 ) Change subject: 4BA: Winbond W25Q256.V chip (32MB) declaration, 4-bytes addr mode ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom_gerrit/454/ : SUCCESS https://qa.coreboot.org/job/flashrom-customrules/490/ : SUCCESS -- To view, visit https://review.coreboot.org/20506 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: I90226f453f8147ae5ac7dbbef7549ee3bfacc3d6 Gerrit-Change-Number: 20506 Gerrit-PatchSet: 3 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <f4bug(a)amsat.org> Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 01 Aug 2017 07:07:43 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[staging]: 4BA: Add spi_exit_4ba function to switch SPI flash to 3-byte addressing
by build bot (Jenkins) (Code Review) Aug. 1, 2017

Aug. 1, 2017

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20509 ) Change subject: 4BA: Add spi_exit_4ba function to switch SPI flash to 3-byte addressing ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom_gerrit/457/ : SUCCESS https://qa.coreboot.org/job/flashrom-customrules/493/ : SUCCESS -- To view, visit https://review.coreboot.org/20509 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: I553e7fb5028f35e14a3a81b3fa8903c1b321a223 Gerrit-Change-Number: 20509 Gerrit-PatchSet: 3 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Ed Swierk <eswierk(a)skyportsystems.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 01 Aug 2017 07:07:39 +0000 Gerrit-HasComments: No

1 0