August 2017 - flashrom-gerrit - mail.coreboot.org

Change in flashrom[staging]: chipset_enable: Mark Braswell as tested
by Paul Menzel (Code Review) Aug. 9, 2017

Aug. 9, 2017

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/20923 ) Change subject: chipset_enable: Mark Braswell as tested ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/20923 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: Iaf7558af8737af36401f577ca7aba9fd7114a3df Gerrit-Change-Number: 20923 Gerrit-PatchSet: 1 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Comment-Date: Wed, 09 Aug 2017 06:57:54 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[staging]: chipset_enable: Mark Braswell as tested
by David Hendricks (Code Review) Aug. 9, 2017

Aug. 9, 2017

David Hendricks has removed Stefan Tauner from this change. ( https://review.coreboot.org/20923 ) Change subject: chipset_enable: Mark Braswell as tested ...................................................................... Removed reviewer Stefan Tauner. -- To view, visit https://review.coreboot.org/20923 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: deleteReviewer Gerrit-Change-Id: Iaf7558af8737af36401f577ca7aba9fd7114a3df Gerrit-Change-Number: 20923 Gerrit-PatchSet: 1 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com>

1 0

Change in flashrom[staging]: chipset_enable: Mark Braswell as tested
by David Hendricks (Code Review) Aug. 9, 2017

Aug. 9, 2017

David Hendricks has uploaded this change for review. ( https://review.coreboot.org/20923 Change subject: chipset_enable: Mark Braswell as tested ...................................................................... chipset_enable: Mark Braswell as tested Reported by Uwe Vieweg: https://mail.coreboot.org/pipermail/flashrom/2017-August/015059.html Change-Id: Iaf7558af8737af36401f577ca7aba9fd7114a3df Signed-off-by: David Hendricks <david.hendricks(a)gmail.com> --- M chipset_enable.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/23/20923/1 diff --git a/chipset_enable.c b/chipset_enable.c index 20d2662..50fbdb0 100644 --- a/chipset_enable.c +++ b/chipset_enable.c @@ -1735,7 +1735,7 @@ {0x8086, 0x1f39, NT, "Intel", "Avoton/Rangeley", enable_flash_silvermont}, {0x8086, 0x1f3a, NT, "Intel", "Avoton/Rangeley", enable_flash_silvermont}, {0x8086, 0x1f3b, NT, "Intel", "Avoton/Rangeley", enable_flash_silvermont}, - {0x8086, 0x229c, NT, "Intel", "Braswell", enable_flash_silvermont}, + {0x8086, 0x229c, OK, "Intel", "Braswell", enable_flash_silvermont}, {0x8086, 0x2310, NT, "Intel", "DH89xxCC (Cave Creek)", enable_flash_pch7}, {0x8086, 0x2390, NT, "Intel", "Coleto Creek", enable_flash_pch7}, {0x8086, 0x2410, OK, "Intel", "ICH", enable_flash_ich0}, -- To view, visit https://review.coreboot.org/20923 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: newchange Gerrit-Change-Id: Iaf7558af8737af36401f577ca7aba9fd7114a3df Gerrit-Change-Number: 20923 Gerrit-PatchSet: 1 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com>

1 0

Change in flashrom[staging]: chispet_enable: Add PCI IDs for C620-series PCHs
by David Hendricks (Code Review) Aug. 9, 2017

Aug. 9, 2017

David Hendricks has posted comments on this change. ( https://review.coreboot.org/20922 ) Change subject: chispet_enable: Add PCI IDs for C620-series PCHs ...................................................................... Patch Set 1: Datasheet: https://www.intel.com/content/www/us/en/chipsets/c620-series-chipset-datash… (table 2-1) -- To view, visit https://review.coreboot.org/20922 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: I96c89bc28bdfcd953229c17679f2c28f8b874d0b Gerrit-Change-Number: 20922 Gerrit-PatchSet: 1 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Comment-Date: Wed, 09 Aug 2017 04:01:32 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[staging]: chispet_enable: Add PCI IDs for C620-series PCHs
by David Hendricks (Code Review) Aug. 9, 2017

Aug. 9, 2017

David Hendricks has uploaded this change for review. ( https://review.coreboot.org/20922 Change subject: chispet_enable: Add PCI IDs for C620-series PCHs ...................................................................... chispet_enable: Add PCI IDs for C620-series PCHs Marked as untested for now. Change-Id: I96c89bc28bdfcd953229c17679f2c28f8b874d0b Signed-off-by: David Hendricks <dhendricks(a)fb.com> --- M chipset_enable.c 1 file changed, 12 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/22/20922/1 diff --git a/chipset_enable.c b/chipset_enable.c index 20d2662..a7ad97f 100644 --- a/chipset_enable.c +++ b/chipset_enable.c @@ -1910,6 +1910,18 @@ {0x8086, 0xa153, NT, "Intel", "QM175", enable_flash_pch100}, {0x8086, 0xa154, NT, "Intel", "CM238", enable_flash_pch100}, {0x8086, 0xa155, NT, "Intel", "QMU185", enable_flash_pch100}, + {0x8086, 0xa1c1, NT, "Intel", "C621 Series Chipset (QS/PRQ)", enable_flash_pch100}, + {0x8086, 0xa1c2, NT, "Intel", "C622 Series Chipset (QS/PRQ)", enable_flash_pch100}, + {0x8086, 0xa1c3, NT, "Intel", "C624 Series Chipset (QS/PRQ)", enable_flash_pch100}, + {0x8086, 0xa1c4, NT, "Intel", "C625 Series Chipset (QS/PRQ)", enable_flash_pch100}, + {0x8086, 0xa1c5, NT, "Intel", "C626 Series Chipset (QS/PRQ)", enable_flash_pch100}, + {0x8086, 0xa1c6, NT, "Intel", "C627 Series Chipset (QS/PRQ)", enable_flash_pch100}, + {0x8086, 0xa1c7, NT, "Intel", "C628 Series Chipset (QS/PRQ)", enable_flash_pch100}, + {0x8086, 0xa242, NT, "Intel", "C624 Series Chipset Supersku", enable_flash_pch100}, + {0x8086, 0xa243, NT, "Intel", "C627 Series Chipset Supersku", enable_flash_pch100}, + {0x8086, 0xa244, NT, "Intel", "C621 Series Chipset Supersku", enable_flash_pch100}, + {0x8086, 0xa245, NT, "Intel", "C627 Series Chipset Supersku", enable_flash_pch100}, + {0x8086, 0xa246, NT, "Intel", "C628 Series Chipset Supersku", enable_flash_pch100}, #endif {0}, }; -- To view, visit https://review.coreboot.org/20922 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: newchange Gerrit-Change-Id: I96c89bc28bdfcd953229c17679f2c28f8b874d0b Gerrit-Change-Number: 20922 Gerrit-PatchSet: 1 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com>

1 0

Change in flashrom[staging]: rpci: Use pci_dev struct pointer to avoid API breaks
by Youness Alaoui (Code Review) Aug. 8, 2017

Aug. 8, 2017

Youness Alaoui has posted comments on this change. ( https://review.coreboot.org/20784 ) Change subject: rpci: Use pci_dev struct pointer to avoid API breaks ...................................................................... Patch Set 4: > Sorry for stalling. Now, the discussed `pacc` acrobatic in > chipset_enable.c should be added here. It's done, I wasn't sure if I needed any more details in the comment for why the acrobatic had to be done, but I think it's fine as is. -- To view, visit https://review.coreboot.org/20784 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: Icde2e587992ba964d4ff92c33aa659850ba06298 Gerrit-Change-Number: 20784 Gerrit-PatchSet: 4 Gerrit-Owner: Youness Alaoui <snifikino(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Youness Alaoui <snifikino(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 08 Aug 2017 17:14:54 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[staging]: layout: Add a function to check if numeric range is included
by build bot (Jenkins) (Code Review) Aug. 5, 2017

Aug. 5, 2017

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20569 ) Change subject: layout: Add a function to check if numeric range is included ...................................................................... Patch Set 5: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/501/ : SUCCESS -- To view, visit https://review.coreboot.org/20569 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: I096410ea957fe204affa67734e7589a6e4424a26 Gerrit-Change-Number: 20569 Gerrit-PatchSet: 5 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 05 Aug 2017 23:40:38 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[staging]: layout: Add a function to check if numeric range is included
by David Hendricks (Code Review) Aug. 5, 2017

Aug. 5, 2017

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/20569 to look at the new patch set (#5). Change subject: layout: Add a function to check if numeric range is included ...................................................................... layout: Add a function to check if numeric range is included This adds a helper function to iterate thru ranges to check if a specified numeric range is marked as included in the layout. If no include (-i) arguments were used then any range will return true. Change-Id: I096410ea957fe204affa67734e7589a6e4424a26 Signed-off-by: David Hendricks <dhendricks(a)fb.com> --- M layout.c M layout.h 2 files changed, 26 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/69/20569/5 -- To view, visit https://review.coreboot.org/20569 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: newpatchset Gerrit-Change-Id: I096410ea957fe204affa67734e7589a6e4424a26 Gerrit-Change-Number: 20569 Gerrit-PatchSet: 5 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[staging]: layout: Add a function to check if numeric range is included
by build bot (Jenkins) (Code Review) Aug. 5, 2017

Aug. 5, 2017

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20569 ) Change subject: layout: Add a function to check if numeric range is included ...................................................................... Patch Set 4: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom_gerrit/463/ : SUCCESS https://qa.coreboot.org/job/flashrom-customrules/500/ : SUCCESS -- To view, visit https://review.coreboot.org/20569 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: I096410ea957fe204affa67734e7589a6e4424a26 Gerrit-Change-Number: 20569 Gerrit-PatchSet: 4 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 05 Aug 2017 23:38:40 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[staging]: layout: Add a function to check if numeric range is included
by David Hendricks (Code Review) Aug. 5, 2017

Aug. 5, 2017

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/20569 to look at the new patch set (#4). Change subject: layout: Add a function to check if numeric range is included ...................................................................... layout: Add a function to check if numeric range is included This adds a helper function to iterate thru ranges to check if a specified numeric range is marked as included in the layout. If no include -i arguments were used to specify included regions, then any range will return true. Change-Id: I096410ea957fe204affa67734e7589a6e4424a26 Signed-off-by: David Hendricks <dhendricks(a)fb.com> --- M layout.c M layout.h 2 files changed, 26 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/69/20569/4 -- To view, visit https://review.coreboot.org/20569 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: newpatchset Gerrit-Change-Id: I096410ea957fe204affa67734e7589a6e4424a26 Gerrit-Change-Number: 20569 Gerrit-PatchSet: 4 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0