August 2017 - flashrom-gerrit - mail.coreboot.org

Change in flashrom[staging]: chispet_enable: Add support for C620-series Lewisburg PCH
by David Hendricks (Code Review) Aug. 18, 2017

Aug. 18, 2017

David Hendricks has posted comments on this change. ( https://review.coreboot.org/20922 ) Change subject: chispet_enable: Add support for C620-series Lewisburg PCH ...................................................................... Patch Set 2: (1 comment) https://review.coreboot.org/#/c/20922/2/ichspi.c File ichspi.c: https://review.coreboot.org/#/c/20922/2/ichspi.c@1704 PS2, Line 1704: 6; /* FIXME: should be 5? */ num_pr = 6 seemed wrong for both Sunrise Point and Lewisburg, but maybe I am missing something... -- To view, visit https://review.coreboot.org/20922 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: I96c89bc28bdfcd953229c17679f2c28f8b874d0b Gerrit-Change-Number: 20922 Gerrit-PatchSet: 2 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 19 Aug 2017 03:15:59 +0000 Gerrit-HasComments: Yes

1 0

Change in flashrom[staging]: chispet_enable: Add support for C620-series Lewisburg PCH
by build bot (Jenkins) (Code Review) Aug. 18, 2017

Aug. 18, 2017

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20922 ) Change subject: chispet_enable: Add support for C620-series Lewisburg PCH ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/515/ : SUCCESS https://qa.coreboot.org/job/flashrom_gerrit/473/ : SUCCESS -- To view, visit https://review.coreboot.org/20922 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: I96c89bc28bdfcd953229c17679f2c28f8b874d0b Gerrit-Change-Number: 20922 Gerrit-PatchSet: 2 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 19 Aug 2017 03:14:42 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[staging]: chispet_enable: Add support for C620-series Lewisburg PCH
by David Hendricks (Code Review) Aug. 18, 2017

Aug. 18, 2017

Hello Paul Menzel, build bot (Jenkins), Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/20922 to look at the new patch set (#2). Change subject: chispet_enable: Add support for C620-series Lewisburg PCH ...................................................................... chispet_enable: Add support for C620-series Lewisburg PCH This adds PCI IDs for C620-series PCHs and adds CHIPSET_C620_SERIES_LEWISBURG as a new entry in the ich_chipset list. Lewisburg is very similar to Sunrise Point for Flashrom's purposes, however one important difference is the way the "number of masters" is interpreted from the flash descriptor (0-based vs. 1-based). Change-Id: I96c89bc28bdfcd953229c17679f2c28f8b874d0b Signed-off-by: David Hendricks <dhendricks(a)fb.com> --- M chipset_enable.c M ich_descriptors.c M ichspi.c M programmer.h M util/ich_descriptors_tool/ich_descriptors_tool.c 5 files changed, 81 insertions(+), 20 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/22/20922/2 -- To view, visit https://review.coreboot.org/20922 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: newpatchset Gerrit-Change-Id: I96c89bc28bdfcd953229c17679f2c28f8b874d0b Gerrit-Change-Number: 20922 Gerrit-PatchSet: 2 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[refs/meta/config]: Refine rights to create/delete any branches
by Patrick Georgi (Code Review) Aug. 18, 2017

Aug. 18, 2017

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/21090 ) Change subject: Refine rights to create/delete any branches ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/21090 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: refs/meta/config Gerrit-MessageType: comment Gerrit-Change-Id: Ia8ad1dc3dcdb6e35bfb47cbe437f2f7ea1cc560b Gerrit-Change-Number: 21090 Gerrit-PatchSet: 1 Gerrit-Owner: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 18 Aug 2017 11:47:01 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[refs/meta/config]: Refine rights to create/delete any branches
by Stefan Tauner (Code Review) Aug. 18, 2017

Aug. 18, 2017

Stefan Tauner has abandoned this change. ( https://review.coreboot.org/21089 ) Change subject: Refine rights to create/delete any branches ...................................................................... Abandoned webkacke. -- To view, visit https://review.coreboot.org/21089 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: refs/meta/config Gerrit-MessageType: abandon Gerrit-Change-Id: Iee7ced1353cf354f5284281929f4d4a4095ab0fe Gerrit-Change-Number: 21089 Gerrit-PatchSet: 1 Gerrit-Owner: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[refs/meta/config]: Refine rights to create/delete any branches
by Stefan Tauner (Code Review) Aug. 18, 2017

Aug. 18, 2017

Stefan Tauner has posted comments on this change. ( https://review.coreboot.org/21090 ) Change subject: Refine rights to create/delete any branches ...................................................................... Patch Set 1: Verified+1 (1 comment) Shouldnt reduce anybody's rights I think so Ill bluntly submit, if I can... :) https://review.coreboot.org/#/c/21090/1/project.config File project.config: https://review.coreboot.org/#/c/21090/1/project.config@33 PS1, Line 33: [access "refs/heads/master"] why this didnt get deleted is gerrit's secret, but i'll leave it as is... :) -- To view, visit https://review.coreboot.org/21090 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: refs/meta/config Gerrit-MessageType: comment Gerrit-Change-Id: Ia8ad1dc3dcdb6e35bfb47cbe437f2f7ea1cc560b Gerrit-Change-Number: 21090 Gerrit-PatchSet: 1 Gerrit-Owner: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 18 Aug 2017 11:42:50 +0000 Gerrit-HasComments: Yes

1 0

Change in flashrom[refs/meta/config]: Refine rights to create/delete any branches
by build bot (Jenkins) (Code Review) Aug. 18, 2017

Aug. 18, 2017

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21090 ) Change subject: Refine rights to create/delete any branches ...................................................................... Patch Set 1: Build Failed https://qa.coreboot.org/job/flashrom_gerrit/472/ : FAILURE https://qa.coreboot.org/job/flashrom-customrules/514/ : SUCCESS -- To view, visit https://review.coreboot.org/21090 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: refs/meta/config Gerrit-MessageType: comment Gerrit-Change-Id: Ia8ad1dc3dcdb6e35bfb47cbe437f2f7ea1cc560b Gerrit-Change-Number: 21090 Gerrit-PatchSet: 1 Gerrit-Owner: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 18 Aug 2017 11:37:50 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[refs/meta/config]: Refine rights to create/delete any branches
by Stefan Tauner (Code Review) Aug. 18, 2017

Aug. 18, 2017

Stefan Tauner has uploaded this change for review. ( https://review.coreboot.org/21090 Change subject: Refine rights to create/delete any branches ...................................................................... Refine rights to create/delete any branches Allow creation/deletion of any branches (instead of just stable/staging) and give these rights to David, Nico and myself for now. Change-Id: Ia8ad1dc3dcdb6e35bfb47cbe437f2f7ea1cc560b --- M groups M project.config 2 files changed, 9 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/90/21090/1 diff --git a/groups b/groups index 3caeb32..5cb19fc 100644 --- a/groups +++ b/groups @@ -1,5 +1,6 @@ # UUID Group Name # db95ce11b379445ac8c5806ea0b61195555b338d flashrom developers +user:Nico user/Nico Huber (Nico) user:dhendrix user/David Hendricks (dhendrix) user:stefanct user/Stefan Tauner (stefanct) diff --git a/project.config b/project.config index e49aeed..a05ec32 100644 --- a/project.config +++ b/project.config @@ -31,11 +31,14 @@ header = to filter = -is:draft [access "refs/heads/master"] - create = group user/David Hendricks (dhendrix) - create = group user/Stefan Tauner (stefanct) - delete = group user/David Hendricks (dhendrix) - delete = group user/Stefan Tauner (stefanct) - exclusiveGroupPermissions = create delete [access "refs/*"] label-Verified = -1..+1 group user/Stefan Tauner (stefanct) submit = group user/Stefan Tauner (stefanct) +[access "refs/heads/*"] + exclusiveGroupPermissions = create delete + create = group user/David Hendricks (dhendrix) + create = group user/Nico Huber (Nico) + create = group user/Stefan Tauner (stefanct) + delete = group user/David Hendricks (dhendrix) + delete = group user/Nico Huber (Nico) + delete = group user/Stefan Tauner (stefanct) -- To view, visit https://review.coreboot.org/21090 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: refs/meta/config Gerrit-MessageType: newchange Gerrit-Change-Id: Ia8ad1dc3dcdb6e35bfb47cbe437f2f7ea1cc560b Gerrit-Change-Number: 21090 Gerrit-PatchSet: 1 Gerrit-Owner: Stefan Tauner <stefan.tauner(a)gmx.at>

1 0

Change in flashrom[refs/meta/config]: Refine rights to create/delete any branches
by build bot (Jenkins) (Code Review) Aug. 18, 2017

Aug. 18, 2017

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21089 ) Change subject: Refine rights to create/delete any branches ...................................................................... Patch Set 1: Build Failed https://qa.coreboot.org/job/flashrom_gerrit/471/ : FAILURE https://qa.coreboot.org/job/flashrom-customrules/513/ : SUCCESS -- To view, visit https://review.coreboot.org/21089 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: refs/meta/config Gerrit-MessageType: comment Gerrit-Change-Id: Iee7ced1353cf354f5284281929f4d4a4095ab0fe Gerrit-Change-Number: 21089 Gerrit-PatchSet: 1 Gerrit-Owner: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 18 Aug 2017 11:36:38 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[refs/meta/config]: Refine rights to create/delete any branches
by Stefan Tauner (Code Review) Aug. 18, 2017

Aug. 18, 2017

Stefan Tauner has uploaded this change for review. ( https://review.coreboot.org/21089 Change subject: Refine rights to create/delete any branches ...................................................................... Refine rights to create/delete any branches Allow creation/deletion of any branches (instead of just stable/staging) and give these rights to David, Nico and myself for now. Change-Id: Iee7ced1353cf354f5284281929f4d4a4095ab0fe --- M groups M project.config 2 files changed, 9 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/89/21089/1 diff --git a/groups b/groups index 3caeb32..5cb19fc 100644 --- a/groups +++ b/groups @@ -1,5 +1,6 @@ # UUID Group Name # db95ce11b379445ac8c5806ea0b61195555b338d flashrom developers +user:Nico user/Nico Huber (Nico) user:dhendrix user/David Hendricks (dhendrix) user:stefanct user/Stefan Tauner (stefanct) diff --git a/project.config b/project.config index e49aeed..a05ec32 100644 --- a/project.config +++ b/project.config @@ -31,11 +31,14 @@ header = to filter = -is:draft [access "refs/heads/master"] - create = group user/David Hendricks (dhendrix) - create = group user/Stefan Tauner (stefanct) - delete = group user/David Hendricks (dhendrix) - delete = group user/Stefan Tauner (stefanct) - exclusiveGroupPermissions = create delete [access "refs/*"] label-Verified = -1..+1 group user/Stefan Tauner (stefanct) submit = group user/Stefan Tauner (stefanct) +[access "refs/heads/*"] + exclusiveGroupPermissions = create delete + create = group user/David Hendricks (dhendrix) + create = group user/Nico Huber (Nico) + create = group user/Stefan Tauner (stefanct) + delete = group user/David Hendricks (dhendrix) + delete = group user/Nico Huber (Nico) + delete = group user/Stefan Tauner (stefanct) -- To view, visit https://review.coreboot.org/21089 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: refs/meta/config Gerrit-MessageType: newchange Gerrit-Change-Id: Iee7ced1353cf354f5284281929f4d4a4095ab0fe Gerrit-Change-Number: 21089 Gerrit-PatchSet: 1 Gerrit-Owner: Stefan Tauner <stefan.tauner(a)gmx.at>

1 0