November 2017 - flashrom-gerrit

Change in flashrom[staging]: ichspi: Fix software sequencing for Skylake
by Nico Huber (Code Review) Nov. 1, 2017

Nov. 1, 2017

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/22273 Change subject: ichspi: Fix software sequencing for Skylake ...................................................................... ichspi: Fix software sequencing for Skylake Two occurences of ICH9_REG_OPMENU were overlooked and not replaced, rendering the software sequencing unusable on Skylake. Change-Id: I16eebcf37ab8ba39b02f33135535552e380b0b92 Signed-off-by: Nico Huber <nico.huber(a)secunet.com> --- M ichspi.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/73/22273/1 diff --git a/ichspi.c b/ichspi.c index 9d6b62b..ec81628 100644 --- a/ichspi.c +++ b/ichspi.c @@ -983,8 +983,8 @@ } /* Select opcode */ - opmenu = REGREAD32(ICH9_REG_OPMENU); - opmenu |= ((uint64_t)REGREAD32(ICH9_REG_OPMENU + 4)) << 32; + opmenu = REGREAD32(swseq_data.reg_opmenu); + opmenu |= ((uint64_t)REGREAD32(swseq_data.reg_opmenu + 4)) << 32; for (opcode_index = 0; opcode_index < 8; opcode_index++) { if ((opmenu & 0xff) == op.opcode) { -- To view, visit https://review.coreboot.org/22273 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: newchange Gerrit-Change-Id: I16eebcf37ab8ba39b02f33135535552e380b0b92 Gerrit-Change-Number: 22273 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>

1 0

Change in flashrom[staging]: vt_vx: check whether the chipset's MMIO range is configured
by Paul Menzel (Code Review) Nov. 1, 2017

Nov. 1, 2017

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/22263 ) Change subject: vt_vx: check whether the chipset's MMIO range is configured ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/22263/1//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/22263/1//COMMIT_MSG@12 PS1, Line 12: Change-Id: I5d3a1ba695153e854e0979ae634f8ed97e6b6293 Is a line *Signed-off-by* needed? -- To view, visit https://review.coreboot.org/22263 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: I5d3a1ba695153e854e0979ae634f8ed97e6b6293 Gerrit-Change-Number: 22263 Gerrit-PatchSet: 1 Gerrit-Owner: Lubomir Rintel <lkundrak(a)v3.sk> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 01 Nov 2017 11:00:56 +0000 Gerrit-HasComments: Yes

1 0

Change in flashrom[staging]: vt_vx: check whether the chipset's MMIO range is configured
by David Hendricks (Code Review) Oct. 31, 2017

Oct. 31, 2017

David Hendricks has posted comments on this change. ( https://review.coreboot.org/22263 ) Change subject: vt_vx: check whether the chipset's MMIO range is configured ...................................................................... Patch Set 1: Code-Review+1 Seems OK, but let's wait for others to chime in before applying +2 to this patch. -- To view, visit https://review.coreboot.org/22263 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: I5d3a1ba695153e854e0979ae634f8ed97e6b6293 Gerrit-Change-Number: 22263 Gerrit-PatchSet: 1 Gerrit-Owner: Lubomir Rintel <lkundrak(a)v3.sk> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 01 Nov 2017 05:51:02 +0000 Gerrit-HasComments: No

1 0