November 2017 - flashrom-gerrit

Change in flashrom[master]: Initial MTD support
by Paul Menzel (Code Review) Nov. 20, 2017

Nov. 20, 2017

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/22501 ) Change subject: Initial MTD support ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/22501/1//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/22501/1//COMMIT_MSG@7 PS1, Line 7: Initial MTD support Add … -- To view, visit https://review.coreboot.org/22501 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib3b8963874722ea80299e9298101409408d6c253 Gerrit-Change-Number: 22501 Gerrit-PatchSet: 1 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Shawn Nematbakhsh <shawnn(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 20 Nov 2017 12:32:26 +0000 Gerrit-HasComments: Yes

1 0

Change in flashrom[master]: chipset_enable: Mark SiS 630 as tested OK
by Paul Menzel (Code Review) Nov. 20, 2017

Nov. 20, 2017

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/22522 ) Change subject: chipset_enable: Mark SiS 630 as tested OK ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/22522 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If8cc2af262e392bfba326a62c1a48c658c7d6ce8 Gerrit-Change-Number: 22522 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 20 Nov 2017 12:29:04 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[master]: Initial MTD support
by David Hendricks (Code Review) Nov. 19, 2017

Nov. 19, 2017

David Hendricks has posted comments on this change. ( https://review.coreboot.org/22501 ) Change subject: Initial MTD support ...................................................................... Patch Set 1: Yes - I did that in the follow-up patch. This was intended to be as much of a straight import as possible, with conflict resolution where necessary. The error you mention was fixed in https://chromium-review.googlesource.com/c/chromiumos/third_party/flashrom/… . However since that patch touches a few files we don't have in upstream I had to skip it. The plan is to squash some of these patches together, particularly the ones which fix small things, so that it's easier for others (particularly Nico) to review. -- To view, visit https://review.coreboot.org/22501 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib3b8963874722ea80299e9298101409408d6c253 Gerrit-Change-Number: 22501 Gerrit-PatchSet: 1 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Shawn Nematbakhsh <shawnn(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 20 Nov 2017 06:00:27 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[master]: chipset_enable: Mark SiS 630 as tested OK
by build bot (Jenkins) (Code Review) Nov. 19, 2017

Nov. 19, 2017

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22522 ) Change subject: chipset_enable: Mark SiS 630 as tested OK ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom_gerrit/791/ : SUCCESS https://qa.coreboot.org/job/flashrom-customrules/902/ : SUCCESS -- To view, visit https://review.coreboot.org/22522 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If8cc2af262e392bfba326a62c1a48c658c7d6ce8 Gerrit-Change-Number: 22522 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 19 Nov 2017 15:33:43 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[master]: chipset_enable: Mark SiS 630 as tested OK
by Nico Huber (Code Review) Nov. 19, 2017

Nov. 19, 2017

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/22522 Change subject: chipset_enable: Mark SiS 630 as tested OK ...................................................................... chipset_enable: Mark SiS 630 as tested OK Tested on an Elitegroup P6STMT with an SST39SF020A parallel flash [1]. [1] https://mail.coreboot.org/pipermail/flashrom/2017-November/015193.html Change-Id: If8cc2af262e392bfba326a62c1a48c658c7d6ce8 Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M chipset_enable.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/22/22522/1 diff --git a/chipset_enable.c b/chipset_enable.c index 3437792..a499ba0 100644 --- a/chipset_enable.c +++ b/chipset_enable.c @@ -1614,7 +1614,7 @@ {0x1039, 0x0530, OK, "SiS", "530", enable_flash_sis530}, {0x1039, 0x0540, NT, "SiS", "540", enable_flash_sis540}, {0x1039, 0x0620, NT, "SiS", "620", enable_flash_sis530}, - {0x1039, 0x0630, NT, "SiS", "630", enable_flash_sis540}, + {0x1039, 0x0630, OK, "SiS", "630", enable_flash_sis540}, {0x1039, 0x0635, NT, "SiS", "635", enable_flash_sis540}, {0x1039, 0x0640, NT, "SiS", "640", enable_flash_sis540}, {0x1039, 0x0645, NT, "SiS", "645", enable_flash_sis540}, -- To view, visit https://review.coreboot.org/22522 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: If8cc2af262e392bfba326a62c1a48c658c7d6ce8 Gerrit-Change-Number: 22522 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>

1 0

Change in flashrom[master]: Initial MTD support
by Shawn Nematbakhsh (Code Review) Nov. 17, 2017

Nov. 17, 2017

Shawn Nematbakhsh has posted comments on this change. ( https://review.coreboot.org/22501 ) Change subject: Initial MTD support ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/22501/1/linux_mtd.c File linux_mtd.c: https://review.coreboot.org/#/c/22501/1/linux_mtd.c@41 PS1, Line 41: static char sysfs_path[PATH_MAX]; linux_mtd.o -c linux_mtd.c linux_mtd.c:41:24: error: 'PATH_MAX' undeclared here (not in a function); did you mean 'INT8_MAX'? static char sysfs_path[PATH_MAX]; Do we need #include <linux/limits.h>? -- To view, visit https://review.coreboot.org/22501 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib3b8963874722ea80299e9298101409408d6c253 Gerrit-Change-Number: 22501 Gerrit-PatchSet: 1 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Shawn Nematbakhsh <shawnn(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 17 Nov 2017 18:22:52 +0000 Gerrit-HasComments: Yes

1 0

Change in flashrom[master]: linux_mtd: Suppress message if NOR device not found
by Shawn Nematbakhsh (Code Review) Nov. 17, 2017

Nov. 17, 2017

Shawn Nematbakhsh has posted comments on this change. ( https://review.coreboot.org/22503 ) Change subject: linux_mtd: Suppress message if NOR device not found ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/22503 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I76d50847e6c4a431d30ad39bcd3994059679172d Gerrit-Change-Number: 22503 Gerrit-PatchSet: 1 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Shawn Nematbakhsh <shawnn(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 17 Nov 2017 18:17:13 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[master]: mtd: print a hint for users when lock/unlock fails
by build bot (Jenkins) (Code Review) Nov. 16, 2017

Nov. 16, 2017

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22510 ) Change subject: mtd: print a hint for users when lock/unlock fails ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom_gerrit/788/ : SUCCESS https://qa.coreboot.org/job/flashrom-customrules/899/ : SUCCESS -- To view, visit https://review.coreboot.org/22510 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4fe40c88da2faad9a9df40da9f9df216ed5119af Gerrit-Change-Number: 22510 Gerrit-PatchSet: 1 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Brian Norris <briannorris(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 17 Nov 2017 07:09:11 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[master]: linux_mtd: make read/write loop chunks consistent, and documented
by build bot (Jenkins) (Code Review) Nov. 16, 2017

Nov. 16, 2017

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22512 ) Change subject: linux_mtd: make read/write loop chunks consistent, and documented ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom_gerrit/790/ : SUCCESS https://qa.coreboot.org/job/flashrom-customrules/901/ : SUCCESS -- To view, visit https://review.coreboot.org/22512 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I551bb85269c854f6888c6bfad8031b14fcf10273 Gerrit-Change-Number: 22512 Gerrit-PatchSet: 1 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Brian Norris <briannorris(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 17 Nov 2017 07:09:10 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[master]: linux_mtd: do reads in eraseblock-sized chunks
by build bot (Jenkins) (Code Review) Nov. 16, 2017

Nov. 16, 2017

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22508 ) Change subject: linux_mtd: do reads in eraseblock-sized chunks ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom_gerrit/786/ : SUCCESS https://qa.coreboot.org/job/flashrom-customrules/897/ : SUCCESS -- To view, visit https://review.coreboot.org/22508 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3a8e160795cd24ec1851c00394892536a2a9d0c7 Gerrit-Change-Number: 22508 Gerrit-PatchSet: 1 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Brian Norris <briannorris(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 17 Nov 2017 07:09:06 +0000 Gerrit-HasComments: No

1 0