October 2017 - flashrom-gerrit

Change in flashrom[staging]: vt_vx: check whether the chipset's MMIO range is configured
by build bot (Jenkins) (Code Review) Oct. 31, 2017

Oct. 31, 2017

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22263 ) Change subject: vt_vx: check whether the chipset's MMIO range is configured ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom_gerrit/710/ : SUCCESS https://qa.coreboot.org/job/flashrom-customrules/804/ : SUCCESS -- To view, visit https://review.coreboot.org/22263 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: I5d3a1ba695153e854e0979ae634f8ed97e6b6293 Gerrit-Change-Number: 22263 Gerrit-PatchSet: 1 Gerrit-Owner: Lubomir Rintel <lkundrak(a)v3.sk> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 31 Oct 2017 14:47:41 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[staging]: vt_vx: check whether the chipset's MMIO range is configured
by Lubomir Rintel (Code Review) Oct. 31, 2017

Oct. 31, 2017

Lubomir Rintel has uploaded this change for review. ( https://review.coreboot.org/22263 Change subject: vt_vx: check whether the chipset's MMIO range is configured ...................................................................... vt_vx: check whether the chipset's MMIO range is configured Avoid attempting to read the SPI bases from the location 0x00000000, all zeroes mean that the chipset's MMIO area is not enabled. Change-Id: I5d3a1ba695153e854e0979ae634f8ed97e6b6293 --- M chipset_enable.c 1 file changed, 8 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/63/22263/1 diff --git a/chipset_enable.c b/chipset_enable.c index 3437792..d8b579c 100644 --- a/chipset_enable.c +++ b/chipset_enable.c @@ -1013,10 +1013,18 @@ switch(dev->device_id) { case 0x8353: /* VX800/VX820 */ spi0_mm_base = pci_read_long(dev, 0xbc) << 8; + if (spi0_mm_base == 0x0) { + msg_pdbg ("MMIO not enabled!\n"); + return ERROR_FATAL; + } break; case 0x8409: /* VX855/VX875 */ case 0x8410: /* VX900 */ mmio_base = pci_read_long(dev, 0xbc) << 8; + if (mmio_base == 0x0) { + msg_pdbg ("MMIO not enabled!\n"); + return ERROR_FATAL; + } mmio_base_physmapped = physmap("VIA VX MMIO register", mmio_base, SPI_CNTL_LEN); if (mmio_base_physmapped == ERROR_PTR) return ERROR_FATAL; -- To view, visit https://review.coreboot.org/22263 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: newchange Gerrit-Change-Id: I5d3a1ba695153e854e0979ae634f8ed97e6b6293 Gerrit-Change-Number: 22263 Gerrit-PatchSet: 1 Gerrit-Owner: Lubomir Rintel <lkundrak(a)v3.sk>

1 0

Change in flashrom[staging]: Fix standalone ich_descriptor_tool compilation with MinGW and DJGPP
by Nico Huber (Code Review) Oct. 27, 2017

Oct. 27, 2017

Nico Huber has posted comments on this change. ( https://review.coreboot.org/21838 ) Change subject: Fix standalone ich_descriptor_tool compilation with MinGW and DJGPP ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/21838 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: Id146f5ba06a0e510397c6f32a2bd7c819a405a25 Gerrit-Change-Number: 21838 Gerrit-PatchSet: 2 Gerrit-Owner: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 26 Oct 2017 22:25:22 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[staging]: Fix standalone ich_descriptor_tool compilation with MinGW and DJGPP
by build bot (Jenkins) (Code Review) Oct. 26, 2017

Oct. 26, 2017

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21838 ) Change subject: Fix standalone ich_descriptor_tool compilation with MinGW and DJGPP ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom_gerrit/709/ : SUCCESS https://qa.coreboot.org/job/flashrom-customrules/803/ : SUCCESS -- To view, visit https://review.coreboot.org/21838 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: Id146f5ba06a0e510397c6f32a2bd7c819a405a25 Gerrit-Change-Number: 21838 Gerrit-PatchSet: 2 Gerrit-Owner: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 26 Oct 2017 16:46:01 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[staging]: Fix standalone ich_descriptor_tool compilation with MinGW and DJGPP
by Stefan Tauner (Code Review) Oct. 26, 2017

Oct. 26, 2017

Hello build bot (Jenkins), Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/21838 to look at the new patch set (#2). Change subject: Fix standalone ich_descriptor_tool compilation with MinGW and DJGPP ...................................................................... Fix standalone ich_descriptor_tool compilation with MinGW and DJGPP TARGET_OS as well as EXEC_SUFFIX were only set when called via the main makefile and even then __USE_MINGW_ANSI_STDIO was not set for MinGW. While at it, also replace the hardcoded gnu_printf printf format attribute with __MINGW_PRINTF_FORMAT which is set according to __USE_MINGW_ANSI_STDIO respectively. Change-Id: Id146f5ba06a0e510397c6f32a2bd7c819a405a25 Signed-off-by: Stefan Tauner <stefan.tauner(a)gmx.at> --- M flash.h M util/ich_descriptors_tool/Makefile 2 files changed, 14 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/38/21838/2 -- To view, visit https://review.coreboot.org/21838 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: newpatchset Gerrit-Change-Id: Id146f5ba06a0e510397c6f32a2bd7c819a405a25 Gerrit-Change-Number: 21838 Gerrit-PatchSet: 2 Gerrit-Owner: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[refs/meta/config]: +/-2 for stefanct, exclusive tag pushes for flashrom devs
by build bot (Jenkins) (Code Review) Oct. 24, 2017

Oct. 24, 2017

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21835 ) Change subject: +/-2 for stefanct, exclusive tag pushes for flashrom devs ...................................................................... Patch Set 3: Build Successful https://qa.coreboot.org/job/flashrom-customrules/802/ : SUCCESS -- To view, visit https://review.coreboot.org/21835 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: refs/meta/config Gerrit-MessageType: comment Gerrit-Change-Id: Ib0e0fbeab6227876b5d54351ee32b0e4c3649a11 Gerrit-Change-Number: 21835 Gerrit-PatchSet: 3 Gerrit-Owner: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 24 Oct 2017 08:09:02 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[refs/meta/config]: +/-2 for stefanct, exclusive tag pushes for flashrom devs
by Patrick Georgi (Code Review) Oct. 24, 2017

Oct. 24, 2017

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/21835 ) Change subject: +/-2 for stefanct, exclusive tag pushes for flashrom devs ...................................................................... +/-2 for stefanct, exclusive tag pushes for flashrom devs Change-Id: Ib0e0fbeab6227876b5d54351ee32b0e4c3649a11 Reviewed-on: https://review.coreboot.org/21835 Tested-by: Stefan Tauner <stefan.tauner(a)gmx.at> Reviewed-by: Patrick Georgi <pgeorgi(a)google.com> --- M project.config 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Stefan Tauner: Verified Patrick Georgi: Looks good to me, approved diff --git a/project.config b/project.config index a05ec32..3ff4784 100644 --- a/project.config +++ b/project.config @@ -12,6 +12,7 @@ exclusiveGroupPermissions = submit [access "refs/tags/*"] push = +force group flashrom developers + exclusiveGroupPermissions = push [label "Code-Review"] function = MaxWithBlock @@ -30,10 +31,10 @@ email = flashrom-gerrit(a)flashrom.org header = to filter = -is:draft -[access "refs/heads/master"] [access "refs/*"] label-Verified = -1..+1 group user/Stefan Tauner (stefanct) submit = group user/Stefan Tauner (stefanct) + label-Code-Review = -2..+2 group user/Stefan Tauner (stefanct) [access "refs/heads/*"] exclusiveGroupPermissions = create delete create = group user/David Hendricks (dhendrix) -- To view, visit https://review.coreboot.org/21835 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: refs/meta/config Gerrit-MessageType: merged Gerrit-Change-Id: Ib0e0fbeab6227876b5d54351ee32b0e4c3649a11 Gerrit-Change-Number: 21835 Gerrit-PatchSet: 3 Gerrit-Owner: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[refs/meta/config]: +/-2 for stefanct, exclusive tag pushes for flashrom devs
by Patrick Georgi (Code Review) Oct. 24, 2017

Oct. 24, 2017

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/21835 ) Change subject: +/-2 for stefanct, exclusive tag pushes for flashrom devs ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/21835 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: refs/meta/config Gerrit-MessageType: comment Gerrit-Change-Id: Ib0e0fbeab6227876b5d54351ee32b0e4c3649a11 Gerrit-Change-Number: 21835 Gerrit-PatchSet: 2 Gerrit-Owner: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 24 Oct 2017 08:08:51 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[staging]: Use bzip2 when making a tarball
by build bot (Jenkins) (Code Review) Oct. 21, 2017

Oct. 21, 2017

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22116 ) Change subject: Use bzip2 when making a tarball ...................................................................... Patch Set 3: Build Successful https://qa.coreboot.org/job/flashrom-customrules/801/ : SUCCESS -- To view, visit https://review.coreboot.org/22116 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: Ib9fb1ea6d5994cd0285ce8db9675640fae992773 Gerrit-Change-Number: 22116 Gerrit-PatchSet: 3 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 21 Oct 2017 02:16:11 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[staging]: Use bzip2 when making a tarball
by David Hendricks (Code Review) Oct. 21, 2017

Oct. 21, 2017

David Hendricks has submitted this change and it was merged. ( https://review.coreboot.org/22116 ) Change subject: Use bzip2 when making a tarball ...................................................................... Use bzip2 when making a tarball Tarballs on download.flashrom.org are generally packaged using bzip2, so we may as well be internally consistent. Change-Id: Ib9fb1ea6d5994cd0285ce8db9675640fae992773 Signed-off-by: David Hendricks <dhendricks(a)fb.com> Reviewed-on: https://review.coreboot.org/22116 Reviewed-by: Nico Huber <nico.h(a)gmx.de> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M Makefile 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Nico Huber: Looks good to me, approved build bot (Jenkins): Verified diff --git a/Makefile b/Makefile index 52f6c98..5bd7158 100644 --- a/Makefile +++ b/Makefile @@ -1408,11 +1408,11 @@ @echo "Exported $(EXPORTDIR)/flashrom-$(RELEASENAME)/" tarball: _export - @tar -cz --format=ustar -f "$(EXPORTDIR)/flashrom-$(RELEASENAME).tar.gz" -C $(EXPORTDIR)/ \ + @tar -cj --format=ustar -f "$(EXPORTDIR)/flashrom-$(RELEASENAME).tar.bz2" -C $(EXPORTDIR)/ \ $(TAROPTIONS) "flashrom-$(RELEASENAME)/" # Delete the exported directory again because it is most likely what's expected by the user. @rm -rf "$(EXPORTDIR)/flashrom-$(RELEASENAME)" - @echo Created "$(EXPORTDIR)/flashrom-$(RELEASENAME).tar.gz" + @echo Created "$(EXPORTDIR)/flashrom-$(RELEASENAME).tar.bz2" libpayload: clean make CC="CC=i386-elf-gcc lpgcc" AR=i386-elf-ar RANLIB=i386-elf-ranlib -- To view, visit https://review.coreboot.org/22116 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: merged Gerrit-Change-Id: Ib9fb1ea6d5994cd0285ce8db9675640fae992773 Gerrit-Change-Number: 22116 Gerrit-PatchSet: 3 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0