Hi, Attachment are the patches for Chipset AMD RS690, AMD SB600 and mainboard DBM690T. The following ACPI features are supported. 1. S1, S5 sleep and wake up (by power button or PS/2 keyboard/mouse). 2. AMD powernow-k8 driver. 3. Thermal configuration based on ADT7461. 4. IDE timing settings. 5. HPET timer. 6. Interrupt routing based on ACPI table. Signed-off-by: Joe Bao <zheng.bao@amd.com> Reviewed-by: Maggie Li <maggie.li@amd.com>
On Tue, Nov 25, 2008 at 9:18 PM, Bao, Zheng <Zheng.Bao@amd.com> wrote:
Hi, Attachment are the patches for Chipset AMD RS690, AMD SB600 and mainboard DBM690T. The following ACPI features are supported. 1. S1, S5 sleep and wake up (by power button or PS/2 keyboard/mouse). 2. AMD powernow-k8 driver. 3. Thermal configuration based on ADT7461. 4. IDE timing settings. 5. HPET timer. 6. Interrupt routing based on ACPI table.
I would request one change. When there is a HALT type error, such as this: printk_info("rs690_enable: CAN NOT FIND SB bridge, HALT!\n"); it would be best to do this instead: die("rs690_enable: CAN NOT FIND SB bridge, HALT!\n"); So, for example: printk_info("rs690_enable: CAN NOT FIND SB bridge, HALT!\n"); for (;;) ; becomes instead: die("rs690_enable: CAN NOT FIND SB bridge, HALT!\n"); /*NOTREACHED*/ The rest of this patch looks fine. If you can change the "HALT" printk_info to die, then: Acked-by: Ronald G. Minnich <rminnich@gmail.com> ron
Hi, Ron, We have modified the patch as you told us. Thanks. Joe -----Original Message----- From: ron minnich [mailto:rminnich@gmail.com] Sent: Wednesday, November 26, 2008 11:46 PM To: Bao, Zheng Cc: coreboot@coreboot.org; Huang, FrankR; Feng, Libo; Li, Maggie; Wang, Qingpei; Xie, Michael Subject: Re: [coreboot] Patches for ACPI support on dbm690t (RS600 and SB600) On Tue, Nov 25, 2008 at 9:18 PM, Bao, Zheng <Zheng.Bao@amd.com> wrote:
Hi, Attachment are the patches for Chipset AMD RS690, AMD SB600 and mainboard DBM690T. The following ACPI features are supported. 1. S1, S5 sleep and wake up (by power button or PS/2 keyboard/mouse). 2. AMD powernow-k8 driver. 3. Thermal configuration based on ADT7461. 4. IDE timing settings. 5. HPET timer. 6. Interrupt routing based on ACPI table.
I would request one change. When there is a HALT type error, such as this: printk_info("rs690_enable: CAN NOT FIND SB bridge, HALT!\n"); it would be best to do this instead: die("rs690_enable: CAN NOT FIND SB bridge, HALT!\n"); So, for example: printk_info("rs690_enable: CAN NOT FIND SB bridge, HALT!\n"); for (;;) ; becomes instead: die("rs690_enable: CAN NOT FIND SB bridge, HALT!\n"); /*NOTREACHED*/ The rest of this patch looks fine. If you can change the "HALT" printk_info to die, then: Acked-by: Ronald G. Minnich <rminnich@gmail.com> ron
Hi, We forgot to add "signed-off-by & reviewed-by" in our previous shot. We add more clean-up this time. Please ack these ones. Thanks a lot. Signed-off-by: Joe Bao <zheng.bao@amd.com> Reviewed-by: Maggie Li <maggie.li@amd.com> Joe -----Original Message----- From: coreboot-bounces@coreboot.org [mailto:coreboot-bounces@coreboot.org] On Behalf Of Bao, Zheng Sent: Thursday, November 27, 2008 10:16 AM To: coreboot@coreboot.org Cc: Li, Maggie; ron minnich; Xie, Michael; Huang, FrankR; Feng, Libo; Wang, Qingpei Subject: Re: [coreboot] Patches for ACPI support on dbm690t (RS600 and SB600) Hi, Ron, We have modified the patch as you told us. Thanks. Joe -----Original Message----- From: ron minnich [mailto:rminnich@gmail.com] Sent: Wednesday, November 26, 2008 11:46 PM To: Bao, Zheng Cc: coreboot@coreboot.org; Huang, FrankR; Feng, Libo; Li, Maggie; Wang, Qingpei; Xie, Michael Subject: Re: [coreboot] Patches for ACPI support on dbm690t (RS600 and SB600) On Tue, Nov 25, 2008 at 9:18 PM, Bao, Zheng <Zheng.Bao@amd.com> wrote:
Hi, Attachment are the patches for Chipset AMD RS690, AMD SB600 and mainboard DBM690T. The following ACPI features are supported. 1. S1, S5 sleep and wake up (by power button or PS/2 keyboard/mouse). 2. AMD powernow-k8 driver. 3. Thermal configuration based on ADT7461. 4. IDE timing settings. 5. HPET timer. 6. Interrupt routing based on ACPI table.
I would request one change. When there is a HALT type error, such as this: printk_info("rs690_enable: CAN NOT FIND SB bridge, HALT!\n"); it would be best to do this instead: die("rs690_enable: CAN NOT FIND SB bridge, HALT!\n"); So, for example: printk_info("rs690_enable: CAN NOT FIND SB bridge, HALT!\n"); for (;;) ; becomes instead: die("rs690_enable: CAN NOT FIND SB bridge, HALT!\n"); /*NOTREACHED*/ The rest of this patch looks fine. If you can change the "HALT" printk_info to die, then: Acked-by: Ronald G. Minnich <rminnich@gmail.com> ron
Acked-by: Ronald G. Minnich <rminnich@gmail.com> Thank you ROn
On Fri, Nov 28, 2008 at 9:57 AM, ron minnich <rminnich@gmail.com> wrote:
Acked-by: Ronald G. Minnich <rminnich@gmail.com>
Joe, Thanks for submitting this code. This is a good example of how to use the pre-processor to make the APCI table more readable. Acked-by: Marc Jones <marcj303@gmail.com> r3785 r3786 r3787 Thanks, Marc
On Mon, Dec 1, 2008 at 12:56 PM, Marc Jones <marcj303@gmail.com> wrote:
On Fri, Nov 28, 2008 at 9:57 AM, ron minnich <rminnich@gmail.com> wrote:
Acked-by: Ronald G. Minnich <rminnich@gmail.com>
Joe, Thanks for submitting this code. This is a good example of how to use the pre-processor to make the APCI table more readable.
Acked-by: Marc Jones <marcj303@gmail.com>
r3785 r3786 r3787
Sorry, I missed the svn add on this. r3788
Signed-off-by: Jason Wang <Qingpei.Wang@amd.com> Reviewed-by: Joe Bao <zheng.bao@amd.com> Jason Wang BeiJing Technology Development Center Advanced Micro Devices (AMD)
Wang, Qingpei wrote:
Signed-off-by: Jason Wang <Qingpei.Wang@amd.com> Reviewed-by: Joe Bao <zheng.bao@amd.com>
Jason Wang BeiJing Technology Development Center Advanced Micro Devices (AMD)
------------------------------------------------------------------------
-- coreboot mailing list: coreboot@coreboot.org http://www.coreboot.org/mailman/listinfo/coreboot You might want to check the Mailinglist Archive and look for my SB600 SPI patch and maybe incorporate your changes into my patch. Unless someone more authorized tells you otherwise.
Hi, Sean I had sent you an email a few days ago to ask if you finished the patch already. But I didn't get your response. Plus, when I try to build your patch, some errors come up. Best wishes From: Wang, Qingpei Sent: Wednesday, October 29, 2008 8:48 PM To: 'snelson@nmt.edu'; Coreboot Cc: Xie, Michael; Jones, Marc; Bao, Zheng Subject: SB600 SPI driver for flashrom and sst25vf040 Hi, Sean Have you finished the patch about SB600 SPI driver? I found that the patch you posted can not be compiled, and I had made another two patches, one is for SB600 SPI and the other one is for sst25vf040. If you have any latest work, please tell me, maybe we can merge our patches into one. Thanks Jason Wang BeiJing Technology Development Center Advanced Micro Devices (AMD) Jason Wang BeiJing Technology Development Center Advanced Micro Devices (AMD) -----Original Message----- From: coreboot-bounces@coreboot.org [mailto:coreboot-bounces@coreboot.org] On Behalf Of Sean Nelson Sent: Friday, November 28, 2008 1:21 PM To: coreboot@coreboot.org Subject: Re: [coreboot] Patches [FLASHROM] SB600 SPI driver and sst25vf080b Wang, Qingpei wrote:
Signed-off-by: Jason Wang <Qingpei.Wang@amd.com> Reviewed-by: Joe Bao <zheng.bao@amd.com>
Jason Wang BeiJing Technology Development Center Advanced Micro Devices (AMD)
------------------------------------------------------------------------
-- coreboot mailing list: coreboot@coreboot.org http://www.coreboot.org/mailman/listinfo/coreboot
You might want to check the Mailinglist Archive and look for my SB600 SPI patch and maybe incorporate your changes into my patch. Unless someone more authorized tells you otherwise. -- coreboot mailing list: coreboot@coreboot.org http://www.coreboot.org/mailman/listinfo/coreboot
On 28.11.2008 06:06, Wang, Qingpei wrote:
Signed-off-by: Jason Wang <Qingpei.Wang@amd.com> Reviewed-by: Joe Bao <zheng.bao@amd.com>
Thanks! Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net> I committed the SST25VF080B patch in revision 3776 with a small change for sorting order. Somebody will review the SB600 SPI driver soon. Regards, Carl-Daniel -- http://www.hailfinger.org/
hi, On Fri, Nov 28, 2008 at 01:06:54PM +0800, Wang, Qingpei wrote:
Signed-off-by: Jason Wang <Qingpei.Wang@amd.com> Reviewed-by: Joe Bao <zheng.bao@amd.com>
Thanks for the sb600 patch! I'll try to test it on my sb600 board this evening; I'll report back on how it works. Cheers, Uwe. -- http://www.hermann-uwe.de | http://www.holsham-traders.de http://www.crazy-hacks.org | http://www.unmaintained-free-software.org
On Fri, Nov 28, 2008 at 04:16:13PM +0100, Uwe Hermann wrote:
On Fri, Nov 28, 2008 at 01:06:54PM +0800, Wang, Qingpei wrote:
Signed-off-by: Jason Wang <Qingpei.Wang@amd.com> Reviewed-by: Joe Bao <zheng.bao@amd.com>
Thanks for the sb600 patch! I'll try to test it on my sb600 board this evening; I'll report back on how it works.
I have committed the patch in r3779, the code worked fine on my RS690/SB600 board after a few changes. The most important changes is to drop the "sleep(1)" from sb600_spi_write() as otherwise writing takes _veery_ long (I actually killed flashrom after 7-8 minutes as I didn't want to wait longer). Without the sleep() a full write of a 1MB chip still takes 2:30 minutes, I'm not sure if that's normal. Another change I did, was to change 'outb' to 'OUTB' to make it portable to other systems (*BSD). The rest of the changes is purely coding-style fixes and making the printf() output a bit more consistent with the rest of flashrom. One other change I'd suggest is this: Index: sb600spi.c =================================================================== --- sb600spi.c (revision 3779) +++ sb600spi.c (working copy) @@ -1,9 +1,7 @@ /* * This file is part of the flashrom project. * - * Copyright (C) 2008 Stefan Wildemann <stefan.wildemann@kontron.com> - * Copyright (C) 2008 Claus Gindhart <claus.gindhart@kontron.com> - * Copyright (C) 2008 Dominik Geyer <dominik.geyer@kontron.com> + * Copyright (C) 2008 Advanced Micro Devices, Inc. * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by The sb600spi.c file may have started out by copying the ichspi.c file (that's where the copyright lines come from), but AFAICS pretty much none of that content is left in sb600spi.c, so the copyright lines should be adapted accordingly. Please let me know if that's ok. Thanks again for the great patch! Uwe. -- http://www.hermann-uwe.de | http://www.holsham-traders.de http://www.crazy-hacks.org | http://www.unmaintained-free-software.org
Hi, all I had changed the Copyright of sb600spi.c. Best wishes Jason Wang BeiJing Technology Development Center Advanced Micro Devices (AMD) Signed-off-by: Jason Wang<Qingpei.wang@amd.com> Reviewed-by: Joe, Bao <Zheng.Bao@amd.com>
Hi, On Sat, Nov 29, 2008 at 06:22:29PM +0800, Wang, Qingpei wrote:
Hi, all I had changed the Copyright of sb600spi.c.
Best wishes
Just a question to make sure -- are the changes copyright AMD or copyright of individual developers? If you did the changes during working hours at AMD I guess the code is (C) AMD, otherwise it is (C) Wang Qingpei and (C) Joe Bao. If the code is (C) AMD I propose this patch: Index: sb600spi.c =================================================================== --- sb600spi.c (Revision 3782) +++ sb600spi.c (Arbeitskopie) @@ -1,9 +1,9 @@ /* * This file is part of the flashrom project. * - * Copyright (C) 2008 Wang Qingpei <Qingpei.Wang@amd.com> - * Copyright (C) 2008 Joe Bao <Zheng.Bao@amd.com> - * Copyright (C) Adavanced Micro Devices, Inc + * Copyright (C) 2008 Advanced Micro Devices, Inc. + * (Written by Wang Qingpei <Qingpei.Wang@amd.com> for AMD) + * (Written by Joe Bao <Zheng.Bao@amd.com> for AMD) * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by Thanks, Uwe. -- http://www.hermann-uwe.de | http://www.holsham-traders.de http://www.crazy-hacks.org | http://www.unmaintained-free-software.org
participants (7)
-
Bao, Zheng -
Carl-Daniel Hailfinger -
Marc Jones -
ron minnich -
Sean Nelson -
Uwe Hermann -
Wang, Qingpei