AMD binaryPI board removals
Hi As of 27th November and commit [1] platforms using AMD binaryPI blobs have been disabled from automatic build testing. The following are affected: * amd/bettong * amd/db-ft3b-lc * amd/lamar * amd/olivehillplus * bap/ode_e21XX This is inline with CAR_GLOBAL_MIGRATION deprecation as mandated by 4.11 release requirements. You should expect that the board sources and platform support will disappear by 14th December, at latest, unless you show interest *and* are able to provide bootlogs for the boards above. PCEngines APU2 and variants are an exception to this, they were converted to POSTCAR_STAGE and work away from ROMCC_BOOTBLOCK shows promising results. [1] https://review.coreboot.org/c/coreboot/+/37170 Regards, Kyösti Mälkki
As of 27th November and commit [1] platforms using AMD binaryPI blobs have been disabled from automatic build testing. The following are affected:
* amd/bettong
Hi all, I have an AMD Bettong demoboard and I would like to remain supported by coreboot. What can I do to help? Regards Jorge
On Wed, Nov 27, 2019 at 12:48 PM Jorge Fernandez Monteagudo <jorgefm@cirsa.com> wrote:
As of 27th November and commit [1] platforms using AMD binaryPI blobs have been disabled from automatic build testing. The following are affected:
* amd/bettong
Hi all,
I have an AMD Bettong demoboard and I would like to remain supported by coreboot. What can I do to help?
Nice! First you need to upload a board-status, preferably built from the commit tagged 4.11. Regards, Kyösti Mälkki
First you need to upload a board-status, preferably built from the commit tagged 4.11.
Sorry my noob question, do you mean to build the coreboot.rom with the 4.11 version and send the boot log to this mailing list? The changes I've done to support my needs are only local, I 've not contribute nothing back still...
Hi, I have initially wanted to send patches with migration to postcar and C bootblock for other platforms. When I finish the work on apu2 I may setup a patch for testing, I would appreciate if you could flash it on your board and provide results. Be prepared to have: - external programmer for recovery means - post card to read post codes - courage to brick the platform and skills to recover it with external programmer Regards, Michał On 27.11.2019 11:48, Jorge Fernandez Monteagudo wrote:
As of 27th November and commit [1] platforms using AMD binaryPI blobs have been disabled from automatic build testing. The following are affected:
* amd/bettong Hi all,
I have an AMD Bettong demoboard and I would like to remain supported by coreboot. What can I do to help?
Regards Jorge _______________________________________________ coreboot mailing list -- coreboot@coreboot.org To unsubscribe send an email to coreboot-leave@coreboot.org
-- Michał Żygowski Firmware Engineer http://3mdeb.com | @3mdeb_com
Hi Michal,
I have initially wanted to send patches with migration to postcar and C bootblock for other platforms.
When I finish the work on apu2 I may setup a patch for testing, I would appreciate if you could flash it on your board and provide results.
Ok, I'll wait for your patches and I'll try to add to the bettong board. No problem flashing and unblocking a bricked board. Thanks!
Here is a short guide how to upload board status: https://github.com/coreboot/coreboot/blob/master/util/board_status/README The system you are going to boot has to have cbmem installed. On 27.11.2019 12:05, Jorge Fernandez Monteagudo wrote:
Hi Michal,
I have initially wanted to send patches with migration to postcar and C bootblock for other platforms.
When I finish the work on apu2 I may setup a patch for testing, I would appreciate if you could flash it on your board and provide results. Ok, I'll wait for your patches and I'll try to add to the bettong board. No problem flashing and unblocking a bricked board.
Thanks! _______________________________________________ coreboot mailing list -- coreboot@coreboot.org To unsubscribe send an email to coreboot-leave@coreboot.org
-- Michał Żygowski Firmware Engineer http://3mdeb.com | @3mdeb_com
Here is a short guide how to upload board status:
https://github.com/coreboot/coreboot/blob/master/util/board_status/README
The system you are going to boot has to have cbmem installed.
Hi Michal, Do you have already any patch to test? I've updated to the last git and enabled the AMD Bettong board (it's disabled in Kconfig.name!) but it's not compiling. There are several errors: 1) src/drivers/amd/agesa/state_machine.c: In function 'ramstage_dispatch': src/drivers/amd/agesa/state_machine.c:216:8: error: 'AMD_S3_SAVE' undeclared (first use in this function); did you mean 'AMD_INIT_LATE'? 2) src/mainboard/amd/bettong/OemCustomize.c:130:6: error: no previous prototype for 'OemCustomizeInitEarly' [-Werror=missing-prototypes] VOID OemCustomizeInitEarly ( src/mainboard/amd/bettong/OemCustomize.c:149:6: error: no previous prototype for 'OemPostParams' [-Werror=missing-prototypes] void OemPostParams(AMD_POST_PARAMS *PostParams) 3) src/mainboard/amd/bettong/romstage.c:34:7: error: 'cpu_init_detectedx' undeclared (first use in this function); did you mean 'cpu_index'? if (!cpu_init_detectedx && boot_cpu()) { src/mainboard/amd/bettong/romstage.c:34:7: note: each undeclared identifier is reported only once for each function it appears in src/mainboard/amd/bettong/romstage.c:51:2: error: implicit declaration of function 'AGESAWRAPPER'; did you mean 'AGESA_READ_SPD'? [-Werror=implicit-function-declaration] AGESAWRAPPER(amdinitreset); src/mainboard/amd/bettong/romstage.c:51:15: error: 'amdinitreset' undeclared (first use in this function); did you mean 'AmdInitReset'? AGESAWRAPPER(amdinitreset); src/mainboard/amd/bettong/romstage.c:56:15: error: 'amdinitearly' undeclared (first use in this function); did you mean 'AmdInitEarly'? AGESAWRAPPER(amdinitearly); src/mainboard/amd/bettong/romstage.c:59:15: error: 'amdinitpost' undeclared (first use in this function); did you mean 'AmdInitPost'? AGESAWRAPPER(amdinitpost); src/mainboard/amd/bettong/romstage.c: In function 'agesa_postcar': src/mainboard/amd/bettong/romstage.c:65:15: error: 'amdinitenv' undeclared (first use in this function); did you mean 'AmdInitEnv'? AGESAWRAPPER(amdinitenv); src/mainboard/amd/bettong/romstage.c:28:13: error: 'romstage_main_template' defined but not used [-Werror=unused-function] Regards, Jorge
On Tue, Dec 3, 2019 at 3:58 PM Jorge Fernandez Monteagudo <jorgefm@cirsa.com> wrote:
Here is a short guide how to upload board status:
https://github.com/coreboot/coreboot/blob/master/util/board_status/README
The system you are going to boot has to have cbmem installed.
Hi Michal,
Do you have already any patch to test? I've updated to the last git and enabled the AMD Bettong board (it's disabled in Kconfig.name!) but it's not compiling. There are several errors:
Checkout a commit before a0a50775. We (or at least I) want to have a reference boot loaded into board-status for amd/bettong first. Kyösti
Checkout a commit before a0a50775. We (or at least I) want to have a reference boot loaded into board-status for amd/bettong first.
Hi Kyösti, I've checkout f77f2c79c2bb898c123ffe89a0bd1acb5362afc5 and the board doesn't boot. The boot log I get is: coreboot-4.11-127-gf77f2c7-dirty Wed Nov 27 10:11:26 UTC 2019 romstage starting (log level: 8)... BSP Family_Model: 00660f01 cpu_init_detectedx = 00000000 agesawrapper_amdinitreset() entry ERROR: FMAP cache corrupted?! FMAP: Found "FLASH" version 1.1 at 0x0. FMAP: base = 0xff800000 size = 0x800000 #areas = 3 FMAP: area COREBOOT found @ 200 (8388096 bytes) CBFS @ 200 size 7ffe00 CBFS: 'COREBOOT Locator' located CBFS at [200:800000) CBFS: Locating 'AGESA' CBFS: Found @ offset 5ffdc0 size a8904 FMAP: area COREBOOT found @ 200 (8388096 bytes) CBFS @ 200 size 7ffe00 CBFS: 'COREBOOT Locator' located CBFS at [200:800000) CBFS: Locating 'AGESA' CBFS: Found @ offset 5ffdc0 size a8904 Fch OEM config in INIT RESET Done FMAP: area COREBOOT found @ 200 (8388096 bytes) CBFS @ 200 size 7ffe00 CBFS: 'COREBOOT Locator' located CBFS at [200:800000) CBFS: Locating 'AGESA' CBFS: Found @ offset 5ffdc0 size a8904 agesawrapper_amdinitreset() returned AGESA_SUCCESS Got past agesawrapper_amdinitreset agesawrapper_amdinitearly() entry FMAP: area COREBOOT found @ 200 (8388096 bytes) CBFS @ 200 size 7ffe00 CBFS: 'COREBOOT Locator' located CBFS at [200:800000) CBFS: Locating 'AGESA' CBFS: Found @ offset 5ffdc0 size a8904 FMAP: area COREBOOT found @ 200 (8388096 bytes) CBFS @ 200 size 7ffe00 CBFS: 'COREBOOT Locator' located CBFS at [200:800000) CBFS: Locating 'AGESA' CBFS: Found @ offset 5ffdc0 size a8904 FMAP: area COREBOOT found @ 200 (8388096 bytes) CBFS @ 200 size 7ffe00 CBFS: 'COREBOOT Locator' located CBFS at [200:800000) CBFS: Locating 'AGESA' CBFS: Found @ offset 5ffdc0 size a8904 agesawrapper_amdinitearly() returned AGESA_SUCCESS agesawrapper_amdinitpost() entry FMAP: area COREBOOT found @ 200 (8388096 bytes) CBFS @ 200 size 7ffe00 CBFS: 'COREBOOT Locator' located CBFS at [200:800000) CBFS: Locating 'AGESA' CBFS: Found @ offset 5ffdc0 size a8904 FMAP: area COREBOOT found @ 200 (8388096 bytes) CBFS @ 200 size 7ffe00 CBFS: 'COREBOOT Locator' located CBFS at [200:800000) CBFS: Locating 'AGESA' CBFS: Found @ offset 5ffdc0 size a8904 -------------READING SPD----------- iobase: 0x00000B00, SmbusSlave: 0x000000A0, count: 128 -------------SPD READ ERROR----------- -------------READING SPD----------- iobase: 0x00000B00, SmbusSlave: 0x000000A2, count: 128 -------------SPD READ ERROR----------- -------------READING SPD----------- iobase: 0x00000B00, SmbusSlave: 0x000000A4, count: 128 -------------FINISHED READING SPD----------- -------------READING SPD----------- iobase: 0x00000B00, SmbusSlave: 0x000000AC, count: 128 -------------SPD READ ERROR----------- setup_uma_memory: umamode UMA_AUTO setup_uma_memory: syslimit 0x12EFF0000, bottomio 0x00d00000 setup_uma_memory: uma size 512MB, uma start 0xb0000000 FMAP: area COREBOOT found @ 200 (8388096 bytes) CBFS @ 200 size 7ffe00 CBFS: 'COREBOOT Locator' located CBFS at [200:800000) CBFS: Locating 'AGESA' CBFS: Found @ offset 5ffdc0 size a8904 EventLog: EventClass = 2, EventInfo = 8040100. Param1 = a00a, Param2 = 0. Param3 = 0, Param4 = 0. FMAP: area COREBOOT found @ 200 (8388096 bytes) CBFS @ 200 size 7ffe00 CBFS: 'COREBOOT Locator' located CBFS at [200:800000) CBFS: Locating 'AGESA' CBFS: Found @ offset 5ffdc0 size a8904 EventLog: EventClass = 2, EventInfo = 8040100. Param1 = a00a, Param2 = 0. Param3 = 0, Param4 = 0. FMAP: area COREBOOT found @ 200 (8388096 bytes) CBFS @ 200 size 7ffe00 CBFS: 'COREBOOT Locator' located CBFS at [200:800000) CBFS: Locating 'AGESA' CBFS: Found @ offset 5ffdc0 size a8904 EventLog: EventClass = 2, EventInfo = 8040100. Param1 = a00a, Param2 = 0. Param3 = 0, Param4 = 0. FMAP: area COREBOOT found @ 200 (8388096 bytes) CBFS @ 200 size 7ffe00 CBFS: 'COREBOOT Locator' located CBFS at [200:800000) CBFS: Locating 'AGESA' CBFS: Found @ offset 5ffdc0 size a8904 EventLog: EventClass = 2, EventInfo = 8040100. Param1 = a00a, Param2 = 0. Param3 = 0, Param4 = 0. FMAP: area COREBOOT found @ 200 (8388096 bytes) CBFS @ 200 size 7ffe00 CBFS: 'COREBOOT Locator' located CBFS at [200:800000) CBFS: Locating 'AGESA' CBFS: Found @ offset 5ffdc0 size a8904 EventLog: EventClass = 2, EventInfo = 8040100. Param1 = a00a, Param2 = 0. Param3 = 0, Param4 = 0. FMAP: area COREBOOT found @ 200 (8388096 bytes) CBFS @ 200 size 7ffe00 CBFS: 'COREBOOT Locator' located CBFS at [200:800000) CBFS: Locating 'AGESA' CBFS: Found @ offset 5ffdc0 size a8904 EventLog: EventClass = 2, EventInfo = 8040100. Param1 = a00a, Param2 = 0. Param3 = 0, Param4 = 0. FMAP: area COREBOOT found @ 200 (8388096 bytes) CBFS @ 200 size 7ffe00 CBFS: 'COREBOOT Locator' located CBFS at [200:800000) CBFS: Locating 'AGESA' CBFS: Found @ offset 5ffdc0 size a8904 EventLog: EventClass = 2, EventInfo = 8040100. Param1 = a00a, Param2 = 0. Param3 = 0, Param4 = 0. FMAP: area COREBOOT found @ 200 (8388096 bytes) CBFS @ 200 size 7ffe00 CBFS: 'COREBOOT Locator' located CBFS at [200:800000) CBFS: Locating 'AGESA' CBFS: Found @ offset 5ffdc0 size a8904 EventLog: EventClass = 2, EventInfo = 8040100. Param1 = a00a, Param2 = 0. Param3 = 0, Param4 = 0. FMAP: area COREBOOT found @ 200 (8388096 bytes) CBFS @ 200 size 7ffe00 CBFS: 'COREBOOT Locator' located CBFS at [200:800000) CBFS: Locating 'AGESA' CBFS: Found @ offset 5ffdc0 size a8904 EventLog: EventClass = 2, EventInfo = 8040100. Param1 = a00a, Param2 = 0. Param3 = 0, Param4 = 0. FMAP: area COREBOOT found @ 200 (8388096 bytes) CBFS @ 200 size 7ffe00 CBFS: 'COREBOOT Locator' located CBFS at [200:800000) CBFS: Locating 'AGESA' CBFS: Found @ offset 5ffdc0 size a8904 EventLog: EventClass = 2, EventInfo = 8040100. Param1 = a00a, Param2 = 0. Param3 = 0, Param4 = 0. FMAP: area COREBOOT found @ 200 (8388096 bytes) CBFS @ 200 size 7ffe00 CBFS: 'COREBOOT Locator' located CBFS at [200:800000) CBFS: Locating 'AGESA' CBFS: Found @ offset 5ffdc0 size a8904 EventLog: EventClass = 2, EventInfo = 8040100. Param1 = a00a, Param2 = 0. Param3 = 0, Param4 = 0. FMAP: area COREBOOT found @ 200 (8388096 bytes) CBFS @ 200 size 7ffe00 CBFS: 'COREBOOT Locator' located CBFS at [200:800000) CBFS: Locating 'AGESA' CBFS: Found @ offset 5ffdc0 size a8904 EventLog: EventClass = 2, EventInfo = 8040100. Param1 = a00a, Param2 = 0. Param3 = 0, Param4 = 0. FMAP: area COREBOOT found @ 200 (8388096 bytes) CBFS @ 200 size 7ffe00 CBFS: 'COREBOOT Locator' located CBFS at [200:800000) CBFS: Locating 'AGESA' CBFS: Found @ offset 5ffdc0 size a8904 EventLog: EventClass = 2, EventInfo = 8040100. Param1 = a00a, Param2 = 0. Param3 = 0, Param4 = 0. FMAP: area COREBOOT found @ 200 (8388096 bytes) CBFS @ 200 size 7ffe00 CBFS: 'COREBOOT Locator' located CBFS at [200:800000) CBFS: Locating 'AGESA' CBFS: Found @ offset 5ffdc0 size a8904 EventLog: EventClass = 2, EventInfo = 8040100. Param1 = a00a, Param2 = 0. Param3 = 0, Param4 = 0. FMAP: area COREBOOT found @ 200 (8388096 bytes) CBFS @ 200 size 7ffe00 CBFS: 'COREBOOT Locator' located CBFS at [200:800000) CBFS: Locating 'AGESA' CBFS: Found @ offset 5ffdc0 size a8904 EventLog: EventClass = 2, EventInfo = 8040100. Param1 = a00a, Param2 = 0. Param3 = 0, Param4 = 0. FMAP: area COREBOOT found @ 200 (8388096 bytes) CBFS @ 200 size 7ffe00 CBFS: 'COREBOOT Locator' located CBFS at [200:800000) CBFS: Locating 'AGESA' CBFS: Found @ offset 5ffdc0 size a8904 EventLog: EventClass = 2, EventInfo = 8040100. Param1 = a00a, Param2 = 0. Param3 = 0, Param4 = 0. FMAP: area COREBOOT found @ 200 (8388096 bytes) CBFS @ 200 size 7ffe00 CBFS: 'COREBOOT Locator' located CBFS at [200:800000) CBFS: Locating 'AGESA' CBFS: Found @ offset 5ffdc0 size a8904 FMAP: area COREBOOT found @ 200 (8388096 bytes) CBFS @ 200 size 7ffe00 CBFS: 'COREBOOT Locator' located CBFS at [200:800000) CBFS: Locating 'AGESA' CBFS: Found @ offset 5ffdc0 size a8904 agesawrapper_amdinitpost() returned AGESA_WARNING CBMEM: IMD: root @ affff000 254 entries. IMD: root @ afffec00 62 entries. Move CAR stack. CAR disabled. agesawrapper_amdinitenv() entry Wiped HEAP at [10000000 - 1002ffff] FMAP: area COREBOOT found @ 200 (8388096 bytes) CBFS @ 200 size 7ffe00 CBFS: 'COREBOOT Locator' located CBFS at [200:800000) CBFS: Locating 'AGESA' CBFS: Found @ offset 5ffdc0 size a8904 FMAP: area COREBOOT found @ 200 (8388096 bytes) CBFS @ 200 size 7ffe00 CBFS: 'COREBOOT Locator' located CBFS at [200:800000) CBFS: Locating 'AGESA' CBFS: Found @ offset 5ffdc0 size a8904 Maybe it's ok to generate a board status from the 4.10 version? I have this version working... Regards, Jorge
First of all there is not even a single board status entry for bettong. Please upload one from the commit Kyösti pointed. Regarding the AMD_S3_SAVE, see coreboot/src/vendorcode/amd/pi/00660F01/AMD.h line 129 and later: /* When AMD rolled out CarrizoPI, they made a bad choice of removing * an entry from the middle of the enumeration list. */ #if 0 /* This was removed, shifting everything else up.*/ AMD_S3_SAVE = 0x0002C000, #endif I think Kyösti could share a little bit more details on that (commit 55fffa29c23). Regards, Michał On 03.12.2019 14:57, Jorge Fernandez Monteagudo wrote:
Here is a short guide how to upload board status:
https://github.com/coreboot/coreboot/blob/master/util/board_status/README
The system you are going to boot has to have cbmem installed. Hi Michal,
Do you have already any patch to test? I've updated to the last git and enabled the AMD Bettong board (it's disabled in Kconfig.name!) but it's not compiling. There are several errors:
1) src/drivers/amd/agesa/state_machine.c: In function 'ramstage_dispatch': src/drivers/amd/agesa/state_machine.c:216:8: error: 'AMD_S3_SAVE' undeclared (first use in this function); did you mean 'AMD_INIT_LATE'?
2) src/mainboard/amd/bettong/OemCustomize.c:130:6: error: no previous prototype for 'OemCustomizeInitEarly' [-Werror=missing-prototypes] VOID OemCustomizeInitEarly ( src/mainboard/amd/bettong/OemCustomize.c:149:6: error: no previous prototype for 'OemPostParams' [-Werror=missing-prototypes] void OemPostParams(AMD_POST_PARAMS *PostParams)
3) src/mainboard/amd/bettong/romstage.c:34:7: error: 'cpu_init_detectedx' undeclared (first use in this function); did you mean 'cpu_index'? if (!cpu_init_detectedx && boot_cpu()) { src/mainboard/amd/bettong/romstage.c:34:7: note: each undeclared identifier is reported only once for each function it appears in src/mainboard/amd/bettong/romstage.c:51:2: error: implicit declaration of function 'AGESAWRAPPER'; did you mean 'AGESA_READ_SPD'? [-Werror=implicit-function-declaration] AGESAWRAPPER(amdinitreset); src/mainboard/amd/bettong/romstage.c:51:15: error: 'amdinitreset' undeclared (first use in this function); did you mean 'AmdInitReset'? AGESAWRAPPER(amdinitreset); src/mainboard/amd/bettong/romstage.c:56:15: error: 'amdinitearly' undeclared (first use in this function); did you mean 'AmdInitEarly'? AGESAWRAPPER(amdinitearly); src/mainboard/amd/bettong/romstage.c:59:15: error: 'amdinitpost' undeclared (first use in this function); did you mean 'AmdInitPost'? AGESAWRAPPER(amdinitpost); src/mainboard/amd/bettong/romstage.c: In function 'agesa_postcar': src/mainboard/amd/bettong/romstage.c:65:15: error: 'amdinitenv' undeclared (first use in this function); did you mean 'AmdInitEnv'? AGESAWRAPPER(amdinitenv); src/mainboard/amd/bettong/romstage.c:28:13: error: 'romstage_main_template' defined but not used [-Werror=unused-function]
Regards, Jorge _______________________________________________ coreboot mailing list -- coreboot@coreboot.org To unsubscribe send an email to coreboot-leave@coreboot.org
-- Michał Żygowski Firmware Engineer http://3mdeb.com | @3mdeb_com
On Tue, Dec 3, 2019 at 4:35 PM Michal Zygowski <michal.zygowski@3mdeb.com> wrote:
I think Kyösti could share a little bit more details on that (commit 55fffa29c23).
Lots of things I could but will not volunteer to. I have every reason to believe any party requesting amd/bettong to be maintained, and having access to such board, has designed and potentially manufactured some custom board based on that particular reference design. Yet I have not seen this party contributing anything to the maintenance of the tree in the past 4 or so years. What goes around comes around, I don't mind amd/bettong disappearing at all. Kyösti
Lots of things I could but will not volunteer to. I have every reason to believe any party requesting amd/bettong to be maintained, and having access to such board, has designed and potentially manufactured some custom board based on that particular reference design. Yet I have not seen this party contributing anything to the maintenance of the tree in the past 4 or so years. What goes around comes around, I don't mind amd/bettong disappearing at all.
In my case I have a bettong and pademelon demoboards and i would like to get them supported by coreboot. We don't manufacture any product with these processors but maybe they are viable options in a near future. I've been able to make it work the vboot, a TPM/TPM2 through LPC and the SATA but there are minor changes that I don't mind to contribute. I think that I only can be useful to report the board status with every release but I think I'm not able to develop any feature on them. Regards Jorge
Hi, I noted this on this thread's companion regarding AGESA, but I'd be willing to put up some money on https://www.bountysource.com/ for migration away from ROMCC_BOOTBLOCK. I could have sworn asus/am1i-a mentioned over there was a BinaryPI board. Thoughts? Sincerely, -Matt On Wed, Dec 4, 2019 at 2:10 AM Jorge Fernandez Monteagudo <jorgefm@cirsa.com> wrote:
Lots of things I could but will not volunteer to. I have every reason to believe any party requesting amd/bettong to be maintained, and having access to such board, has designed and potentially manufactured some custom board based on that particular reference design. Yet I have not seen this party contributing anything to the maintenance of the tree in the past 4 or so years. What goes around comes around, I don't mind amd/bettong disappearing at all.
In my case I have a bettong and pademelon demoboards and i would like to get them supported by coreboot. We don't manufacture any product with these processors but maybe they are viable options in a near future.
I've been able to make it work the vboot, a TPM/TPM2 through LPC and the SATA but there are minor changes that I don't mind to contribute. I think that I only can be useful to report the board status with every release but I think I'm not able to develop any feature on them.
Regards Jorge _______________________________________________ coreboot mailing list -- coreboot@coreboot.org To unsubscribe send an email to coreboot-leave@coreboot.org
participants (4)
-
Jorge Fernandez Monteagudo -
Kyösti Mälkki -
Matt B -
Michal Zygowski