#103: flashrom: Don't exit() after successful erase operation -------------------------+-------------------------------------------------- Reporter: stuge | Owner: stuge Type: defect | Status: new Priority: major | Milestone: flashrom v1.0 Component: flashrom | Version: Resolution: | Keywords: erase exit Dependencies: | Patchstatus: there is no patch -------------------------+-------------------------------------------------- Changes (by stuge): * owner: somebody => stuge -- Ticket URL: <http://tracker.coreboot.org/trac/coreboot/ticket/103#comment:1> coreboot <http://www.coreboot.org/>

#103: flashrom: Don't exit() after successful erase -------------------------+-------------------------------------------------- Reporter: stuge | Owner: stuge Type: defect | Status: assigned Priority: major | Milestone: flashrom v1.0 Component: flashrom | Version: Resolution: | Keywords: erase exit Dependencies: | Patchstatus: patch needs review -------------------------+-------------------------------------------------- Changes (by stuge): * patchstatus: there is no patch => patch needs review -- Ticket URL: <http://tracker.linuxbios.org/trac/coreboot/ticket/103#comment:3> coreboot <http://www.coreboot.org/>

#103: flashrom: Don't exit() after successful erase; enable testing all operations in one invocation ----------------------------------+----------------------------------------- Reporter: stuge | Owner: stuge Type: enhancement | Status: assigned Priority: major | Milestone: flashrom v1.0 Component: flashrom | Version: Keywords: erase exit testing | Dependencies: #117 Patchstatus: patch needs review | ----------------------------------+----------------------------------------- Changes (by stuge): * keywords: erase exit => erase exit testing * dependencies: => #117 * type: defect => enhancement Comment: This allows -Er -Ew and -Ev but they are pretty useless. The point is that this allows -Ewv which will test erase, write and read (both during erase and verify) operations on the probed flash chip, so it's an easy way to exercise flash chip drivers. Currently the order of commands (-E -r -w -v) on the command line is not significant, if multiple commands are specified flashrom will always execute them in order ERASE READ WRITE VERIFY. This can be bad for users running -rE expecting to get a backup before the erase is done. A simple solution would be to change the order in main() into READ ERASE WRITE VERIFY, in which case the invocation: flashrom -rEwv org.bin will save the original contents, erase the chip and write back the original, verifying each step. -- Ticket URL: <http://tracker.coreboot.org/trac/coreboot/ticket/103#comment:5> coreboot <http://www.coreboot.org/>

#103: flashrom: Don't exit() after successful erase; enable testing all operations in one invocation ----------------------------------+----------------------------------------- Reporter: stuge | Owner: stuge Type: enhancement | Status: assigned Priority: major | Milestone: flashrom v1.0 Component: flashrom | Version: Keywords: erase exit testing | Dependencies: #117 Patchstatus: patch needs review | ----------------------------------+----------------------------------------- Changes (by stuge): * priority: minor => major Comment: I suggested adding -T in #106 (dup of this) and I closed it because the patch suggested here achieves the same thing but with the user interface -Ewv (already familiar options) instead of -T (which would be new). But if everyone is really serious about restricting what flashrom lets the user do - unless it is invoked a special way - I guess that's what we have to do, but I think it's silly. Let user shoot foot if they try - that's why I fell in love with UNIX anyway. (And I don't think simplifying the test procedure from many flashrom+hexdump commands into a single flashrom command is minor, so changing prio back.) -- Ticket URL: <http://tracker.coreboot.org/trac/coreboot/ticket/103#comment:7> coreboot <http://www.coreboot.org/>

#103: flashrom: Don't exit() after successful erase; enable testing all operations in one invocation ----------------------------------+----------------------------------------- Reporter: stuge | Owner: stuge Type: enhancement | Status: assigned Priority: major | Milestone: flashrom v1.0 Component: flashrom | Version: Keywords: erase exit testing | Dependencies: #117 Patchstatus: patch needs work | ----------------------------------+----------------------------------------- Changes (by stepan): * patchstatus: patch needs review => patch needs work Comment: It also does not necessarily do the same thing with the hardware as calling the single functions. Strictly, a reboot between any of the tests would be the most reliable way of testing flashrom. Answering Peter's concerns, if we're going to add a method of "simplifying flashrom tests" that is a new feature, and it should get a new option. Using -Erwv for that ignores that fact by adding a lot of implicit assumptions. Implicit assumptions are fatal for any user interface. Strictly speaking, -wv should be disallowed, too. Instead, write should guarantee that the write succeeded, or print an error otherwise. As should an erase make sure that the chip is erased, if the program exists without error. Other than that, we should stick with the small utility approach, and have the tool do one thing at a time. -- Ticket URL: <http://tracker.coreboot.org/trac/coreboot/ticket/103#comment:9> coreboot <http://www.coreboot.org/>

#103: flashrom: Don't exit() after successful erase; enable testing all operations in one invocation ----------------------------------+----------------------------------------- Reporter: stuge | Owner: stuge Type: enhancement | Status: assigned Priority: major | Milestone: flashrom v1.0 Component: flashrom | Version: Keywords: erase exit testing | Dependencies: #117 Patchstatus: patch needs work | ----------------------------------+----------------------------------------- Comment(by hailfinger): We now have auto-erase for write and auto-verify for erase and write. Combining -Erwv does not make sense anymore, but a separate -T parameter for a full test would indeed be helpful. Not sure if I should close this ticket. -- Ticket URL: <http://tracker.coreboot.org/trac/coreboot/ticket/103#comment:11> coreboot <http://www.coreboot.org/>

#103: flashrom: Add -T to test all operations in one invocation -----------------------------------------------------------+---------------- Reporter: stuge | Owner: hailfinger Type: enhancement | Status: assigned Priority: major | Milestone: flashrom v1.0 Component: flashrom (please use trac on flashrom.org) | Keywords: testing Dependencies: #117 | Patchstatus: there is no patch -----------------------------------------------------------+---------------- Changes (by hailfinger): * status: new => assigned Comment: I have a patch for this, but it needs partial write support, and that will be added post 0.9.2. -- Ticket URL: <https://tracker.coreboot.org/trac/coreboot/ticket/103#comment:13> coreboot <http://www.coreboot.org/>