Patch for ST M50FLW080A support (now with Signed-off-by - Line)
The generic jedec.c does not work for the ST M50FLW flash devices, because they need an unlock command first. For this reason, ST M50FLW support is moved to a new HW support module, because any change in jedec.c would bear the risk to cause problems with the already supported devices. It's already tested with ST M50FLW080A; the other chips of this family i dont have available, so i couldnt test it. Signed-off-by: Claus Gindhart <claus.gindhart@kontron.com> --- Mit freundlichen Grüßen / Best regards Claus Gindhart SW R&D Kontron Modular Computers phone :++49 (0)8341-803-374 mailto:claus.gindhart@kontron.com http://www.kontron.com Kontron Modular Computers GmbH Geschaeftsfuehrer / Managing Directors: Ulrich Gehrmann, Thomas Sabisch Sitz der Gesellschaft / Registered Office: Kaufbeuren, Rechtsform / Legal: GmbH Amtsgericht / Local District Court Kempten, HRB Nr. / Trade Register No. 6195 The information contained in this document is CONFIDENTIAL and property of Kontron. Any unauthorized review, use, disclosure or distribution is prohibited without express written consent of Kontron. If you are not the intended recipient, please contact the sender and destroy all copies of the original message and enclosed attachments. Diese E-Mail enthält vertrauliche und/oder rechtlich geschützte Informationen und ist Eigentum von Kontron. Die Verwendung und Weitergabe von jeglichen Inhalten ist ohne ausdrückliche schriftliche Genehmigung von Kontron strikt untersagt. Wenn Sie diese E-Mail irrtümlich erhalten haben, informieren Sie bitte sofort den Absender und vernichten diese Mail und enthaltene Dokumente.
Claus Gindhart wrote:
The generic jedec.c does not work for the ST M50FLW flash devices, because they need an unlock command first. For this reason, ST M50FLW support is moved to a new HW support module, because any change in jedec.c would bear the risk to cause problems with the already supported devices. It's already tested with ST M50FLW080A; the other chips of this family i dont have available, so i couldnt test it.
Signed-off-by: Claus Gindhart <claus.gindhart@kontron.com>
Due to your commit message and the many TODOs in jedec.c that file was ommitted. The rest is commited in r3274. Thank you very much for your contribution. -- coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br. Tel.: +49 761 7668825 • Fax: +49 761 7664613 Email: info@coresystems.de • http://www.coresystems.de/ Registergericht: Amtsgericht Freiburg • HRB 7656 Geschäftsführer: Stefan Reinauer • Ust-IdNr.: DE245674866
On 28.04.2008 19:56, Stefan Reinauer wrote:
Claus Gindhart wrote:
The generic jedec.c does not work for the ST M50FLW flash devices, because they need an unlock command first. For this reason, ST M50FLW support is moved to a new HW support module, because any change in jedec.c would bear the risk to cause problems with the already supported devices. It's already tested with ST M50FLW080A; the other chips of this family i dont have available, so i couldnt test it.
Signed-off-by: Claus Gindhart <claus.gindhart@kontron.com>
Due to your commit message and the many TODOs in jedec.c that file was ommitted. The rest is commited in r3274.
Thank you very much for your contribution.
This was a bit too fast. The probe function looks like an exact copy of probe_jedec and can be dropped. The flashrom restructuring I have in mind benefits from a reduction of probe functions and allows faster+generic probing. Regards, Carl-Daniel
On Mon, Apr 28, 2008 at 09:40:51PM +0200, Carl-Daniel Hailfinger wrote:
The rest is commited in r3274.
This was a bit too fast.
I agree. The sentiment of the patch was good, but it needed some more work, moving some functions around, I don't like chip-specific code in jedec.c, that sort-of defeats the purpose. Oh well. //Peter
Carl-Daniel Hailfinger wrote:
On 28.04.2008 19:56, Stefan Reinauer wrote:
Claus Gindhart wrote:
The generic jedec.c does not work for the ST M50FLW flash devices, because they need an unlock command first. For this reason, ST M50FLW support is moved to a new HW support module, because any change in jedec.c would bear the risk to cause problems with the already supported devices. It's already tested with ST M50FLW080A; the other chips of this family i dont have available, so i couldnt test it.
Signed-off-by: Claus Gindhart <claus.gindhart@kontron.com>
Due to your commit message and the many TODOs in jedec.c that file was ommitted. The rest is commited in r3274.
Thank you very much for your contribution.
This was a bit too fast. The probe function looks like an exact copy of probe_jedec and can be dropped. The flashrom restructuring I have in mind benefits from a reduction of probe functions and allows faster+generic probing.
While I don't think probing speed is anywhere close to crucial at the moment, your patches are of course welcome. Until they appear, I don't see any problems with the current commit. Stefan
Peter Stuge wrote:
On Mon, Apr 28, 2008 at 09:40:51PM +0200, Carl-Daniel Hailfinger wrote:
The rest is commited in r3274.
This was a bit too fast.
I agree. The sentiment of the patch was good, but it needed some more work, moving some functions around, I don't like chip-specific code in jedec.c, that sort-of defeats the purpose. Oh well.
This is what you, the community, should take as a task for vendor contributed patches. Feel free to improve. Obviously any piece of code in the world can be improved to fit the taste of you guys out there, this is no reason to keep improvements out of coreboot as they happen. That's the great deal of open source and version control.. ;-) Stefan
On Tue, Apr 29, 2008 at 02:11:56AM +0200, Stefan Reinauer wrote:
I agree. The sentiment of the patch was good, but it needed some more work
This is what you, the community, should take as a task for vendor contributed patches. Feel free to improve.
Yep. I had actually started to do so but got interrupted and when I got back there was the commit. :) My own fault for not letting list know I was hacking.
no reason to keep improvements out of coreboot as they happen.
I can agree with that. //Peter
participants (4)
-
Carl-Daniel Hailfinger -
Claus Gindhart -
Peter Stuge -
Stefan Reinauer