[LinuxBIOS] [PATCH][v3] Drop superfluous round()
See patch. Do we want align_up()/align_down() in lib.c maybe? Uwe. -- http://www.hermann-uwe.de | http://www.holsham-traders.de http://www.crazy-hacks.org | http://www.unmaintained-free-software.org
* Uwe Hermann <uwe@hermann-uwe.de> [070706 16:34]:
See patch.
Do we want align_up()/align_down() in lib.c maybe?
Since it operates on resources, I think no.
Drop the round() function, as it is an exact copy of align_up().
Also, make align_up()/align_down() non-static as they are useful even outside of device/device_util.c.
Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de> Acked-by: Stefan Reinauer <stepan@coresystems.de>
-- coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br. Tel.: +49 761 7668825 • Fax: +49 761 7664613 Email: info@coresystems.de • http://www.coresystems.de/ Registergericht: Amtsgericht Freiburg • HRB 7656 Geschäftsführer: Stefan Reinauer • Ust-IdNr.: DE245674866
On Fri, Jul 06, 2007 at 07:44:12PM +0200, Stefan Reinauer wrote:
* Uwe Hermann <uwe@hermann-uwe.de> [070706 16:34]:
See patch.
Do we want align_up()/align_down() in lib.c maybe?
Since it operates on resources, I think no.
It's not specific to resources, though. We could change it to operate on u64 variables, I think that should work fine. I'll see if I can make a patch.
Acked-by: Stefan Reinauer <stepan@coresystems.de>
Thanks, r437. Uwe. -- http://www.hermann-uwe.de | http://www.holsham-traders.de http://www.crazy-hacks.org | http://www.unmaintained-free-software.org
participants (2)
-
Stefan Reinauer -
Uwe Hermann