Change in ...coreboot[master]: mb/google/sarien: Enable Bluetooth RF kill
Lijian Zhao has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32124 Change subject: mb/google/sarien: Enable Bluetooth RF kill ...................................................................... mb/google/sarien: Enable Bluetooth RF kill Add bluetooth Rfkill function to recover the Bluetooth controller in cases where itself has entered a bad state and needs to be recovered. Bug=b:123342945 TEST=Boot up into OS and dump SSDT table, check there's _DSD entry under Bluetooth devices with GPIO in. Also confirm bluetooth itself is functional. Signed-off-by: Lijian Zhao <lijian.zhao@intel.com> Change-Id: I79a310a55d94d7d20d1705afc11fe47cbb81abc1 --- M src/mainboard/google/sarien/variants/sarien/devicetree.cb 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/32124/1 diff --git a/src/mainboard/google/sarien/variants/sarien/devicetree.cb b/src/mainboard/google/sarien/variants/sarien/devicetree.cb index 2714b60..72dea1e 100644 --- a/src/mainboard/google/sarien/variants/sarien/devicetree.cb +++ b/src/mainboard/google/sarien/variants/sarien/devicetree.cb @@ -264,6 +264,7 @@ chip drivers/usb/acpi register "desc" = ""Bluetooth"" register "type" = "UPC_TYPE_INTERNAL" + register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_H15)" device usb 2.9 on end end chip drivers/usb/acpi -- To view, visit https://review.coreboot.org/c/coreboot/+/32124 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I79a310a55d94d7d20d1705afc11fe47cbb81abc1 Gerrit-Change-Number: 32124 Gerrit-PatchSet: 1 Gerrit-Owner: Lijian Zhao <lijian.zhao@intel.com> Gerrit-MessageType: newchange
Hello Shaunak Saha, EricR Lai, Bora Guvendik, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/32124 to look at the new patch set (#2). Change subject: mb/google/sarien: Enable Bluetooth RF kill ...................................................................... mb/google/sarien: Enable Bluetooth RF kill Add bluetooth Rfkill function to recover the Bluetooth controller in cases where itself has entered a bad state and needs to be recovered. Bug=b:129375810 TEST=Boot up into OS and dump SSDT table, check there's _DSD entry under Bluetooth devices with GPIO in. Also confirm bluetooth itself is functional. Signed-off-by: Lijian Zhao <lijian.zhao@intel.com> Change-Id: I79a310a55d94d7d20d1705afc11fe47cbb81abc1 --- M src/mainboard/google/sarien/variants/sarien/devicetree.cb 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/32124/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/32124 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I79a310a55d94d7d20d1705afc11fe47cbb81abc1 Gerrit-Change-Number: 32124 Gerrit-PatchSet: 2 Gerrit-Owner: Lijian Zhao <lijian.zhao@intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik@intel.com> Gerrit-Reviewer: EricR Lai <ericr_lai@compal.corp-partner.google.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao@intel.com> Gerrit-Reviewer: Shaunak Saha <shaunak.saha@intel.corp-partner.google.com> Gerrit-MessageType: newpatchset
Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32124 ) Change subject: mb/google/sarien: Enable Bluetooth RF kill ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/32124 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I79a310a55d94d7d20d1705afc11fe47cbb81abc1 Gerrit-Change-Number: 32124 Gerrit-PatchSet: 2 Gerrit-Owner: Lijian Zhao <lijian.zhao@intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik@intel.com> Gerrit-Reviewer: Duncan Laurie <dlaurie@chromium.org> Gerrit-Reviewer: EricR Lai <ericr_lai@compal.corp-partner.google.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao@intel.com> Gerrit-Reviewer: Shaunak Saha <shaunak.saha@intel.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Comment-Date: Fri, 29 Mar 2019 21:54:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32124 ) Change subject: mb/google/sarien: Enable Bluetooth RF kill ...................................................................... mb/google/sarien: Enable Bluetooth RF kill Add bluetooth Rfkill function to recover the Bluetooth controller in cases where itself has entered a bad state and needs to be recovered. Bug=b:129375810 TEST=Boot up into OS and dump SSDT table, check there's _DSD entry under Bluetooth devices with GPIO in. Also confirm bluetooth itself is functional. Signed-off-by: Lijian Zhao <lijian.zhao@intel.com> Change-Id: I79a310a55d94d7d20d1705afc11fe47cbb81abc1 Reviewed-on: https://review.coreboot.org/c/coreboot/+/32124 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Duncan Laurie <dlaurie@chromium.org> --- M src/mainboard/google/sarien/variants/sarien/devicetree.cb 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Duncan Laurie: Looks good to me, approved diff --git a/src/mainboard/google/sarien/variants/sarien/devicetree.cb b/src/mainboard/google/sarien/variants/sarien/devicetree.cb index 2714b60..72dea1e 100644 --- a/src/mainboard/google/sarien/variants/sarien/devicetree.cb +++ b/src/mainboard/google/sarien/variants/sarien/devicetree.cb @@ -264,6 +264,7 @@ chip drivers/usb/acpi register "desc" = ""Bluetooth"" register "type" = "UPC_TYPE_INTERNAL" + register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_H15)" device usb 2.9 on end end chip drivers/usb/acpi -- To view, visit https://review.coreboot.org/c/coreboot/+/32124 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I79a310a55d94d7d20d1705afc11fe47cbb81abc1 Gerrit-Change-Number: 32124 Gerrit-PatchSet: 3 Gerrit-Owner: Lijian Zhao <lijian.zhao@intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik@intel.com> Gerrit-Reviewer: Duncan Laurie <dlaurie@chromium.org> Gerrit-Reviewer: EricR Lai <ericr_lai@compal.corp-partner.google.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao@intel.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Shaunak Saha <shaunak.saha@intel.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-MessageType: merged
participants (3)
-
Duncan Laurie (Code Review) -
Lijian Zhao (Code Review)
-
Patrick Georgi (Code Review)