Attention is currently required from: Raul Rangel, Furquan Shaikh, Martin Roth, Eric Peers. Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55148 ) Change subject: mb/google/guybrush/var/guybrush: Update GPIO configuration ...................................................................... Patch Set 3: (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/55148/comment/1bb27a94_cf47ecb9 PS1, Line 14: TP183

it was unused. Ought to comment as such. https://b.corp.google. […] Marked it as NC in board ID 1.

https://review.coreboot.org/c/coreboot/+/55148/comment/b3ad3c67_0e52ff6e PS1, Line 20: TEST=Build Guybrush mainboard.

probably need a boot board id #1 as well and confirm Speaker and reset are working. […] Done

File src/mainboard/google/guybrush/variants/guybrush/gpio.c: https://review.coreboot.org/c/coreboot/+/55148/comment/d96a4b77_c64a18c0 PS1, Line 14: HIGH

1. […] There is some history involved. Initially EN_SPKR was tied to a 3.3 V GPIO whereas the speaker amplifier operates at 1.8 V level. To handle that, a rework was performed and the board version was incremented to identify the boards with that rework.

Later we realized that board version was not the right approach to identify the rework. Hence decided to reclaim the board version 2 for the upcoming hardware build. So the speaker is enabled by default on boards with or without audio reworks. This is a safe assumption since the rework is done in all the boards (with board ID1). -- To view, visit https://review.coreboot.org/c/coreboot/+/55148 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I31523b3e03d2b59577f33eae548747834cfc98aa Gerrit-Change-Number: 55148 Gerrit-PatchSet: 3 Gerrit-Owner: Karthik Ramasubramanian <kramasub@google.com> Gerrit-Reviewer: Eric Peers <epeers@google.com> Gerrit-Reviewer: Furquan Shaikh <furquan@google.com> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Raul Rangel <rrangel@chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Attention: Raul Rangel <rrangel@chromium.org> Gerrit-Attention: Furquan Shaikh <furquan@google.com> Gerrit-Attention: Martin Roth <martinroth@google.com> Gerrit-Attention: Eric Peers <epeers@google.com> Gerrit-Comment-Date: Thu, 03 Jun 2021 21:46:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh <furquan@google.com> Comment-In-Reply-To: Eric Peers <epeers@google.com> Gerrit-MessageType: comment