Attention is currently required from: Bora Guvendik, Anil Kumar K, Cliff Huang, Subrata Banik, Paul Menzel, Thejaswani Putta. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61354 ) Change subject: drivers/wwan/fm: Add Fibocom 5G WWAN ACPI support ...................................................................... Patch Set 8: (1 comment) File src/drivers/wwan/fm/acpi_fm350gl.c: https://review.coreboot.org/c/coreboot/+/61354/comment/677d6a7f_53efc3ca PS7, Line 55: acpigen_write_if_lequal_op_int(LOCAL0_OP, 0); : if (wwan_fm350gl_get_rtd3_method_support(config) | ACPI_PCIE_RP_EMIT_L23) : acpigen_emit_namestring(acpi_device_path_join(parent_dev, "DL23")); : /* assert PERST# pin */ : acpigen_enable_tx_gpio(&config->perst_gpio);

Sorry am I misreading the logic here? […] nevermind, I misremembered that acpigen_get_tx_gpio() will invert the signal if it's active-low 👍

-- To view, visit https://review.coreboot.org/c/coreboot/+/61354 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1e0b9fd405f6cfb1e216ea27558bb9299a09e566 Gerrit-Change-Number: 61354 Gerrit-PatchSet: 8 Gerrit-Owner: Cliff Huang <cliff.huang@intel.com> Gerrit-Reviewer: Anil Kumar K <anil.kumar.k@intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik@intel.com> Gerrit-Reviewer: Selma Bensaid <selma.bensaid@intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik@google.com> Gerrit-Reviewer: Thejaswani Putta <thejaswani.putta@intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak@chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Paul Menzel <paulepanter@mailbox.org> Gerrit-Attention: Bora Guvendik <bora.guvendik@intel.com> Gerrit-Attention: Anil Kumar K <anil.kumar.k@intel.com> Gerrit-Attention: Cliff Huang <cliff.huang@intel.com> Gerrit-Attention: Subrata Banik <subratabanik@google.com> Gerrit-Attention: Paul Menzel <paulepanter@mailbox.org> Gerrit-Attention: Thejaswani Putta <thejaswani.putta@intel.com> Gerrit-Comment-Date: Thu, 03 Feb 2022 17:16:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak@chromium.org> Gerrit-MessageType: comment