[L] Change in coreboot[main]: soc/mediatek/mt8188: devapc: Update permission for master domain setup
Attention is currently required from: Hung-Te Lin, Paul Menzel, Yu-Ping Wu, jason-ch chen. Hello Hung-Te Lin, Yidi Lin, Yu-Ping Wu, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/77861?usp=email to look at the new patch set (#7). Change subject: soc/mediatek/mt8188: devapc: Update permission for master domain setup ...................................................................... soc/mediatek/mt8188: devapc: Update permission for master domain setup Currently, all the masters controlled by DAPC are in domain 0. With this setting, there is a potential security problem. For example, if a certain master is somehow hacked, it may attempt to access registers that it is not supposed to, with successful results. This is due to the fact that, in the current setting, all masters are in domain 0 and can access almost all registers. To prevent this problem, we assign masters to different domains and restrict access to registers based on each domain. This patch updates the permission settings for domains 2, 3, 4, 5, 7, 8, 9, and 14, as these domains will be assigned masters in the upcoming patch. BUG=b:270657858 TEST=build pass Change-Id: I6e95ddb5d84a09ff865d7615596430e25b69d3fc Signed-off-by: Nina Wu <nina-cm.wu@mediatek.com> Signed-off-by: Jason Chen <Jason-ch.Chen@mediatek.com> --- M src/soc/mediatek/mt8188/devapc.c M src/soc/mediatek/mt8188/include/soc/addressmap.h M src/soc/mediatek/mt8188/include/soc/devapc.h 3 files changed, 284 insertions(+), 119 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/77861/7 -- To view, visit https://review.coreboot.org/c/coreboot/+/77861?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I6e95ddb5d84a09ff865d7615596430e25b69d3fc Gerrit-Change-Number: 77861 Gerrit-PatchSet: 7 Gerrit-Owner: jason-ch chen <Jason-ch.Chen@mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte@chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin@google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Nina-CM Wu <nina-cm.wu@mediatek.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter@mailbox.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer@coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte@chromium.org> Gerrit-Attention: jason-ch chen <Jason-ch.Chen@mediatek.com> Gerrit-Attention: Paul Menzel <paulepanter@mailbox.org> Gerrit-Attention: Yu-Ping Wu <yupingso@google.com> Gerrit-MessageType: newpatchset
participants (1)
-
jason-ch chen (Code Review)