Attention is currently required from: Arthur Heymans, Eran Mitrani, Jakub Czapiga, Jérémy Compostella, Kapil Porwal, Nick Vaccaro, Tarun. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77886?usp=email ) Change subject: drivers/intel/gma/opregion: Use CBFS cache to load VBT ...................................................................... Patch Set 33: (1 comment) File src/drivers/intel/gma/opregion.c: https://review.coreboot.org/c/coreboot/+/77886/comment/e661bfc8_a00f66ee : PS4, Line 27: cbfs_map

I find this quite confusing. The way you describe it, I see no difference to […] NB. Looking at the code below and the history of the static array, it looks like it was never necessary. We eventually copy the VBT to CBMEM anyway. So there shouldn't be a need to map twice. Probably just a shortcut that was taken when adding FSP/GOP support.

-- To view, visit https://review.coreboot.org/c/coreboot/+/77886?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I1e37e718a71bd85b0d7dee1efc4c0391798f16f7 Gerrit-Change-Number: 77886 Gerrit-PatchSet: 33 Gerrit-Owner: Jérémy Compostella <jeremy.compostella@intel.com> Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz> Gerrit-Reviewer: Eran Mitrani <mitrani@google.com> Gerrit-Reviewer: Jakub Czapiga <czapiga@google.com> Gerrit-Reviewer: Julius Werner <jwerner@chromium.org> Gerrit-Reviewer: Kapil Porwal <kapilporwal@google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro@chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik@google.com> Gerrit-Reviewer: Tarun <tstuli@gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Nico Huber <nico.h@gmx.de> Gerrit-Attention: Eran Mitrani <mitrani@google.com> Gerrit-Attention: Jakub Czapiga <czapiga@google.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella@intel.com> Gerrit-Attention: Kapil Porwal <kapilporwal@google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro@chromium.org> Gerrit-Attention: Arthur Heymans <arthur@aheymans.xyz> Gerrit-Attention: Tarun <tstuli@gmail.com> Gerrit-Comment-Date: Tue, 31 Oct 2023 23:53:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h@gmx.de> Comment-In-Reply-To: Jérémy Compostella <jeremy.compostella@intel.com> Comment-In-Reply-To: Julius Werner <jwerner@chromium.org> Comment-In-Reply-To: Arthur Heymans <arthur@aheymans.xyz> Gerrit-MessageType: comment