Attention is currently required from: Julius Werner, Swathi Tamilselvan. Subrata Banik has posted comments on this change by Swathi Tamilselvan. ( https://review.coreboot.org/c/coreboot/+/88190?usp=email ) Change subject: soc/qualcomm/common: Update QUP register structure for QUP v3.2 ...................................................................... Patch Set 4: (1 comment) File src/soc/qualcomm/common/clock.c: https://review.coreboot.org/c/coreboot/+/88190/comment/0ae08218_ca88d8d4?usp... : PS4, Line 138: else

This will be true for WRAP2 as well.

I missed this part during the review. for platform w/ QC_COMMON_QUPV3_2 Kconfig, we wish to program all three QUP wraps isn't it. -- To view, visit https://review.coreboot.org/c/coreboot/+/88190?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I304012d72a1af33510dcd620953367f0a9e98ac1 Gerrit-Change-Number: 88190 Gerrit-PatchSet: 4 Gerrit-Owner: Swathi Tamilselvan <tswathi@qualcomm.corp-partner.google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal@google.com> Gerrit-Reviewer: Subrata Banik <subratabanik@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Julius Werner <jwerner@chromium.org> Gerrit-Attention: Julius Werner <jwerner@chromium.org> Gerrit-Attention: Swathi Tamilselvan <tswathi@qualcomm.corp-partner.google.com> Gerrit-Comment-Date: Mon, 30 Jun 2025 16:35:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Kapil Porwal <kapilporwal@google.com>