Attention is currently required from: Fred Reitberger, Jason Glenesk, Matt DeVillier, Maximilian Brune. Felix Held has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/84574?usp=email ) Change subject: soc/amd/glinda-phoenix: Update pci int defs ...................................................................... Patch Set 2: (1 comment) Patchset: PS2:

misc1 and misc2 are hpet_l and hpet_h. […] see register descriptions at the beginning of the FCH registers chapter for those two IOx00C01_x0A [Intr_Misc1Map] (FCH::IO::IntrMisc1Map) IOx00C01_x0B [Intr_Misc2Map] (FCH::IO::IntrMisc2Map)

i'd say that having them named with what they do makes things a bit clearer. to ge the best of both, maybe do this like in the smi.h file: #define PIRQ_MISC1 0x0a /* Miscellaneous1 IRQ Settings */ #define PIRQ_HPET_L PIRQ_MISC1 #define PIRQ_MISC2 0x0b /* Miscellaneous2 IRQ Settings */ #define PIRQ_HPET_H PIRQ_MISC2 -- To view, visit https://review.coreboot.org/c/coreboot/+/84574?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I64f685e507e1cd5ee90e1b18526b9d59ed4c1b34 Gerrit-Change-Number: 84574 Gerrit-PatchSet: 2 Gerrit-Owner: Maximilian Brune <maximilian.brune@9elements.com> Gerrit-Reviewer: Felix Held <felix-coreboot@felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred@gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk@gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier@amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Paul Menzel <paulepanter@mailbox.org> Gerrit-Attention: Jason Glenesk <jason.glenesk@gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier@amd.corp-partner.google.com> Gerrit-Attention: Maximilian Brune <maximilian.brune@9elements.com> Gerrit-Attention: Fred Reitberger <reitbergerfred@gmail.com> Gerrit-Comment-Date: Mon, 30 Sep 2024 16:21:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Held <felix-coreboot@felixheld.de>