Change in coreboot[master]: sb/intel/bd82x6x/smbus.c: Remove dead assignment
HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44290 ) Change subject: sb/intel/bd82x6x/smbus.c: Remove dead assignment ...................................................................... sb/intel/bd82x6x/smbus.c: Remove dead assignment Change-Id: I91d4f925803aaceea8a5c5d0d4e2c44a6b135aec Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr> --- M src/southbridge/intel/bd82x6x/smbus.c 1 file changed, 0 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/44290/1 diff --git a/src/southbridge/intel/bd82x6x/smbus.c b/src/southbridge/intel/bd82x6x/smbus.c index 7a00cf4..b8d7d31 100644 --- a/src/southbridge/intel/bd82x6x/smbus.c +++ b/src/southbridge/intel/bd82x6x/smbus.c @@ -65,9 +65,6 @@ res->limit = res->base + res->size - 1; res->flags = IORESOURCE_IO | IORESOURCE_FIXED | IORESOURCE_RESERVE | IORESOURCE_STORED | IORESOURCE_ASSIGNED; - - /* Also add MMIO resource */ - res = pci_get_resource(dev, PCI_BASE_ADDRESS_0); } static const char *smbus_acpi_name(const struct device *dev) -- To view, visit https://review.coreboot.org/c/coreboot/+/44290 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I91d4f925803aaceea8a5c5d0d4e2c44a6b135aec Gerrit-Change-Number: 44290 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-MessageType: newchange
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44290 ) Change subject: sb/intel/bd82x6x/smbus.c: Remove dead assignment ...................................................................... Patch Set 1: Code-Review-1 (1 comment) https://review.coreboot.org/c/coreboot/+/44290/1/src/southbridge/intel/bd82x... File src/southbridge/intel/bd82x6x/smbus.c: https://review.coreboot.org/c/coreboot/+/44290/1/src/southbridge/intel/bd82x... PS1, Line 70: pci_get_resource You also remove pci_get_resource -- To view, visit https://review.coreboot.org/c/coreboot/+/44290 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I91d4f925803aaceea8a5c5d0d4e2c44a6b135aec Gerrit-Change-Number: 44290 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Sat, 08 Aug 2020 16:13:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44290 ) Change subject: sb/intel/bd82x6x/smbus.c: Remove dead assignment ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/c/coreboot/+/44290/1/src/southbridge/intel/bd82x... File src/southbridge/intel/bd82x6x/smbus.c: https://review.coreboot.org/c/coreboot/+/44290/1/src/southbridge/intel/bd82x... PS1, Line 70: pci_get_resource
You also remove pci_get_resource indeed, thank you.
why don't we also use pci_get_resource for i82801gx/smbus.c -- To view, visit https://review.coreboot.org/c/coreboot/+/44290 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I91d4f925803aaceea8a5c5d0d4e2c44a6b135aec Gerrit-Change-Number: 44290 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Sat, 08 Aug 2020 16:37:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Patrick Rudolph <siro@das-labor.org> Gerrit-MessageType: comment
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44290 ) Change subject: sb/intel/bd82x6x/smbus.c: Remove dead assignment ...................................................................... Patch Set 1: Code-Review-1 -- To view, visit https://review.coreboot.org/c/coreboot/+/44290 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I91d4f925803aaceea8a5c5d0d4e2c44a6b135aec Gerrit-Change-Number: 44290 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Sat, 08 Aug 2020 16:41:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/44290 ) Change subject: sb/intel/bd82x6x/smbus.c: Remove dead assignment ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/44290 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I91d4f925803aaceea8a5c5d0d4e2c44a6b135aec Gerrit-Change-Number: 44290 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-MessageType: abandon
participants (2)
-
HAOUAS Elyes (Code Review) -
Patrick Rudolph (Code Review)