Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29651 ) Change subject: soc/intel/cannonlake: Program HD Audio SVID/SSID ...................................................................... Patch Set 4:

Patch Set 1:

Could we do this at the SOC level?

If we had a Kconfig entry in the SOC that allowed the mainboard to define an HDA codec device ID then the SOC level code could have this structure (filled with CONFIG_SUBSYSTEM_VENDOR_ID and something like CONFIG_HDA_CODEC_ID) and pass it to FSP if HDA is enabled.

Done, moved to SOC level and add HDA_CODEC_ID -- To view, visit https://review.coreboot.org/c/coreboot/+/29651 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I25e22313fd99479f1a2f68636a2eab83126ca488 Gerrit-Change-Number: 29651 Gerrit-PatchSet: 4 Gerrit-Owner: Lijian Zhao <lijian.zhao@intel.com> Gerrit-Reviewer: Jairaj Arava <jairaj.arava@intel.com> Gerrit-Reviewer: Krzysztof M Sywula <krzysztof.m.sywula@intel.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao@intel.com> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati@intel.com> Gerrit-Reviewer: Sathyanarayana Nujella <sathyanarayana.nujella@intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik@intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Duncan Laurie <dlaurie@chromium.org> Gerrit-Comment-Date: Fri, 30 Nov 2018 23:49:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment