Change in coreboot[master]: RFC) src/acpi: Update license headers to SPDX
Martin Roth has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36176 ) Change subject: RFC) src/acpi: Update license headers to SPDX ...................................................................... RFC) src/acpi: Update license headers to SPDX While I was working on updating the headers to move copyrights into the AUTHORS file, I got a request to switch to SPDX headers as well. Linux has moved completely to SPDX headers, which are easier to maintain, have good definitions, are very short, and can be checked automatically. This is completely unlike our current header situation. Signed-off-by: Martin Roth <martin@coreboot.org> Change-Id: Ie86d34f7fa7bf7434ad8a38aa1eadcfece7124b3 --- M src/acpi/Kconfig M src/acpi/Makefile.inc M src/acpi/sata.c M src/acpi/sata.h 4 files changed, 9 insertions(+), 24 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/36176/1 diff --git a/src/acpi/Kconfig b/src/acpi/Kconfig index 72cfff5..3c6aeb1 100644 --- a/src/acpi/Kconfig +++ b/src/acpi/Kconfig @@ -1,3 +1,5 @@ +# SPDX-License-Identifier: GPL-2.0-only +# This file is part of the coreboot project. config ACPI_SATA_GENERATOR bool diff --git a/src/acpi/Makefile.inc b/src/acpi/Makefile.inc index 53ac679..7c2092d 100644 --- a/src/acpi/Makefile.inc +++ b/src/acpi/Makefile.inc @@ -1 +1,4 @@ +# SPDX-License-Identifier: GPL-2.0-only +# This file is part of the coreboot project. + ramstage-$(CONFIG_ACPI_SATA_GENERATOR) += sata.c diff --git a/src/acpi/sata.c b/src/acpi/sata.c index d7fcbd6..ae43e7d 100644 --- a/src/acpi/sata.c +++ b/src/acpi/sata.c @@ -1,15 +1,5 @@ -/* - * This file is part of the coreboot project. - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License version 2 as - * published by the Free Software Foundation. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ +// SPDX-License-Identifier: GPL-2.0-only +/* This file is part of the coreboot project. */ #include "sata.h" diff --git a/src/acpi/sata.h b/src/acpi/sata.h index fecf4c6..04cd80c 100644 --- a/src/acpi/sata.h +++ b/src/acpi/sata.h @@ -1,15 +1,5 @@ -/* - * This file is part of the coreboot project. - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ +// SPDX-License-Identifier: GPL-2.0-only +/* This file is part of the coreboot project. */ #ifndef __ACPI_SATA_H__ #define __ACPI_SATA_H__ -- To view, visit https://review.coreboot.org/c/coreboot/+/36176 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie86d34f7fa7bf7434ad8a38aa1eadcfece7124b3 Gerrit-Change-Number: 36176 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth@google.com> Gerrit-MessageType: newchange
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36176 ) Change subject: RFC) src/acpi: Update license headers to SPDX ...................................................................... Patch Set 1: Code-Review+1 (2 comments) I like it somehow. Though, don't remember why we decided against it, the last time it came up. https://review.coreboot.org/c/coreboot/+/36176/1//COMMIT_MSG Commit Message: https://review.coreboot.org/c/coreboot/+/36176/1//COMMIT_MSG@12 PS1, Line 12: Linux has moved completely to SPDX headers I must have missed that. Or at least the DRM drivers I visit most often must have ;) https://review.coreboot.org/c/coreboot/+/36176/1/src/acpi/sata.h File src/acpi/sata.h: https://review.coreboot.org/c/coreboot/+/36176/1/src/acpi/sata.h@1 PS1, Line 1: // SPDX-License-Identifier: GPL-2.0-only No strong feelings about the SPDX. But is the C++ style // comment necessary? I don't mind too much, but mixing the styles seems odd. -- To view, visit https://review.coreboot.org/c/coreboot/+/36176 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie86d34f7fa7bf7434ad8a38aa1eadcfece7124b3 Gerrit-Change-Number: 36176 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Nico Huber <nico.h@gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Comment-Date: Mon, 21 Oct 2019 13:21:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36176 ) Change subject: RFC) src/acpi: Update license headers to SPDX ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/c/coreboot/+/36176/1/src/acpi/sata.h File src/acpi/sata.h: https://review.coreboot.org/c/coreboot/+/36176/1/src/acpi/sata.h@1 PS1, Line 1: // SPDX-License-Identifier: GPL-2.0-only
No strong feelings about the SPDX. But is the C++ style // comment necessary? […] I'm fine with either style. This is how it is in the Linux kernel, so I copied that. If we'd prefer C style comments instead, that works for me.
-- To view, visit https://review.coreboot.org/c/coreboot/+/36176 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie86d34f7fa7bf7434ad8a38aa1eadcfece7124b3 Gerrit-Change-Number: 36176 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Nico Huber <nico.h@gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Comment-Date: Mon, 21 Oct 2019 16:02:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h@gmx.de> Gerrit-MessageType: comment
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36176 ) Change subject: RFC) src/acpi: Update license headers to SPDX ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/c/coreboot/+/36176/1/src/acpi/sata.h File src/acpi/sata.h: https://review.coreboot.org/c/coreboot/+/36176/1/src/acpi/sata.h@1 PS1, Line 1: // SPDX-License-Identifier: GPL-2.0-only
I'm fine with either style. This is how it is in the Linux kernel, so I copied that. […] I'd go with C style, too, in a comment of its own to denote that it's a statement in itself: /* SPDX- ... */ /* This file is part ... */
-- To view, visit https://review.coreboot.org/c/coreboot/+/36176 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie86d34f7fa7bf7434ad8a38aa1eadcfece7124b3 Gerrit-Change-Number: 36176 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Aaron Durbin <adurbin@chromium.org> Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz> Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com> Gerrit-Reviewer: Furquan Shaikh <furquan@google.com> Gerrit-Reviewer: Julius Werner <jwerner@chromium.org> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki@gmail.com> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Nico Huber <nico.h@gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki@gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer@coreboot.org> Gerrit-Reviewer: Werner Zeh <werner.zeh@siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Reviewer: ron minnich <rminnich@gmail.com> Gerrit-Comment-Date: Mon, 21 Oct 2019 16:14:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h@gmx.de> Comment-In-Reply-To: Martin Roth <martinroth@google.com> Gerrit-MessageType: comment
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36176 ) Change subject: RFC) src/acpi: Update license headers to SPDX ...................................................................... Patch Set 1: +1. I prefer to the SPDX terseness. -- To view, visit https://review.coreboot.org/c/coreboot/+/36176 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie86d34f7fa7bf7434ad8a38aa1eadcfece7124b3 Gerrit-Change-Number: 36176 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Aaron Durbin <adurbin@chromium.org> Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz> Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com> Gerrit-Reviewer: Furquan Shaikh <furquan@google.com> Gerrit-Reviewer: Julius Werner <jwerner@chromium.org> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki@gmail.com> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Nico Huber <nico.h@gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki@gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer@coreboot.org> Gerrit-Reviewer: Werner Zeh <werner.zeh@siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Reviewer: ron minnich <rminnich@gmail.com> Gerrit-Comment-Date: Mon, 21 Oct 2019 17:25:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36176 ) Change subject: RFC) src/acpi: Update license headers to SPDX ...................................................................... Patch Set 1: Code-Review-1 (1 comment) https://review.coreboot.org/c/coreboot/+/36176/1/src/acpi/sata.h File src/acpi/sata.h: https://review.coreboot.org/c/coreboot/+/36176/1/src/acpi/sata.h@1 PS1, Line 1: // SPDX-License-Identifier: GPL-2.0-only
I'd go with C style, too, in a comment of its own to denote that it's a statement in itself: […] +1 to Patrick's suggestion.
Looking around at Linux, they seem inconsistent w.r.t. C vs. C++ style comments for the SPDX line. However, they are consistent with making the SPDX line its own comment, even if it mixes the two styles (which I think is ugly). I prefer C-style for both. -- To view, visit https://review.coreboot.org/c/coreboot/+/36176 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie86d34f7fa7bf7434ad8a38aa1eadcfece7124b3 Gerrit-Change-Number: 36176 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Aaron Durbin <adurbin@chromium.org> Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz> Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com> Gerrit-Reviewer: Furquan Shaikh <furquan@google.com> Gerrit-Reviewer: Julius Werner <jwerner@chromium.org> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki@gmail.com> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Nico Huber <nico.h@gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki@gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer@coreboot.org> Gerrit-Reviewer: Werner Zeh <werner.zeh@siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Reviewer: ron minnich <rminnich@gmail.com> Gerrit-Comment-Date: Mon, 21 Oct 2019 21:05:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Nico Huber <nico.h@gmx.de> Comment-In-Reply-To: Patrick Georgi <pgeorgi@google.com> Comment-In-Reply-To: Martin Roth <martinroth@google.com> Gerrit-MessageType: comment
Hello Kyösti Mälkki, Aaron Durbin, Julius Werner, Arthur Heymans, Stefan Reinauer, Paul Menzel, build bot (Jenkins), Patrick Georgi, Furquan Shaikh, Werner Zeh, ron minnich, David Hendricks, Philipp Deppenwiese, Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/36176 to look at the new patch set (#2). Change subject: RFC) src/acpi: Update license headers to SPDX ...................................................................... RFC) src/acpi: Update license headers to SPDX While I was working on updating the headers to move copyrights into the AUTHORS file, I got a request to switch to SPDX headers as well. Linux has moved completely to SPDX headers, which are easier to maintain, have good definitions, are very short, and can be checked automatically. This is completely unlike our current header situation. Signed-off-by: Martin Roth <martin@coreboot.org> Change-Id: Ie86d34f7fa7bf7434ad8a38aa1eadcfece7124b3 --- M src/acpi/Kconfig M src/acpi/Makefile.inc M src/acpi/sata.c M src/acpi/sata.h 4 files changed, 9 insertions(+), 24 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/36176/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/36176 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie86d34f7fa7bf7434ad8a38aa1eadcfece7124b3 Gerrit-Change-Number: 36176 Gerrit-PatchSet: 2 Gerrit-Owner: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Aaron Durbin <adurbin@chromium.org> Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz> Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com> Gerrit-Reviewer: Furquan Shaikh <furquan@google.com> Gerrit-Reviewer: Julius Werner <jwerner@chromium.org> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki@gmail.com> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Nico Huber <nico.h@gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki@gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer@coreboot.org> Gerrit-Reviewer: Werner Zeh <werner.zeh@siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Reviewer: ron minnich <rminnich@gmail.com> Gerrit-MessageType: newpatchset
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36176 ) Change subject: RFC) src/acpi: Update license headers to SPDX ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/36176 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie86d34f7fa7bf7434ad8a38aa1eadcfece7124b3 Gerrit-Change-Number: 36176 Gerrit-PatchSet: 2 Gerrit-Owner: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Aaron Durbin <adurbin@chromium.org> Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz> Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com> Gerrit-Reviewer: Furquan Shaikh <furquan@google.com> Gerrit-Reviewer: Julius Werner <jwerner@chromium.org> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki@gmail.com> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Nico Huber <nico.h@gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki@gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer@coreboot.org> Gerrit-Reviewer: Werner Zeh <werner.zeh@siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Reviewer: ron minnich <rminnich@gmail.com> Gerrit-Comment-Date: Mon, 21 Oct 2019 22:55:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36176 ) Change subject: RFC) src/acpi: Update license headers to SPDX ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/36176 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie86d34f7fa7bf7434ad8a38aa1eadcfece7124b3 Gerrit-Change-Number: 36176 Gerrit-PatchSet: 2 Gerrit-Owner: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Aaron Durbin <adurbin@chromium.org> Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz> Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com> Gerrit-Reviewer: Furquan Shaikh <furquan@google.com> Gerrit-Reviewer: Julius Werner <jwerner@chromium.org> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki@gmail.com> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Nico Huber <nico.h@gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki@gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer@coreboot.org> Gerrit-Reviewer: Werner Zeh <werner.zeh@siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Reviewer: ron minnich <rminnich@gmail.com> Gerrit-Comment-Date: Wed, 23 Oct 2019 17:09:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Hello Kyösti Mälkki, Aaron Durbin, Julius Werner, Arthur Heymans, Stefan Reinauer, Paul Menzel, build bot (Jenkins), Patrick Georgi, Furquan Shaikh, Werner Zeh, ron minnich, David Hendricks, Philipp Deppenwiese, Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/36176 to look at the new patch set (#3). Change subject: src/acpi: Update license headers to SPDX ...................................................................... src/acpi: Update license headers to SPDX While I was working on updating the headers to move copyrights into the AUTHORS file, I got a request to switch to SPDX headers as well. Linux has moved completely to SPDX headers, which are easier to maintain, have good definitions, are very short, and can be checked automatically. This is completely unlike our current header situation. Signed-off-by: Martin Roth <martin@coreboot.org> Change-Id: Ie86d34f7fa7bf7434ad8a38aa1eadcfece7124b3 --- M src/acpi/Kconfig M src/acpi/Makefile.inc M src/acpi/sata.c M src/acpi/sata.h 4 files changed, 9 insertions(+), 24 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/36176/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/36176 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie86d34f7fa7bf7434ad8a38aa1eadcfece7124b3 Gerrit-Change-Number: 36176 Gerrit-PatchSet: 3 Gerrit-Owner: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Aaron Durbin <adurbin@chromium.org> Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz> Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com> Gerrit-Reviewer: Furquan Shaikh <furquan@google.com> Gerrit-Reviewer: Julius Werner <jwerner@chromium.org> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki@gmail.com> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Nico Huber <nico.h@gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki@gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer@coreboot.org> Gerrit-Reviewer: Werner Zeh <werner.zeh@siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Reviewer: ron minnich <rminnich@gmail.com> Gerrit-MessageType: newpatchset
David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36176 ) Change subject: src/acpi: Update license headers to SPDX ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/36176 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie86d34f7fa7bf7434ad8a38aa1eadcfece7124b3 Gerrit-Change-Number: 36176 Gerrit-PatchSet: 3 Gerrit-Owner: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Aaron Durbin <adurbin@chromium.org> Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz> Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com> Gerrit-Reviewer: Furquan Shaikh <furquan@google.com> Gerrit-Reviewer: Julius Werner <jwerner@chromium.org> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki@gmail.com> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Nico Huber <nico.h@gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki@gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer@coreboot.org> Gerrit-Reviewer: Werner Zeh <werner.zeh@siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Reviewer: ron minnich <rminnich@gmail.com> Gerrit-Comment-Date: Thu, 24 Oct 2019 18:21:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36176 ) Change subject: src/acpi: Update license headers to SPDX ...................................................................... Patch Set 3: (1 comment) https://review.coreboot.org/c/coreboot/+/36176/1/src/acpi/sata.h File src/acpi/sata.h: https://review.coreboot.org/c/coreboot/+/36176/1/src/acpi/sata.h@1 PS1, Line 1: // SPDX-License-Identifier: GPL-2.0-only
+1 to Patrick's suggestion. […] Done
-- To view, visit https://review.coreboot.org/c/coreboot/+/36176 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie86d34f7fa7bf7434ad8a38aa1eadcfece7124b3 Gerrit-Change-Number: 36176 Gerrit-PatchSet: 3 Gerrit-Owner: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Aaron Durbin <adurbin@chromium.org> Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz> Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com> Gerrit-Reviewer: Furquan Shaikh <furquan@google.com> Gerrit-Reviewer: Julius Werner <jwerner@chromium.org> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki@gmail.com> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Nico Huber <nico.h@gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki@gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer@coreboot.org> Gerrit-Reviewer: Werner Zeh <werner.zeh@siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Reviewer: ron minnich <rminnich@gmail.com> Gerrit-Comment-Date: Sun, 27 Oct 2019 23:37:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: David Hendricks <david.hendricks@gmail.com> Comment-In-Reply-To: Nico Huber <nico.h@gmx.de> Comment-In-Reply-To: Patrick Georgi <pgeorgi@google.com> Comment-In-Reply-To: Martin Roth <martinroth@google.com> Gerrit-MessageType: comment
Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36176 ) Change subject: src/acpi: Update license headers to SPDX ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/36176 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie86d34f7fa7bf7434ad8a38aa1eadcfece7124b3 Gerrit-Change-Number: 36176 Gerrit-PatchSet: 4 Gerrit-Owner: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Aaron Durbin <adurbin@chromium.org> Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz> Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com> Gerrit-Reviewer: Furquan Shaikh <furquan@google.com> Gerrit-Reviewer: Julius Werner <jwerner@chromium.org> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki@gmail.com> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Nico Huber <nico.h@gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki@gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer@coreboot.org> Gerrit-Reviewer: Werner Zeh <werner.zeh@siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Reviewer: ron minnich <rminnich@gmail.com> Gerrit-Comment-Date: Thu, 07 Nov 2019 16:15:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/36176 ) Change subject: src/acpi: Update license headers to SPDX ...................................................................... src/acpi: Update license headers to SPDX While I was working on updating the headers to move copyrights into the AUTHORS file, I got a request to switch to SPDX headers as well. Linux has moved completely to SPDX headers, which are easier to maintain, have good definitions, are very short, and can be checked automatically. This is completely unlike our current header situation. Signed-off-by: Martin Roth <martin@coreboot.org> Change-Id: Ie86d34f7fa7bf7434ad8a38aa1eadcfece7124b3 Reviewed-on: https://review.coreboot.org/c/coreboot/+/36176 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Werner Zeh <werner.zeh@siemens.com> Reviewed-by: David Hendricks <david.hendricks@gmail.com> --- M src/acpi/Kconfig M src/acpi/Makefile.inc M src/acpi/sata.c M src/acpi/sata.h 4 files changed, 9 insertions(+), 24 deletions(-) Approvals: build bot (Jenkins): Verified David Hendricks: Looks good to me, approved Werner Zeh: Looks good to me, approved diff --git a/src/acpi/Kconfig b/src/acpi/Kconfig index 72cfff5..3c6aeb1 100644 --- a/src/acpi/Kconfig +++ b/src/acpi/Kconfig @@ -1,3 +1,5 @@ +# SPDX-License-Identifier: GPL-2.0-only +# This file is part of the coreboot project. config ACPI_SATA_GENERATOR bool diff --git a/src/acpi/Makefile.inc b/src/acpi/Makefile.inc index 53ac679..7c2092d 100644 --- a/src/acpi/Makefile.inc +++ b/src/acpi/Makefile.inc @@ -1 +1,4 @@ +# SPDX-License-Identifier: GPL-2.0-only +# This file is part of the coreboot project. + ramstage-$(CONFIG_ACPI_SATA_GENERATOR) += sata.c diff --git a/src/acpi/sata.c b/src/acpi/sata.c index d7fcbd6..f2b3811 100644 --- a/src/acpi/sata.c +++ b/src/acpi/sata.c @@ -1,15 +1,5 @@ -/* - * This file is part of the coreboot project. - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License version 2 as - * published by the Free Software Foundation. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ +/* SPDX-License-Identifier: GPL-2.0-only */ +/* This file is part of the coreboot project. */ #include "sata.h" diff --git a/src/acpi/sata.h b/src/acpi/sata.h index fecf4c6..5ca2eac 100644 --- a/src/acpi/sata.h +++ b/src/acpi/sata.h @@ -1,15 +1,5 @@ -/* - * This file is part of the coreboot project. - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ +/* SPDX-License-Identifier: GPL-2.0-only */ +/* This file is part of the coreboot project. */ #ifndef __ACPI_SATA_H__ #define __ACPI_SATA_H__ -- To view, visit https://review.coreboot.org/c/coreboot/+/36176 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie86d34f7fa7bf7434ad8a38aa1eadcfece7124b3 Gerrit-Change-Number: 36176 Gerrit-PatchSet: 5 Gerrit-Owner: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Aaron Durbin <adurbin@chromium.org> Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz> Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com> Gerrit-Reviewer: Furquan Shaikh <furquan@google.com> Gerrit-Reviewer: Julius Werner <jwerner@chromium.org> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki@gmail.com> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Nico Huber <nico.h@gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki@gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer@coreboot.org> Gerrit-Reviewer: Werner Zeh <werner.zeh@siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Reviewer: ron minnich <rminnich@gmail.com> Gerrit-MessageType: merged
participants (6)
-
Aaron Durbin (Code Review) -
David Hendricks (Code Review)
-
Martin Roth (Code Review)
-
Nico Huber (Code Review)
-
Patrick Georgi (Code Review)
-
Werner Zeh (Code Review)