Subrata Banik has posted comments on this change. ( https://review.coreboot.org/18557 ) Change subject: soc/intel/common/block: [WIP]Add Intel common FAST_SPI code ...................................................................... Patch Set 17: (4 comments) https://review.coreboot.org/#/c/18557/17/src/soc/intel/common/block/fast_spi... File src/soc/intel/common/block/fast_spi/fast_spi.c: Line 22: can we have some /*TODO*/ so that next time, when we create flash_ctrl.c as library, we know what all code we need to remove and make as static to ensure user shouldn't know abut such functionality PS17, Line 155: device_t dev can't we use device_t as local here after we have common pci_dev name? https://review.coreboot.org/#/c/18557/17/src/soc/intel/common/block/include/... File src/soc/intel/common/block/include/intelblocks/fast_spi.h: PS17, Line 4: Copyright 2017 Intel Corporation. please adhere comments from Summet, missing (C) https://review.coreboot.org/#/c/18557/17/src/soc/intel/common/block/include/... File src/soc/intel/common/block/include/intelblocks/fast_spi_def.h: PS17, Line 4: * Copyright 2017 Intel Corporation. -same -- To view, visit https://review.coreboot.org/18557 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I046e3b30c8efb172851dd17f49565c9ec4cb38cb Gerrit-PatchSet: 17 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Barnali Sarkar <barnali.sarkar@intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra@intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin@chromium.org> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan@intel.com> Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar@intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan@google.com> Gerrit-Reviewer: Hannah Williams <hannah.williams@intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Reviewer: Pratikkumar Prajapati <pratikkumar.v.prajapati@intel.corp-partner.google.com> Gerrit-Reviewer: Subrata Banik <subrata.banik@intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik@intel.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: Yes