Attention is currently required from: Arthur Heymans, Maximilian Brune, Nico Huber. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80776?usp=email ) Change subject: lib: Declare heap in assembly ...................................................................... Patch Set 3: (1 comment) File src/lib/program.ld: https://review.coreboot.org/c/coreboot/+/80776/comment/025e7559_ab9a2cb4 : PS3, Line 141: }

...

...

I think a simpler solution is to just add a `: to_load` here. (We already have that for the `. […] `to_load` is just how we call the program segment, it could be any name. I'm not exactly sure what's happening here but there seems to be some heuristic that sections which are explicitly marked as NOLOAD and don't contain any actual objects aren't automatically added to a suitable program segment like all sections normally are. Adding the segment assignment explicitly works around that. (In general linker scripts seem to rely on a lot of these "magic defaults" for backwards compatibility with how things were "commonly done" in the past, it's probably better to rely less on that and write more stuff explicitly where possible.)

-- To view, visit https://review.coreboot.org/c/coreboot/+/80776?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I67cb5ce886fda313e0720b0bc7c6e66e4aae45fa Gerrit-Change-Number: 80776 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur@aheymans.xyz> Gerrit-Reviewer: Julius Werner <jwerner@chromium.org> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan@9elements.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune@9elements.com> Gerrit-Reviewer: Nico Huber <nico.h@gmx.de> Gerrit-Reviewer: Subrata Banik <subratabanik@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Tim Van Patten <timvp@google.com> Gerrit-Attention: Nico Huber <nico.h@gmx.de> Gerrit-Attention: Maximilian Brune <maximilian.brune@9elements.com> Gerrit-Attention: Arthur Heymans <arthur@aheymans.xyz> Gerrit-Comment-Date: Thu, 29 Feb 2024 21:08:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Julius Werner <jwerner@chromium.org> Comment-In-Reply-To: Arthur Heymans <arthur@aheymans.xyz> Gerrit-MessageType: comment