Attention is currently required from: Boris Mittelberg, Caveh Jalali, Chao Jhan Bo, Jon Murphy, Karthik Ramasubramanian, Keith Short, Subrata Banik. Paul Menzel has posted comments on this change by Chao Jhan Bo. ( https://review.coreboot.org/c/coreboot/+/87544?usp=email ) Change subject: ec/google: Add support for Realtek EC in ChromeOS EC ...................................................................... Patch Set 21: (5 comments) File src/ec/google/chromeec/rtk.c: https://review.coreboot.org/c/coreboot/+/87544/comment/3778992d_0c51e607?usp... : PS21, Line 70: initial initiated? https://review.coreboot.org/c/coreboot/+/87544/comment/2b7db855_5bc88605?usp... : PS21, Line 71: need need*s* https://review.coreboot.org/c/coreboot/+/87544/comment/6a437a1a_d5cd4648?usp... : PS21, Line 71: emi EMI https://review.coreboot.org/c/coreboot/+/87544/comment/e19b3f14_2fa45c09?usp... : PS21, Line 71: acpi ACPI https://review.coreboot.org/c/coreboot/+/87544/comment/7cea50cc_d40fe118?usp... : PS21, Line 74: printk(BIOS_INFO, "RTS5915 EMI initial.\n"); Add it to the end, or do two: printk(BIOS_INFO, "RTS5915 EMI: start init …\n"); […] printk(BIOS_INFO, "done\n"); (If it’s multi-threaded that won’t work though, so then only one message at the end?) -- To view, visit https://review.coreboot.org/c/coreboot/+/87544?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I44118c7b61a7efcee81acdd04be90b5022007a41 Gerrit-Change-Number: 87544 Gerrit-PatchSet: 21 Gerrit-Owner: Chao Jhan Bo <jhan_bo_chao@realtek.corp-partner.google.com> Gerrit-Reviewer: Boris Mittelberg <bmbm@google.com> Gerrit-Reviewer: Caveh Jalali <caveh@chromium.org> Gerrit-Reviewer: Keith Short <keithshort@chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Jon Murphy <jpmurphy@google.com> Gerrit-CC: Karthik Ramasubramanian <kramasub@google.com> Gerrit-CC: Paul Menzel <paulepanter@mailbox.org> Gerrit-Attention: Keith Short <keithshort@chromium.org> Gerrit-Attention: Subrata Banik <subratabanik@google.com> Gerrit-Attention: Caveh Jalali <caveh@chromium.org> Gerrit-Attention: Jon Murphy <jpmurphy@google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub@google.com> Gerrit-Attention: Chao Jhan Bo <jhan_bo_chao@realtek.corp-partner.google.com> Gerrit-Attention: Boris Mittelberg <bmbm@google.com> Gerrit-Comment-Date: Fri, 30 May 2025 09:37:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No