James Ye has posted comments on this change. ( https://review.coreboot.org/20814 ) Change subject: intel/sandybridge: Clean VGA BIOS ids up a little ...................................................................... Patch Set 2: (2 comments) https://review.coreboot.org/#/c/20814/2/src/northbridge/intel/sandybridge/gm... File src/northbridge/intel/sandybridge/gma.c: https://review.coreboot.org/#/c/20814/2/src/northbridge/intel/sandybridge/gm... PS2, Line 270: case 0x80860152: /* IVB Desktop */ : case 0x80860156: /* IVB Mobile */ : case 0x80860162: /* IVB Desktop */ : case 0x80860166: /* IVB Mobile */ Inconsistent indenting? https://review.coreboot.org/#/c/20814/2/util/autoport/sandybridge.go File util/autoport/sandybridge.go: https://review.coreboot.org/#/c/20814/2/util/autoport/sandybridge.go@145 PS2, Line 145: 0x0112, 0x0116, 0x0122, 0x0126, : 0x0152, 0x0156, 0x0162, 0x0166, Should probably be spaces after the comma, not a tab. -- To view, visit https://review.coreboot.org/20814 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I12f24f415b695c516fbb947114e09c873af2e439 Gerrit-Change-Number: 20814 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h@gmx.de> Gerrit-Reviewer: Alexander Couzens <lynxis@fe80.eu> Gerrit-Reviewer: James Ye <jye836@gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Comment-Date: Sat, 29 Jul 2017 01:37:41 +0000 Gerrit-HasComments: Yes