Attention is currently required from: Arthur Heymans, Raul Rangel, Mariusz Szafrański, Jonathan Zhang, Patrick Rudolph, Jason Glenesk, Anjaneya "Reddy" Chagam, Marshall Dawson, Johnny Lin, Suresh Bellampalli, Vanessa Eusebio, Michal Motyl, Morgan Jang, Felix Held. Hello Arthur Heymans, build bot (Jenkins), Raul Rangel, Mariusz Szafrański, Jonathan Zhang, Patrick Rudolph, Jason Glenesk, Anjaneya "Reddy" Chagam, Marshall Dawson, Johnny Lin, Suresh Bellampalli, Vanessa Eusebio, Michal Motyl, Morgan Jang, Felix Held, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/55012 to look at the new patch set (#2). Change subject: arch/x86: Set RTC century byte offset in FADT x86-wide ...................................................................... arch/x86: Set RTC century byte offset in FADT x86-wide The century byte of the year is stored in CMOS at offset 0x32 for all x86 platforms (done by MC146818 RTC code which is default enabled for x86). This location is not fixed per definition but is established during the past years as 'de facto' standard. This offset is passed into the OS via the ACPI FADT where e.g. Linux uses it if it is set to something != 0. Currently this byte is set differently on all the platforms, either to 0x32 or to 0x0 or even to nothing which results in 0x0. Since this is architecture specific and valid for all the platforms, set this century byte once in the architecture specific code. Change-Id: I8fa5ddc368c129a5f847c64064374aae2d4f0c43 Signed-off-by: Werner Zeh <werner.zeh@siemens.com> --- M src/arch/x86/acpi.c M src/soc/amd/cezanne/acpi.c M src/soc/amd/cezanne/include/soc/acpi.h M src/soc/amd/picasso/acpi.c M src/soc/amd/stoneyridge/acpi.c M src/soc/intel/baytrail/fadt.c M src/soc/intel/braswell/fadt.c M src/soc/intel/broadwell/pch/fadt.c M src/soc/intel/denverton_ns/acpi.c M src/soc/intel/elkhartlake/acpi.c M src/soc/intel/skylake/fadt.c M src/soc/intel/xeon_sp/skx/soc_acpi.c M src/southbridge/amd/agesa/hudson/fadt.c M src/southbridge/amd/cimx/sb800/fadt.c M src/southbridge/amd/pi/hudson/fadt.c M src/southbridge/intel/bd82x6x/fadt.c M src/southbridge/intel/i82371eb/fadt.c M src/southbridge/intel/i82801dx/fadt.c M src/southbridge/intel/i82801gx/fadt.c M src/southbridge/intel/i82801ix/fadt.c M src/southbridge/intel/i82801jx/fadt.c M src/southbridge/intel/ibexpeak/fadt.c M src/southbridge/intel/lynxpoint/fadt.c 23 files changed, 2 insertions(+), 23 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/55012/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/55012 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8fa5ddc368c129a5f847c64064374aae2d4f0c43 Gerrit-Change-Number: 55012 Gerrit-PatchSet: 2 Gerrit-Owner: Werner Zeh <werner.zeh@siemens.com> Gerrit-Reviewer: Anjaneya "Reddy" Chagam <anjaneya.chagam@intel.com> Gerrit-Reviewer: Arthur Heymans <arthur.heymans@9elements.com> Gerrit-Reviewer: Felix Held <felix-coreboot@felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk@gmail.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin@wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang@fb.com> Gerrit-Reviewer: Mariusz Szafrański <mariuszx.szafranski@intel.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd@gmail.com> Gerrit-Reviewer: Michal Motyl <michalx.motyl@intel.com> Gerrit-Reviewer: Morgan Jang <Morgan_Jang@wiwynn.com> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: Raul Rangel <rrangel@chromium.org> Gerrit-Reviewer: Suresh Bellampalli <suresh.bellampalli@intel.com> Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio@intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Paul Menzel <paulepanter@mailbox.org> Gerrit-Attention: Arthur Heymans <arthur.heymans@9elements.com> Gerrit-Attention: Raul Rangel <rrangel@chromium.org> Gerrit-Attention: Mariusz Szafrański <mariuszx.szafranski@intel.com> Gerrit-Attention: Jonathan Zhang <jonzhang@fb.com> Gerrit-Attention: Patrick Rudolph <siro@das-labor.org> Gerrit-Attention: Jason Glenesk <jason.glenesk@gmail.com> Gerrit-Attention: Anjaneya "Reddy" Chagam <anjaneya.chagam@intel.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd@gmail.com> Gerrit-Attention: Johnny Lin <Johnny_Lin@wiwynn.com> Gerrit-Attention: Suresh Bellampalli <suresh.bellampalli@intel.com> Gerrit-Attention: Vanessa Eusebio <vanessa.f.eusebio@intel.com> Gerrit-Attention: Michal Motyl <michalx.motyl@intel.com> Gerrit-Attention: Morgan Jang <Morgan_Jang@wiwynn.com> Gerrit-Attention: Felix Held <felix-coreboot@felixheld.de> Gerrit-MessageType: newpatchset