Attention is currently required from: Subrata Banik, Tim Wawrzynczak, Paul Menzel, Kane Chen. Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63169 ) Change subject: soc/intel/common: Update CSE sub partition update ...................................................................... Patch Set 6: (1 comment) File src/soc/intel/common/block/cse/cse_lite.c: https://review.coreboot.org/c/coreboot/+/63169/comment/08a6f192_a38d440e PS5, Line 955: static const char * const cse_regions[] = {"RO", "RW"};

Since you are also reusing this ("RO" anyway) on line 793, does it make sense to move this declarati […] Ack

-- To view, visit https://review.coreboot.org/c/coreboot/+/63169 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie9a83b77ab44ea6ffe5bb20673e109a89a148629 Gerrit-Change-Number: 63169 Gerrit-PatchSet: 6 Gerrit-Owner: Sridhar Siricilla <sridhar.siricilla@intel.com> Gerrit-Reviewer: Kane Chen <kane.chen@intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik@google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak@chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Paul Menzel <paulepanter@mailbox.org> Gerrit-Attention: Subrata Banik <subratabanik@google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak@chromium.org> Gerrit-Attention: Paul Menzel <paulepanter@mailbox.org> Gerrit-Attention: Kane Chen <kane.chen@intel.com> Gerrit-Comment-Date: Tue, 05 Apr 2022 17:34:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak@chromium.org> Gerrit-MessageType: comment