Change in coreboot[master]: soc/intel/cannonlake/acpi/serialio.asl: Don't advertise unavailable d...
Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44198 ) Change subject: soc/intel/cannonlake/acpi/serialio.asl: Don't advertise unavailable devices ...................................................................... soc/intel/cannonlake/acpi/serialio.asl: Don't advertise unavailable devices On PCH-H the I2C4 0:19.0 device isn't usable and thus 0:19.1 and 0:19.2 can't be detected using standard PCI probing. Remove I2C4, I2C5 and UART2 from generic ASL code on PCH-H platforms. Change-Id: I89f9ab7d4afb2e7d1b1e24d072adf99e0da6fecf Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com> --- M src/soc/intel/cannonlake/acpi/serialio.asl 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/44198/1 diff --git a/src/soc/intel/cannonlake/acpi/serialio.asl b/src/soc/intel/cannonlake/acpi/serialio.asl index e4a675e..d88c570 100644 --- a/src/soc/intel/cannonlake/acpi/serialio.asl +++ b/src/soc/intel/cannonlake/acpi/serialio.asl @@ -26,6 +26,7 @@ Name (_DDN, "Serial IO I2C Controller 3") } +#if !CONFIG(SOC_INTEL_CANNONLAKE_PCH_H) Device (I2C4) { Name (_ADR, 0x00190000) @@ -37,6 +38,7 @@ Name (_ADR, 0x00190001) Name (_DDN, "Serial IO I2C Controller 5") } +#endif Device (SPI0) { @@ -56,6 +58,7 @@ Name (_DDN, "Serial IO SPI Controller 2") } +#if !CONFIG(SOC_INTEL_CANNONLAKE_PCH_H) Device (UAR0) { Name (_ADR, 0x001e0000) @@ -73,3 +76,4 @@ Name (_ADR, 0x00190002) Name (_DDN, "Serial IO UART Controller 2") } +#endif -- To view, visit https://review.coreboot.org/c/coreboot/+/44198 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I89f9ab7d4afb2e7d1b1e24d072adf99e0da6fecf Gerrit-Change-Number: 44198 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <patrick.rudolph@9elements.com> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-MessageType: newchange
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44198 ) Change subject: soc/intel/cannonlake/acpi/serialio.asl: Don't advertise unavailable devices ...................................................................... Patch Set 1: Code-Review+1 (1 comment) https://review.coreboot.org/c/coreboot/+/44198/1/src/soc/intel/cannonlake/ac... File src/soc/intel/cannonlake/acpi/serialio.asl: https://review.coreboot.org/c/coreboot/+/44198/1/src/soc/intel/cannonlake/ac... PS1, Line 62: Device (UAR0) : { : Name (_ADR, 0x001e0000) : Name (_DDN, "Serial IO UART Controller 0") : } : : Device (UAR1) : { : Name (_ADR, 0x001e0001) : Name (_DDN, "Serial IO UART Controller 1") : } These aren't mentioned in the commit message -- To view, visit https://review.coreboot.org/c/coreboot/+/44198 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I89f9ab7d4afb2e7d1b1e24d072adf99e0da6fecf Gerrit-Change-Number: 44198 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <patrick.rudolph@9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Comment-Date: Wed, 05 Aug 2020 08:40:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44198 ) Change subject: soc/intel/cannonlake/acpi/serialio.asl: Don't advertise unavailable devices ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/c/coreboot/+/44198/1/src/soc/intel/cannonlake/ac... File src/soc/intel/cannonlake/acpi/serialio.asl: https://review.coreboot.org/c/coreboot/+/44198/1/src/soc/intel/cannonlake/ac... PS1, Line 62: Device (UAR0) : { : Name (_ADR, 0x001e0000) : Name (_DDN, "Serial IO UART Controller 0") : } : : Device (UAR1) : { : Name (_ADR, 0x001e0001) : Name (_DDN, "Serial IO UART Controller 1") : }
These aren't mentioned in the commit message Good catch. That's also wrong. Both device operate fine in PCI mode.
-- To view, visit https://review.coreboot.org/c/coreboot/+/44198 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I89f9ab7d4afb2e7d1b1e24d072adf99e0da6fecf Gerrit-Change-Number: 44198 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <patrick.rudolph@9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Comment-Date: Wed, 05 Aug 2020 17:50:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com> Gerrit-MessageType: comment
Hello build bot (Jenkins), Angel Pons, Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/44198 to look at the new patch set (#2). Change subject: soc/intel/cannonlake/acpi/serialio.asl: Don't advertise unavailable devices ...................................................................... soc/intel/cannonlake/acpi/serialio.asl: Don't advertise unavailable devices On PCH-H the I2C4 0:19.0 device isn't usable and thus 0:19.1 and 0:19.2 can't be detected using standard PCI probing. Remove I2C4, I2C5 and UART2 from generic ASL code on PCH-H platforms that advertise its PCI conformance by the _ADR attribute. Change-Id: I89f9ab7d4afb2e7d1b1e24d072adf99e0da6fecf Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com> --- M src/soc/intel/cannonlake/acpi/serialio.asl 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/44198/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/44198 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I89f9ab7d4afb2e7d1b1e24d072adf99e0da6fecf Gerrit-Change-Number: 44198 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph <patrick.rudolph@9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-MessageType: newpatchset
Hello build bot (Jenkins), Angel Pons, Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/44198 to look at the new patch set (#3). Change subject: soc/intel/cannonlake/acpi/serialio.asl: Don't advertise unavailable devices ...................................................................... soc/intel/cannonlake/acpi/serialio.asl: Don't advertise unavailable devices On PCH-H the I2C4 0:19.0 device isn't usable and thus 0:19.1 and 0:19.2 can't be detected using standard PCI probing. Remove I2C4, I2C5 and UART2 from generic ASL code on PCH-H platforms that advertise its PCI conformance by the _ADR attribute. Change-Id: I89f9ab7d4afb2e7d1b1e24d072adf99e0da6fecf Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com> --- M src/soc/intel/cannonlake/acpi/serialio.asl 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/44198/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/44198 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I89f9ab7d4afb2e7d1b1e24d072adf99e0da6fecf Gerrit-Change-Number: 44198 Gerrit-PatchSet: 3 Gerrit-Owner: Patrick Rudolph <patrick.rudolph@9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-MessageType: newpatchset
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44198 ) Change subject: soc/intel/cannonlake/acpi/serialio.asl: Don't advertise unavailable devices ...................................................................... Patch Set 3: (1 comment) https://review.coreboot.org/c/coreboot/+/44198/1/src/soc/intel/cannonlake/ac... File src/soc/intel/cannonlake/acpi/serialio.asl: https://review.coreboot.org/c/coreboot/+/44198/1/src/soc/intel/cannonlake/ac... PS1, Line 62: Device (UAR0) : { : Name (_ADR, 0x001e0000) : Name (_DDN, "Serial IO UART Controller 0") : } : : Device (UAR1) : { : Name (_ADR, 0x001e0001) : Name (_DDN, "Serial IO UART Controller 1") : }
Good catch. That's also wrong. Both device operate fine in PCI mode. Done
-- To view, visit https://review.coreboot.org/c/coreboot/+/44198 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I89f9ab7d4afb2e7d1b1e24d072adf99e0da6fecf Gerrit-Change-Number: 44198 Gerrit-PatchSet: 3 Gerrit-Owner: Patrick Rudolph <patrick.rudolph@9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Comment-Date: Thu, 06 Aug 2020 05:46:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com> Comment-In-Reply-To: Patrick Rudolph <siro@das-labor.org> Gerrit-MessageType: comment
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44198 ) Change subject: soc/intel/cannonlake/acpi/serialio.asl: Don't advertise unavailable devices ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/44198 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I89f9ab7d4afb2e7d1b1e24d072adf99e0da6fecf Gerrit-Change-Number: 44198 Gerrit-PatchSet: 3 Gerrit-Owner: Patrick Rudolph <patrick.rudolph@9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Comment-Date: Thu, 06 Aug 2020 07:14:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Angel Pons has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44198 ) Change subject: soc/intel/cannonlake/acpi/serialio.asl: Don't advertise unavailable devices ...................................................................... soc/intel/cannonlake/acpi/serialio.asl: Don't advertise unavailable devices On PCH-H the I2C4 0:19.0 device isn't usable and thus 0:19.1 and 0:19.2 can't be detected using standard PCI probing. Remove I2C4, I2C5 and UART2 from generic ASL code on PCH-H platforms that advertise its PCI conformance by the _ADR attribute. Change-Id: I89f9ab7d4afb2e7d1b1e24d072adf99e0da6fecf Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/44198 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Angel Pons <th3fanbus@gmail.com> --- M src/soc/intel/cannonlake/acpi/serialio.asl 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved diff --git a/src/soc/intel/cannonlake/acpi/serialio.asl b/src/soc/intel/cannonlake/acpi/serialio.asl index e4a675e..0551191 100644 --- a/src/soc/intel/cannonlake/acpi/serialio.asl +++ b/src/soc/intel/cannonlake/acpi/serialio.asl @@ -26,6 +26,7 @@ Name (_DDN, "Serial IO I2C Controller 3") } +#if !CONFIG(SOC_INTEL_CANNONLAKE_PCH_H) Device (I2C4) { Name (_ADR, 0x00190000) @@ -37,6 +38,7 @@ Name (_ADR, 0x00190001) Name (_DDN, "Serial IO I2C Controller 5") } +#endif Device (SPI0) { @@ -68,8 +70,10 @@ Name (_DDN, "Serial IO UART Controller 1") } +#if !CONFIG(SOC_INTEL_CANNONLAKE_PCH_H) Device (UAR2) { Name (_ADR, 0x00190002) Name (_DDN, "Serial IO UART Controller 2") } +#endif -- To view, visit https://review.coreboot.org/c/coreboot/+/44198 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I89f9ab7d4afb2e7d1b1e24d072adf99e0da6fecf Gerrit-Change-Number: 44198 Gerrit-PatchSet: 4 Gerrit-Owner: Patrick Rudolph <patrick.rudolph@9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-MessageType: merged
participants (2)
-
Angel Pons (Code Review) -
Patrick Rudolph (Code Review)