Attention is currently required from: Anil Kumar K, Bora Guvendik, Cliff Huang, Hannah Williams, Paul Menzel. Subrata Banik has posted comments on this change by Cliff Huang. ( https://review.coreboot.org/c/coreboot/+/84103?usp=email ) Change subject: soc/intel/common/block/acpi: Add GPE1 blocks to ACPI FADT table ...................................................................... Patch Set 13: (4 comments) File src/soc/intel/common/block/acpi/acpi.c: https://review.coreboot.org/c/coreboot/+/84103/comment/5eb4794c_422abf59?usp... : PS7, Line 121: if (CONFIG(SOC_INTEL_COMMON_BLOCK_ACPI_USE_GPE1)) {

sure. agree. Acknowledged

File src/soc/intel/common/block/acpi/acpi.c: https://review.coreboot.org/c/coreboot/+/84103/comment/af391b71_7bac40c5?usp... : PS11, Line 115: 0

Subrata, […] Acknowledged

File src/soc/intel/common/block/include/intelblocks/pmclib.h: https://review.coreboot.org/c/coreboot/+/84103/comment/d426ee2b_f76c4125?usp... : PS13, Line 144: * drop this new line https://review.coreboot.org/c/coreboot/+/84103/comment/7cbea562_2a62725f?usp... : PS13, Line 146: drop this new line -- To view, visit https://review.coreboot.org/c/coreboot/+/84103?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia6928c35b86f4a2243d58597b17b2a3a5f54271e Gerrit-Change-Number: 84103 Gerrit-PatchSet: 13 Gerrit-Owner: Cliff Huang <cliff.huang@intel.com> Gerrit-Reviewer: Anil Kumar K <anil.kumar.k@intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik@intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Hannah Williams <hannah.williams@intel.com> Gerrit-CC: Paul Menzel <paulepanter@mailbox.org> Gerrit-Attention: Bora Guvendik <bora.guvendik@intel.com> Gerrit-Attention: Hannah Williams <hannah.williams@intel.com> Gerrit-Attention: Anil Kumar K <anil.kumar.k@intel.com> Gerrit-Attention: Cliff Huang <cliff.huang@intel.com> Gerrit-Attention: Paul Menzel <paulepanter@mailbox.org> Gerrit-Comment-Date: Sun, 01 Sep 2024 03:11:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Cliff Huang <cliff.huang@intel.com> Comment-In-Reply-To: Subrata Banik <subratabanik@google.com>