Attention is currently required from: Julius Werner, Alex James. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60233 ) Change subject: util/cbfstool: Replace swab.h with commonlib/bsd/sysincludes.h ...................................................................... Patch Set 10: (3 comments) File util/cbfstool/cbfs.h: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136841): https://review.coreboot.org/c/coreboot/+/60233/comment/e974ba4a_5338dd31 PS10, Line 57: #define CBFS_SUBHEADER(_p) ( (void *) ((((uint8_t *) (_p)) + be32toh((_p)->offset))) ) space prohibited after that open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136841): https://review.coreboot.org/c/coreboot/+/60233/comment/952cf6c9_97eb361f PS10, Line 57: #define CBFS_SUBHEADER(_p) ( (void *) ((((uint8_t *) (_p)) + be32toh((_p)->offset))) ) space prohibited before that close parenthesis ')' File util/cbfstool/cbfs_image.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136841): https://review.coreboot.org/c/coreboot/+/60233/comment/337b9336_bca6c6a5 PS10, Line 89: if (((char *)entry) + be32toh(entry->offset) == hdr_loc) { braces {} are not necessary for single statement blocks -- To view, visit https://review.coreboot.org/c/coreboot/+/60233 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I54195865ab4042fcf83609fcf67ef8f33994d68e Gerrit-Change-Number: 60233 Gerrit-PatchSet: 10 Gerrit-Owner: Alex James <theracermaster@gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Idwer Vollering <vidwer@gmail.com> Gerrit-Reviewer: Julius Werner <jwerner@chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter@mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Attention: Julius Werner <jwerner@chromium.org> Gerrit-Attention: Alex James <theracermaster@gmail.com> Gerrit-Comment-Date: Fri, 31 Dec 2021 23:05:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment