Change in coreboot[master]: cpu/intel/model_68x_6bx: Update ucode before enabling cache
Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44238 ) Change subject: cpu/intel/model_68x_6bx: Update ucode before enabling cache ...................................................................... cpu/intel/model_68x_6bx: Update ucode before enabling cache Other similar CPUs update the microcode first, so do the same here. Change-Id: I9dda712043e1d17c3cc860d38b5daf8adfa882fa Signed-off-by: Angel Pons <th3fanbus@gmail.com> --- M src/cpu/intel/model_68x_6bx/model_68x_6bx_init.c 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/44238/1 diff --git a/src/cpu/intel/model_68x_6bx/model_68x_6bx_init.c b/src/cpu/intel/model_68x_6bx/model_68x_6bx_init.c index dc23a7be..06ac099 100644 --- a/src/cpu/intel/model_68x_6bx/model_68x_6bx_init.c +++ b/src/cpu/intel/model_68x_6bx/model_68x_6bx_init.c @@ -13,12 +13,12 @@ { char processor_name[49]; - /* Turn on caching if we haven't already */ - x86_enable_cache(); - /* Update the microcode */ intel_update_microcode_from_cbfs(); + /* Turn on caching if we haven't already */ + x86_enable_cache(); + /* Print processor name */ fill_processor_name(processor_name); printk(BIOS_INFO, "CPU: %s.\n", processor_name); -- To view, visit https://review.coreboot.org/c/coreboot/+/44238 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9dda712043e1d17c3cc860d38b5daf8adfa882fa Gerrit-Change-Number: 44238 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-MessageType: newchange
Hello Keith Hui, build bot (Jenkins), Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/44238 to look at the new patch set (#2). Change subject: cpu/intel/model_68x_6bx: Update ucode before enabling cache ...................................................................... cpu/intel/model_68x_6bx: Update ucode before enabling cache Other similar CPUs update the microcode first, so do the same here. Change-Id: I9dda712043e1d17c3cc860d38b5daf8adfa882fa Signed-off-by: Angel Pons <th3fanbus@gmail.com> --- M src/cpu/intel/model_68x_6bx/model_68x_6bx_init.c 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/44238/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/44238 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9dda712043e1d17c3cc860d38b5daf8adfa882fa Gerrit-Change-Number: 44238 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Keith Hui <buurin@gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-MessageType: newpatchset
Hello Keith Hui, build bot (Jenkins), Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/44238 to look at the new patch set (#4). Change subject: cpu/intel/model_68x_6bx: Update ucode before enabling cache ...................................................................... cpu/intel/model_68x_6bx: Update ucode before enabling cache Other similar CPUs update the microcode first, so do the same here. Change-Id: I9dda712043e1d17c3cc860d38b5daf8adfa882fa Signed-off-by: Angel Pons <th3fanbus@gmail.com> --- M src/cpu/intel/model_68x_6bx/model_68x_6bx_init.c 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/44238/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/44238 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9dda712043e1d17c3cc860d38b5daf8adfa882fa Gerrit-Change-Number: 44238 Gerrit-PatchSet: 4 Gerrit-Owner: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Keith Hui <buurin@gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-MessageType: newpatchset
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44238 ) Change subject: cpu/intel/model_68x_6bx: Update ucode before enabling cache ...................................................................... Patch Set 4: (1 comment) https://review.coreboot.org/c/coreboot/+/44238/4/src/cpu/intel/model_68x_6bx... File src/cpu/intel/model_68x_6bx/model_68x_6bx_init.c: https://review.coreboot.org/c/coreboot/+/44238/4/src/cpu/intel/model_68x_6bx... PS4, Line 18: : /* Turn on caching if we haven't already */ : x86_enable_cache(); is this tested ? -- To view, visit https://review.coreboot.org/c/coreboot/+/44238 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9dda712043e1d17c3cc860d38b5daf8adfa882fa Gerrit-Change-Number: 44238 Gerrit-PatchSet: 4 Gerrit-Owner: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Keith Hui <buurin@gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Fri, 07 Aug 2020 06:17:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44238 ) Change subject: cpu/intel/model_68x_6bx: Update ucode before enabling cache ...................................................................... Patch Set 4: (1 comment) Keith, could you please boot-test this change? https://review.coreboot.org/c/coreboot/+/44238/4/src/cpu/intel/model_68x_6bx... File src/cpu/intel/model_68x_6bx/model_68x_6bx_init.c: https://review.coreboot.org/c/coreboot/+/44238/4/src/cpu/intel/model_68x_6bx... PS4, Line 18: : /* Turn on caching if we haven't already */ : x86_enable_cache();
is this tested ? That's why I added Keith as a reviewer.
-- To view, visit https://review.coreboot.org/c/coreboot/+/44238 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9dda712043e1d17c3cc860d38b5daf8adfa882fa Gerrit-Change-Number: 44238 Gerrit-PatchSet: 4 Gerrit-Owner: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Keith Hui <buurin@gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Fri, 07 Aug 2020 10:00:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-MessageType: comment
Angel Pons has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/44238 ) Change subject: cpu/intel/model_68x_6bx: Update ucode before enabling cache ...................................................................... Abandoned Sorry, I ran out of patience and energy to care about these changes any longer. -- To view, visit https://review.coreboot.org/c/coreboot/+/44238 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9dda712043e1d17c3cc860d38b5daf8adfa882fa Gerrit-Change-Number: 44238 Gerrit-PatchSet: 6 Gerrit-Owner: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Keith Hui <buurin@gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-MessageType: abandon
participants (2)
-
Angel Pons (Code Review) -
HAOUAS Elyes (Code Review)